View Change
3 comments:
File Makefile:
Patch Set #3, Line 171: include $(DOTCONFIG)
Hmm... okay, fair enough, I see that there are some benefits to that (e.g. […]
As of now, I think it will be better to add some default variables into a Makefile, which can be overwritten by a cmdline provided along with "make unit-tests". This way we are isolating firmware build system from unit tests build system.
Will work on this in future.
File tests/Makefile.inc:
Patch Set #3, Line 58: $$($(1)-stage)
Ack. […]
Good. After all, hopefully error message is clear and should be easy if one would like to change this const list.
File tests/Makefile.inc:
To view, visit change 39894. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b0220b84b9a6e448476ca3eb3ccccc5fb829ad1
Gerrit-Change-Number: 39894
Gerrit-PatchSet: 5
Gerrit-Owner: Name of user not set #1002873
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 27 Apr 2020 13:07:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Name of user not set #1002873
Gerrit-MessageType: comment