Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35906 )
Change subject: mb/pcengines/apu2: use older AGESA with different headers ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
Patch Set 1:
Does it make sense to have support for different versions of a binaryPI in coreboot for the same hardware? Why not upgrade to a newer binaryPI?
apu2 platforms have issues with newer binaryPI versions. That's why we stayed with 1.0.0.4
I don't think having binaries + headers depend on a board is a good solution for upstream coreboot, as it creates maintainability issues. Not my call to make though.
https://review.coreboot.org/c/coreboot/+/35906/1/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/Kconfig:
https://review.coreboot.org/c/coreboot/+/35906/1/src/mainboard/pcengines/apu... PS1, Line 117: AGESA_USE_OLD_HEADER I'd be more specific about the version here.