Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer/aspire_vn7_572g: Adds support for an Acer laptop ......................................................................
Patch Set 4:
(4 comments)
Please make sure after solving issues to mark them as "Resolved".
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 11: select MAINBOARD_USES_FSP2_0
I was advised that FSP 2.0 supported Skylake. […]
You are right, sorry. I thought this would be the default for Skylake, but only if you select the Kaby Lake soc.
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 13: select MAINBOARD_HAS_LPC_TPM
According to some Google results, it should have a TPM2. So please also select `MAINBOARD_HAS_TPM2`.
Done
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 22: default "Acer"
Not necessary, since this is set by the upper Kconfig file "src/mainboard/acer/Kconfig".
Done
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 36: config DEVICETREE : string : default "devicetree.cb"
Not necessary, since this is already the default.
Done