Please make sure after solving issues to mark them as "Resolved".
4 comments:
File src/mainboard/acer/aspire_vn7_572g/Kconfig:
Patch Set #2, Line 11: select MAINBOARD_USES_FSP2_0
I was advised that FSP 2.0 supported Skylake. […]
You are right, sorry. I thought this would be the default for Skylake, but only if you select the Kaby Lake soc.
Patch Set #2, Line 13: select MAINBOARD_HAS_LPC_TPM
According to some Google results, it should have a TPM2. So please also select `MAINBOARD_HAS_TPM2`.
Done
Patch Set #2, Line 22: default "Acer"
Not necessary, since this is set by the upper Kconfig file "src/mainboard/acer/Kconfig".
Done
config DEVICETREE
string
default "devicetree.cb"
Not necessary, since this is already the default.
Done
To view, visit change 35523. To unsubscribe, or for help writing mail filters, visit settings.