Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44102 )
Change subject: [WIP]mb/intel/minnowmax: Add mainboard ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/Kconfig:
PS1:
SPDX
Done
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... PS1, Line 49:
double blank line
Done
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/cmos.layout:
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... PS1, Line 1:
drop leading newline (actually, put it after SPDX)
Done
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/devicetree.cb:
PS1:
SPDX
Done
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... PS1, Line 22: }
missing newline?
Done
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/gpio.c:
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... PS1, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2013 Google Inc. : * Copyright (C) 2014 Sage Electronic Engineering, LLC. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
SPDX
Done
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... PS1, Line 21: GPIO_OUT_HIGH_LEGACY
unused
not true, but it should probably move to a different location.
https://review.coreboot.org/c/coreboot/+/44102/1/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/mainboard.c:
PS1:
Missing some newlines between things
Done
https://review.coreboot.org/c/coreboot/+/44102/1/src/soc/intel/baytrail/refc... File src/soc/intel/baytrail/refcode.c:
https://review.coreboot.org/c/coreboot/+/44102/1/src/soc/intel/baytrail/refc... PS1, Line 22: static struct prog refcode;
hrm?
The compiler complained about refcode being possibly uninitialized in the return statement. Seems to work now without this. Weird