9 comments:
File src/mainboard/intel/minnowmax/Kconfig:
SPDX
Done
double blank line
Done
File src/mainboard/intel/minnowmax/cmos.layout:
drop leading newline (actually, put it after SPDX)
Done
File src/mainboard/intel/minnowmax/devicetree.cb:
SPDX
Done
File src/mainboard/intel/minnowmax/dsdt.asl:
missing newline?
Done
File src/mainboard/intel/minnowmax/gpio.c:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2013 Google Inc.
* Copyright (C) 2014 Sage Electronic Engineering, LLC.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
SPDX
Done
Patch Set #1, Line 21: GPIO_OUT_HIGH_LEGACY
unused
not true, but it should probably move to a different location.
File src/mainboard/intel/minnowmax/mainboard.c:
Missing some newlines between things
Done
File src/soc/intel/baytrail/refcode.c:
Patch Set #1, Line 22: static struct prog refcode;
hrm?
The compiler complained about refcode being possibly uninitialized in the return statement. Seems to work now without this. Weird
To view, visit change 44102. To unsubscribe, or for help writing mail filters, visit settings.