Attention is currently required from: Nico Huber, Eugene Myers, Benjamin Doron, Paul Menzel, Angel Pons, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 192:
(13 comments)
File src/mainboard/acer/aspire_vn7_572g/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/065c9900_6edfc2bd PS192, Line 22: select NO_UART_ON_SUPERIO 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/dd422472_1f98bf77 PS192, Line 45: if (data_buffer <= (2017 / ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/6515333e_70b26324 PS192, Line 303: | LPC_IOE_EC_62_66 | LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F" # 82h-83h 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/8baf878a_cba1db2a PS192, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/84a3bf81_362970d1 PS192, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/77b007e6_1a1e994a PS192, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/52db2a65_414eedcd PS192, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/dfd3e911_f65c4e3b PS192, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/4b39eedd_07929238 PS192, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/dc444e44_9a479094 PS192, Line 98: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/2afcc2b5_65764ca5 PS192, Line 122: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/e8acafe3_b3219553 PS192, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135132): https://review.coreboot.org/c/coreboot/+/35523/comment/9c1fa956_bb428b2d PS192, Line 159: if (gnvs) { braces {} are not necessary for single statement blocks