Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Subrata Banik, Tarun.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81332?usp=email )
Change subject: soc/intel/meteorlake: Update Touch Controller UDP params
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81332/comment/6194c7bf_f8bf7689 :
PS2, Line 9: The UPD, ThcAssignment, and ThcMode, ThcWakeOnTouch, are
The UPDs ThcAssignment, ThcMode, and ThcWakeOnTouch are …
Done
https://review.coreboot.org/c/coreboot/+/81332/comment/bf239ea2_3cb96af9 :
PS2, Line 11: a weak function drivers_intel_touch_config() is added
Why weak?
The _weak function indicates that the boards that build with this support will need to provide the same function with implementation from the board directory.
https://review.coreboot.org/c/coreboot/+/81332/comment/d170a0cf_e01e409c :
PS2, Line 11: a
A
Done
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/81332/comment/cd0a3912_3c793f89 :
PS2, Line 639: s_cfg->ThcAssignment[0] = THC_NONE;
use if(!IS_ENABLED(SOC_INTEL_TOUCH)) return?
fill_fsps_thc_params function is inserted only when SOC_INTEL_TOUCH is enabled. In fact, #if-#endif is used in several place rather than using conditional statement with build flag, where results in always true or false is placed in the condition.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81332?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I19edbcad705e889166d7d340b2caa74ab3bf15a1
Gerrit-Change-Number: 81332
Gerrit-PatchSet: 3
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jingyuan Liang
jingyliang@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Henry Barnor
hbarnor@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Jingyuan Liang
jingyliang@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 26 Apr 2024 06:44:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment