Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Subrata Banik, Tarun.
4 comments:
Commit Message:
Patch Set #2, Line 9: The UPD, ThcAssignment, and ThcMode, ThcWakeOnTouch, are
The UPDs ThcAssignment, ThcMode, and ThcWakeOnTouch are …
Done
Patch Set #2, Line 11: a weak function drivers_intel_touch_config() is added
Why weak?
The _weak function indicates that the boards that build with this support will need to provide the same function with implementation from the board directory.
A
Done
File src/soc/intel/meteorlake/fsp_params.c:
Patch Set #2, Line 639: s_cfg->ThcAssignment[0] = THC_NONE;
use if(!IS_ENABLED(SOC_INTEL_TOUCH)) return?
fill_fsps_thc_params function is inserted only when SOC_INTEL_TOUCH is enabled. In fact, #if-#endif is used in several place rather than using conditional statement with build flag, where results in always true or false is placed in the condition.
To view, visit change 81332. To unsubscribe, or for help writing mail filters, visit settings.