Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer/aspire_vn7_572g: Adds support for an Acer laptop ......................................................................
Patch Set 3:
(1 comment)
Thanks. I've fixed the others, but it appears that FSP 2.0 must be defined if it is being used.
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 11: select MAINBOARD_USES_FSP2_0
Not necessary, since it is selected by the SOC.
I was advised that FSP 2.0 supported Skylake. While I haven't personally tested this (I've been unable to flash any new images for a little while, but I'm working on it), without this line it defaults to using FSP 1.1.