[coreboot-gerrit] Change in coreboot[master]: intel/e7505,i82801dx: Remove wrapper spd_read_byte()

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38235 )

Change subject: intel/e7505,i82801dx: Remove wrapper spd_read_byte()
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38235/4/src/northbridge/intel/e7505... 
File src/northbridge/intel/e7505/raminit.c:

https://review.coreboot.org/c/coreboot/+/38235/4/src/northbridge/intel/e7505... 
PS4, Line 1251: 		value =
This could be reflowed, I guess.

https://review.coreboot.org/c/coreboot/+/38235/4/src/northbridge/intel/e7505... 
PS4, Line 1286: 		    smbus_read_byte(dimm_socket_address,
> Are you aware that this ifdef section is compiled out?

Even then, not replacing the function call would be worse (the code would rot)