Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 26:
(5 comments)
I reverted the mainboard.c because ops->read_resources() is never called. I think the reason why read_resources isn't called is devicetree.cb is not enough but ARM systems don't rely on devicetree.cb, right?
I can understand ram_resource() should be called in device operations but I didn't know how to deal with it.
https://review.coreboot.org/c/coreboot/+/33387/22/Documentation/mainboard/em... File Documentation/mainboard/emulation/qemu-aarch64.md:
https://review.coreboot.org/c/coreboot/+/33387/22/Documentation/mainboard/em... PS22, Line 2: This page discribes how to build and run coreboot for QEMU/AArch64. You can use LinuxBoot via `make menuconfig` or an arbitrary FIT image as a payload for QEMU/AArch64.
please limit to 72char per line. Applies to all lines.
Done
https://review.coreboot.org/c/coreboot/+/33387/22/Documentation/mainboard/em... PS22, Line 16: 2. Build a FIT image with a DTB
whitespace
Done
https://review.coreboot.org/c/coreboot/+/33387/22/Documentation/mainboard/em... PS22, Line 27: See [Flattened uImage Tree documentation](https://doc.coreboot.org/lib/payloads/fit.html) for more details.
../.. […]
Done
https://review.coreboot.org/c/coreboot/+/33387/22/Documentation/mainboard/em... PS22, Line 29: ### 3. Add a FIT image to coreboot.rom
whitespace
Done
https://review.coreboot.org/c/coreboot/+/33387/22/src/lib/fit_payload.c File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/33387/22/src/lib/fit_payload.c@249 PS22, Line 249: if (config->ramdisk && initrd.size > 0) {
that's unrelated. Please do it in a seperate commit.
OK. I reverted this change in the CL and created new CL (https://review.coreboot.org/c/coreboot/+/34535). Could you review this CL?