Łukasz Siudut has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32905 )
Change subject: RFC: smbios: allow setting BIOS-version string from VPD variable ......................................................................
Patch Set 3:
(3 comments)
I'll push updates in a moment.
https://review.coreboot.org/#/c/32905/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32905/3//COMMIT_MSG@7 PS3, Line 7: BIOS-version
No hyphon: BIOS version
Ack
https://review.coreboot.org/#/c/32905/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32905/3/src/arch/x86/smbios.c@353 PS3, Line 353: #if CONFIG(VPD)
Can this be done in C and not the preprocessor?
If VPD support is not there then linking will fail later, as we reference vpd_find function.
https://review.coreboot.org/#/c/32905/3/src/arch/x86/smbios.c@354 PS3, Line 354: /* size is unused for now */
What does this comment mean?
I should have elaborate on that more - vpd_find writes size of the variable (second argument), but it is not necessary for us as (there's no real limitation for string size in smbios). Therefore it's not used.