I'll push updates in a moment.

View Change

3 comments:

• Commit Message:

  • Patch Set #3, Line 7: BIOS-version

    No hyphon: BIOS version

    Ack

• File src/arch/x86/smbios.c:

  • Patch Set #3, Line 353: #if CONFIG(VPD)

    Can this be done in C and not the preprocessor?

    If VPD support is not there then linking will fail later, as we reference vpd_find function.

  • Patch Set #3, Line 354: /* size is unused for now */

    What does this comment mean?

    I should have elaborate on that more - vpd_find writes size of the variable (second argument), but it is not necessary for us as (there's no real limitation for string size in smbios). Therefore it's not used.

To view, visit change 32905. To unsubscribe, or for help writing mail filters, visit settings.