[coreboot-gerrit] Change in coreboot[master]: pcengines/apu2: implement POSTCAR_STAGE

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32363 )

Change subject: pcengines/apu2: implement POSTCAR_STAGE
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32363/4/src/mainboard/pcengines/apu... 
File src/mainboard/pcengines/apu2/postcar.c:

https://review.coreboot.org/c/coreboot/+/32363/4/src/mainboard/pcengines/apu... 
PS4, Line 22: outb(0xEA, 0xCD6);
            : 	outb(0x1, 0xcd7);
> Please use consistent lower or upper case spelling. […]

We generally use lower case, right. In files that come in all-uppercase, it's advisable to remain consistent (or do a separate cleanup commit that moves everything to lower case).

But please avoid mixing them in a file (although this isn't the worst I've seen: it's not 0xCd6 :-) )