1 comment:
File src/mainboard/pcengines/apu2/postcar.c:
outb(0xEA, 0xCD6);
outb(0x1, 0xcd7);
Please use consistent lower or upper case spelling. […]
We generally use lower case, right. In files that come in all-uppercase, it's advisable to remain consistent (or do a separate cleanup commit that moves everything to lower case).
But please avoid mixing them in a file (although this isn't the worst I've seen: it's not 0xCd6 :-) )
To view, visit change 32363. To unsubscribe, or for help writing mail filters, visit settings.