build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35802 )
Change subject: soc/intel/cannonlake: Add debugging of a number of FSPM parameters ......................................................................
Patch Set 1:
(198 comments)
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 273: fsp_display_upd_value("MrcTimeMeasure", 1, old->MrcTimeMeasure, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 274: new->MrcTimeMeasure); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 274: new->MrcTimeMeasure); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 302: old->PlatformDebugConsent, new->PlatformDebugConsent); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 302: old->PlatformDebugConsent, new->PlatformDebugConsent); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 308: old->PchTraceHubMemReg0Size, new->PchTraceHubMemReg0Size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 308: old->PchTraceHubMemReg0Size, new->PchTraceHubMemReg0Size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 310: old->PchTraceHubMemReg1Size, new->PchTraceHubMemReg1Size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 310: old->PchTraceHubMemReg1Size, new->PchTraceHubMemReg1Size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 323: fsp_display_upd_value("DdrFreqLimit", 2, old->DdrFreqLimit, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 324: new->DdrFreqLimit); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 324: new->DdrFreqLimit); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 325: fsp_display_upd_value("FreqSaGvLow", 2, old->FreqSaGvLow, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 326: new->FreqSaGvLow); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 326: new->FreqSaGvLow); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 327: #if ! CONFIG(SOC_INTEL_COMETLAKE) space prohibited after that '!' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 329: fsp_display_upd_value("FreqSaGvMid", 2, old->FreqSaGvMid, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 330: new->FreqSaGvMid); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 330: new->FreqSaGvMid); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 332: fsp_display_upd_value("RMT", 1, old->RMT, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 333: new->RMT); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 333: new->RMT); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 334: fsp_display_upd_value("DisableDimmChannel0", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 335: old->DisableDimmChannel0, new->DisableDimmChannel0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 335: old->DisableDimmChannel0, new->DisableDimmChannel0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 336: fsp_display_upd_value("DisableDimmChannel1", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 337: old->DisableDimmChannel1, new->DisableDimmChannel1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 337: old->DisableDimmChannel1, new->DisableDimmChannel1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 338: fsp_display_upd_value("ScramblerSupport", 1, old->ScramblerSupport, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 339: new->ScramblerSupport); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 339: new->ScramblerSupport); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 340: fsp_display_upd_value("SkipMpInit", 1, old->SkipMpInit, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 341: new->SkipMpInit); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 341: new->SkipMpInit); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 343: fsp_display_upd_value("SpdProfileSelected", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 344: old->SpdProfileSelected, new->SpdProfileSelected); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 344: old->SpdProfileSelected, new->SpdProfileSelected); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 345: fsp_display_upd_value("RefClk", 1, old->RefClk, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 346: new->RefClk); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 346: new->RefClk); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 347: fsp_display_upd_value("VddVoltage", 2, old->VddVoltage, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 348: new->VddVoltage); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 348: new->VddVoltage); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 349: fsp_display_upd_value("Ratio", 1, old->Ratio, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 350: new->Ratio); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 350: new->Ratio); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 351: fsp_display_upd_value("OddRatioMode", 1, old->OddRatioMode, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 352: new->OddRatioMode); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 352: new->OddRatioMode); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 353: fsp_display_upd_value("tCL", 1, old->tCL, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 354: new->tCL); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 354: new->tCL); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 355: fsp_display_upd_value("tCWL", 1, old->tCWL, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 356: new->tCWL); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 356: new->tCWL); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 357: fsp_display_upd_value("tRCDtRP", 1, old->tRCDtRP, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 358: new->tRCDtRP); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 358: new->tRCDtRP); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 359: fsp_display_upd_value("tRRD", 1, old->tRRD, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 360: new->tRRD); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 360: new->tRRD); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 361: fsp_display_upd_value("tFAW", 2, old->tFAW, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 362: new->tFAW); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 362: new->tFAW); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 363: fsp_display_upd_value("tRAS", 2, old->tRAS, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 364: new->tRAS); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 364: new->tRAS); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 365: fsp_display_upd_value("tREFI", 2, old->tREFI, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 366: new->tREFI); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 366: new->tREFI); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 367: fsp_display_upd_value("tRFC", 2, old->tRFC, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 368: new->tRFC); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 368: new->tRFC); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 369: fsp_display_upd_value("tRTP", 1, old->tRTP, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 370: new->tRTP); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 370: new->tRTP); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 371: fsp_display_upd_value("tWR", 1, old->tWR, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 372: new->tWR); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 372: new->tWR); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 373: fsp_display_upd_value("NModeSupport", 1, old->NModeSupport, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 374: new->NModeSupport); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 374: new->NModeSupport); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 375: fsp_display_upd_value("DllBwEn0", 1, old->DllBwEn0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 376: new->DllBwEn0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 376: new->DllBwEn0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 377: fsp_display_upd_value("DllBwEn1", 1, old->DllBwEn1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 378: new->DllBwEn1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 378: new->DllBwEn1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 379: fsp_display_upd_value("DllBwEn2", 1, old->DllBwEn2, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 380: new->DllBwEn2); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 380: new->DllBwEn2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 381: fsp_display_upd_value("DllBwEn3", 1, old->DllBwEn3, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 382: new->DllBwEn3); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 382: new->DllBwEn3); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 383: fsp_display_upd_value("IsvtIoPort", 1, old->IsvtIoPort, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 384: new->IsvtIoPort); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 384: new->IsvtIoPort); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 385: fsp_display_upd_value("CpuTraceHubMode", 1, old->CpuTraceHubMode, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 386: new->CpuTraceHubMode); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 386: new->CpuTraceHubMode); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 387: fsp_display_upd_value("CpuTraceHubMemReg0Size", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 388: old->CpuTraceHubMemReg0Size, new->CpuTraceHubMemReg0Size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 388: old->CpuTraceHubMemReg0Size, new->CpuTraceHubMemReg0Size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 389: fsp_display_upd_value("CpuTraceHubMemReg1Size", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 390: old->CpuTraceHubMemReg1Size, new->CpuTraceHubMemReg1Size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 390: old->CpuTraceHubMemReg1Size, new->CpuTraceHubMemReg1Size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 391: fsp_display_upd_value("PeciC10Reset", 1, old->PeciC10Reset, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 392: new->PeciC10Reset); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 392: new->PeciC10Reset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 393: fsp_display_upd_value("PeciSxReset", 1, old->PeciSxReset, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 394: new->PeciSxReset); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 394: new->PeciSxReset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 396: fsp_display_upd_value("PchHdaEnable", 1, old->PchHdaEnable, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 397: new->PchHdaEnable); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 397: new->PchHdaEnable); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 398: fsp_display_upd_value("PchIshEnable", 1, old->PchIshEnable, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 399: new->PchIshEnable); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 399: new->PchIshEnable); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 400: fsp_display_upd_value("HeciTimeouts", 1, old->HeciTimeouts, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 401: new->HeciTimeouts); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 401: new->HeciTimeouts); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 403: fsp_display_upd_value("Heci1BarAddress", 4, old->Heci1BarAddress, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 404: new->Heci1BarAddress); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 404: new->Heci1BarAddress); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 405: fsp_display_upd_value("Heci2BarAddress", 4, old->Heci2BarAddress, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 406: new->Heci2BarAddress); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 406: new->Heci2BarAddress); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 407: fsp_display_upd_value("Heci3BarAddress", 4, old->Heci3BarAddress, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 408: new->Heci3BarAddress); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 408: new->Heci3BarAddress); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 409: fsp_display_upd_value("SgDelayAfterPwrEn", 2, old->SgDelayAfterPwrEn, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 410: new->SgDelayAfterPwrEn); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 410: new->SgDelayAfterPwrEn); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 411: fsp_display_upd_value("SgDelayAfterHoldReset", 2, old->SgDelayAfterHoldReset, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 412: new->SgDelayAfterHoldReset); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 412: new->SgDelayAfterHoldReset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 413: fsp_display_upd_value("MmioSizeAdjustment", 2, old->MmioSizeAdjustment, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 414: new->MmioSizeAdjustment); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 414: new->MmioSizeAdjustment); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 415: fsp_display_upd_value("DmiGen3ProgramStaticEq", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 416: old->DmiGen3ProgramStaticEq, new->DmiGen3ProgramStaticEq); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 416: old->DmiGen3ProgramStaticEq, new->DmiGen3ProgramStaticEq); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 417: fsp_display_upd_value("Peg0Enable", 1, old->Peg0Enable, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 418: new->Peg0Enable); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 418: new->Peg0Enable); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 419: fsp_display_upd_value("Peg1Enable", 1, old->Peg1Enable, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 420: new->Peg1Enable); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 420: new->Peg1Enable); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 421: fsp_display_upd_value("Peg2Enable", 1, old->Peg2Enable, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 422: new->Peg2Enable); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 422: new->Peg2Enable); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 423: fsp_display_upd_value("Peg3Enable", 1, old->Peg3Enable, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 424: new->Peg3Enable); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 424: new->Peg3Enable); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 425: fsp_display_upd_value("Peg0MaxLinkSpeed", 1, old->Peg0MaxLinkSpeed, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 426: new->Peg0MaxLinkSpeed); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 426: new->Peg0MaxLinkSpeed); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 427: fsp_display_upd_value("Peg1MaxLinkSpeed", 1, old->Peg1MaxLinkSpeed, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 428: new->Peg1MaxLinkSpeed); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 428: new->Peg1MaxLinkSpeed); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 429: fsp_display_upd_value("Peg2MaxLinkSpeed", 1, old->Peg2MaxLinkSpeed, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 430: new->Peg2MaxLinkSpeed); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 430: new->Peg2MaxLinkSpeed); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 431: fsp_display_upd_value("Peg3MaxLinkSpeed", 1, old->Peg3MaxLinkSpeed, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 432: new->Peg3MaxLinkSpeed); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 432: new->Peg3MaxLinkSpeed); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 433: fsp_display_upd_value("Peg0MaxLinkWidth", 1, old->Peg0MaxLinkWidth, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 434: new->Peg0MaxLinkWidth); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 434: new->Peg0MaxLinkWidth); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 435: fsp_display_upd_value("Peg1MaxLinkWidth", 1, old->Peg1MaxLinkWidth, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 436: new->Peg1MaxLinkWidth); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 436: new->Peg1MaxLinkWidth); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 437: fsp_display_upd_value("Peg2MaxLinkWidth", 1, old->Peg2MaxLinkWidth, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 438: new->Peg2MaxLinkWidth); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 438: new->Peg2MaxLinkWidth); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 439: fsp_display_upd_value("Peg3MaxLinkWidth", 1, old->Peg3MaxLinkWidth, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 440: new->Peg3MaxLinkWidth); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 440: new->Peg3MaxLinkWidth); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 441: fsp_display_upd_value("Peg0PowerDownUnusedLanes", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 442: old->Peg0PowerDownUnusedLanes, new->Peg0PowerDownUnusedLanes); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 442: old->Peg0PowerDownUnusedLanes, new->Peg0PowerDownUnusedLanes); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 443: fsp_display_upd_value("Peg1PowerDownUnusedLanes", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 444: old->Peg1PowerDownUnusedLanes, new->Peg1PowerDownUnusedLanes); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 444: old->Peg1PowerDownUnusedLanes, new->Peg1PowerDownUnusedLanes); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 445: fsp_display_upd_value("Peg2PowerDownUnusedLanes", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 446: old->Peg2PowerDownUnusedLanes, new->Peg2PowerDownUnusedLanes); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 446: old->Peg2PowerDownUnusedLanes, new->Peg2PowerDownUnusedLanes); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 447: fsp_display_upd_value("Peg3PowerDownUnusedLanes", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 448: old->Peg3PowerDownUnusedLanes, new->Peg3PowerDownUnusedLanes); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 448: old->Peg3PowerDownUnusedLanes, new->Peg3PowerDownUnusedLanes); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 449: fsp_display_upd_value("InitPcieAspmAfterOprom", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 450: old->InitPcieAspmAfterOprom, new->InitPcieAspmAfterOprom); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 450: old->InitPcieAspmAfterOprom, new->InitPcieAspmAfterOprom); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 451: fsp_display_upd_value("PegDisableSpreadSpectrumClocking", 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 452: old->PegDisableSpreadSpectrumClocking, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 452: old->PegDisableSpreadSpectrumClocking, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 453: new->PegDisableSpreadSpectrumClocking); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35802/1/src/soc/intel/cannonlake/ro... PS1, Line 453: new->PegDisableSpreadSpectrumClocking); please, no spaces at the start of a line