Attention is currently required from: Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86616?usp=email )
Change subject: [wip]coreboot-sdk: Use same gcc & gnat version as the version in toolchain
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
it should fail, isn't it?
(on github it failed to build)
--
To view, visit https://review.coreboot.org/c/coreboot/+/86616?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3d75f7cf06ed1421cb27e185d9ebf4887626f41a
Gerrit-Change-Number: 86616
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sat, 01 Mar 2025 10:24:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86616?usp=email
to look at the new patch set (#3).
Change subject: [wip]coreboot-sdk: Use same gcc & gnat version as the version in toolchain
......................................................................
[wip]coreboot-sdk: Use same gcc & gnat version as the version in toolchain
Change-Id: I3d75f7cf06ed1421cb27e185d9ebf4887626f41a
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/docker/coreboot-sdk/Dockerfile
1 file changed, 27 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/86616/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/86616?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3d75f7cf06ed1421cb27e185d9ebf4887626f41a
Gerrit-Change-Number: 86616
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86677?usp=email )
Change subject: 3rdparty/fsp: Update submodule to upstream master
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
submodules are not in sync
--
To view, visit https://review.coreboot.org/c/coreboot/+/86677?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icfab1e8d0d98fd373a087b25c430510c2bbc819a
Gerrit-Change-Number: 86677
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sat, 01 Mar 2025 09:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Held, Paul Menzel.
Brandon Weeks has posted comments on this change by Brandon Weeks. ( https://review.coreboot.org/c/coreboot/+/86260?usp=email )
Change subject: mb/cwwk/adl: Fix HDMI, PCIe CLKREQ, EC, TPM
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86260/comment/37ac84a6_65e415d3?us… :
PS2, Line 7: Various device tree fixes
> Please make it a statement.
Done
https://review.coreboot.org/c/coreboot/+/86260/comment/91fb5d56_e16c787c?us… :
PS2, Line 9: - Set pmc_gpe0_dw{0-3} to resolve a warning
> Please paste the warning.
Done
https://review.coreboot.org/c/coreboot/+/86260/comment/b20903c6_49004d65?us… :
PS2, Line 10: vendor firmware
> Please add the version.
I don't think the vendor firmware has meaningful versions. It has never been updated after shipping, I'm working off the firmware dumped from flash.
https://review.coreboot.org/c/coreboot/+/86260/comment/b6381f99_e72a259d?us… :
PS2, Line 9: - Set pmc_gpe0_dw{0-3} to resolve a warning
: - Set CLKREQ# based on register value from vendor firmware
: - Enable ITE environment controller
> Listing changes is always an indicator to make a separate commit per item. […]
Happy to break it up if the reviewer would prefer, however I suspect that would be a lot of churn given how much was broken on the board.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86260?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9365e76c593b7e4a334dcdc5ecd46da253e14716
Gerrit-Change-Number: 86260
Gerrit-PatchSet: 4
Gerrit-Owner: Brandon Weeks <bweeks(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 01 Mar 2025 07:34:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Brandon Weeks, Felix Held.
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86260?usp=email
to look at the new patch set (#4).
Change subject: mb/cwwk/adl: Fix HDMI, PCIe CLKREQ, EC, TPM
......................................................................
mb/cwwk/adl: Fix HDMI, PCIe CLKREQ, EC, TPM
- Update VBT to fix HDMI
- Enable ITE environment controller
- Enable PTT fTPM
- Disable s0ix, it never worked and will crash if used
- Set CLKREQ# based on register values from vendor firmware
- Set pmc_gpe0_dw{0-3} to fix "Duplicate GPE DW register values"
Change-Id: I9365e76c593b7e4a334dcdc5ecd46da253e14716
Signed-off-by: Brandon Weeks <bweeks(a)google.com>
---
M src/mainboard/cwwk/adl/Kconfig
M src/mainboard/cwwk/adl/data.vbt
M src/mainboard/cwwk/adl/devicetree.cb
3 files changed, 42 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/86260/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/86260?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9365e76c593b7e4a334dcdc5ecd46da253e14716
Gerrit-Change-Number: 86260
Gerrit-PatchSet: 4
Gerrit-Owner: Brandon Weeks <bweeks(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Brandon Weeks <bweeks(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Brandon Weeks, Felix Held.
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86260?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/cwwk/adl: Fix HDMI, PCIe CLKREQ, EC, TPM
......................................................................
mb/cwwk/adl: Fix HDMI, PCIe CLKREQ, EC, TPM
- Update VBT to fix HDMI
- Enable ITE environment controller
- Enable PTT fTPM
- Disable s0ix, it never worked and will crash if used
- Set CLKREQ# based on register value from vendor firmware
- Set pmc_gpe0_dw{0-3} to fix "Duplicate GPE DW register values detected"
Change-Id: I9365e76c593b7e4a334dcdc5ecd46da253e14716
Signed-off-by: Brandon Weeks <bweeks(a)google.com>
---
M src/mainboard/cwwk/adl/Kconfig
M src/mainboard/cwwk/adl/data.vbt
M src/mainboard/cwwk/adl/devicetree.cb
3 files changed, 42 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/86260/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/86260?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9365e76c593b7e4a334dcdc5ecd46da253e14716
Gerrit-Change-Number: 86260
Gerrit-PatchSet: 3
Gerrit-Owner: Brandon Weeks <bweeks(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Brandon Weeks <bweeks(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>