coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[S] Change in coreboot[main]: amdfwtool: Move ISH before PSP L2
by Maximilian Brune (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Bao Zheng, Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, ritul guru. Maximilian Brune has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84533?usp=email ) Change subject: amdfwtool: Move ISH before PSP L2 ...................................................................... Patch Set 12: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/84533/comment/26add1c1_f04cdad7?us… : PS12, Line 972: if (!cb_config->combo_new_rab || ctx->combo_index == 0) { : pspdir = new_psp_dir(ctx, cb_config->multi_level, cookie); : ctx->pspdir = pspdir; : if (recovery_ab) : ctx->pspdir_bak = new_psp_dir(ctx, cb_config->multi_level, cookie); : } : /* The ISH tables are with PSP L1. */ : if (cb_config->need_ish && ctx->ish_a_dir == NULL) /* Need ISH */ : ctx->ish_a_dir = new_ish_dir(ctx); : if (cb_config->need_ish && ctx->ish_b_dir == NULL) /* Need ISH */ : ctx->ish_b_dir = new_ish_dir(ctx); What happens if `combo_new_rab = 0` and `recovery_ab = 1` ? In that case no PSP L1 directory is created? That raises a bigger question for me: What is the difference between `combo_new_rab` and `recovery_ab`? Can you point me to a place in the spec that talks about it? -- To view, visit https://review.coreboot.org/c/coreboot/+/84533?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id69268619893d78d9b5330052a4fd5b501263f75 Gerrit-Change-Number: 84533 Gerrit-PatchSet: 12 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 11 Feb 2025 15:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Add platform callback for critical shutdown
by Subrata Banik (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Ronak Kanabar. Hello Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Ronak Kanabar, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86226?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/intel/fsp2_0: Add platform callback for critical shutdown ...................................................................... drivers/intel/fsp2_0: Add platform callback for critical shutdown This commit adds the `platform_is_low_battery_shutdown_needed` callback to the FSP API. This allows platforms to integrate low-battery handling logic directly into the FSP silicon initialization process. By checking for critical conditions (e.g., low battery) within this callback after FSP silicon initialization, the platform can initiate a controlled shutdown before proceeding with further boot stages, preventing abrupt shutdowns later in the boot process. BUG=b:339673254 TEST=Able to build and boot google/brox. Change-Id: I2d6677d70dea3d24f5a19d70608fd21229a271a0 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/fsp2_0/silicon_init.c M src/lib/bmp_logo.c 3 files changed, 25 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/86226/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/86226?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d6677d70dea3d24f5a19d70608fd21229a271a0 Gerrit-Change-Number: 86226 Gerrit-PatchSet: 10 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Add low battery indicator screen
by Subrata Banik (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Ronak Kanabar. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email ) Change subject: drivers/intel/fsp2_0: Add low battery indicator screen ...................................................................... Patch Set 11: (1 comment) File src/vendorcode/google/chromeos/Makefile.mk: https://review.coreboot.org/c/coreboot/+/86225/comment/591847b3_2fef5657?us… : PS8, Line 45: low_battery.bmp,CONFIG_PLATFORM_LOW_BATTERY_INDICATOR_LOGO_PATH)) > Oh, okay, so we have it there. I didn't see that. It is kinda weird though that the code that uses it is in `src/lib`, but the code adding that logo is in `src/drivers/intel/fsp2_0` (so if you used the splash screen on a non-Intel board you wouldn't actually get the logo in your CBFS). That is true because we are eventually using FSP to render the bitmap. Also BMP_LOGO Kconfig added inside FSP driver. > > Not really related to this patch but it would probably make sense to move that part into `src/lib/Makefile.mk` at some point. Done. -- To view, visit https://review.coreboot.org/c/coreboot/+/86225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711c53455639b449fe85903139bbc06cdab08d09 Gerrit-Change-Number: 86225 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 15:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: lib: Refactor logo.bmp inclusion with helper macro
by Subrata Banik (Code Review) 11 Feb '25

11 Feb '25

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86368?usp=email ) Change subject: lib: Refactor logo.bmp inclusion with helper macro ...................................................................... lib: Refactor logo.bmp inclusion with helper macro This commit refactors the logo.bmp inclusion logic to use a helper macro, `add_bmp_logo_file_to_cbfs`. This centralizes the logic for adding BMP logo files to the CBFS image and improves code readability. Change-Id: I135c1f2af02064b72bc1f747336ac98ffdb20842 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/lib/Makefile.mk 1 file changed, 14 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/86368/1 diff --git a/src/lib/Makefile.mk b/src/lib/Makefile.mk index 292f5d2..93e76d4 100644 --- a/src/lib/Makefile.mk +++ b/src/lib/Makefile.mk @@ -422,13 +422,21 @@ romstage-y += ux_locales.c # Add logo to the cbfs image -ifneq ($(CONFIG_HAVE_CUSTOM_BMP_LOGO),y) -cbfs-files-$(CONFIG_BMP_LOGO) += logo.bmp -logo.bmp-file := $(call strip_quotes,$(CONFIG_FSP2_0_LOGO_FILE_NAME)) -logo.bmp-type := raw +BMP_LOGO_COMPRESS_FLAG := $(CBFS_COMPRESS_FLAG) ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y) -logo.bmp-compression := LZMA + BMP_LOGO_COMPRESS_FLAG := LZMA else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) -logo.bmp-compression := LZ4 + BMP_LOGO_COMPRESS_FLAG := LZ4 endif + +define add_bmp_logo_file_to_cbfs +cbfs-files-$$($(1)) += $(2) +$(2)-file := $$(call strip_quotes,$$($(3))) +$(2)-type := raw +$(2)-compression := $$(BMP_LOGO_COMPRESS_FLAG) +endef + +ifneq ($(CONFIG_HAVE_CUSTOM_BMP_LOGO),y) +$(eval $(call add_bmp_logo_file_to_cbfs,CONFIG_BMP_LOGO, logo.bmp,\ + CONFIG_FSP2_0_LOGO_FILE_NAME)) endif -- To view, visit https://review.coreboot.org/c/coreboot/+/86368?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I135c1f2af02064b72bc1f747336ac98ffdb20842 Gerrit-Change-Number: 86368 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: lib: Centralize logo.bmp inclusion in lib/Makefile.mk
by Subrata Banik (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Ronak Kanabar. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86367?usp=email ) Change subject: lib: Centralize logo.bmp inclusion in lib/Makefile.mk ...................................................................... lib: Centralize logo.bmp inclusion in lib/Makefile.mk This commit moves the logo.bmp inclusion logic from `src/drivers/intel/fsp2_0/Makefile.mk` to `src/lib/Makefile.mk`. This change centralizes the logo inclusion logic within the `lib` directory, aligning it with the location of `bmp_logo.c` and making it independent of the FSP 2.0 driver. Change-Id: I16ed1cf29b839c25b6ea1c2f10faf3d99dd707c9 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/drivers/intel/fsp2_0/Makefile.mk M src/lib/Makefile.mk 2 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/86367/1 diff --git a/src/drivers/intel/fsp2_0/Makefile.mk b/src/drivers/intel/fsp2_0/Makefile.mk index 4cb24ff..18a62e3 100644 --- a/src/drivers/intel/fsp2_0/Makefile.mk +++ b/src/drivers/intel/fsp2_0/Makefile.mk @@ -126,18 +126,6 @@ true endif -# Add logo to the cbfs image -ifneq ($(CONFIG_HAVE_CUSTOM_BMP_LOGO),y) -cbfs-files-$(CONFIG_BMP_LOGO) += logo.bmp -logo.bmp-file := $(call strip_quotes,$(CONFIG_FSP2_0_LOGO_FILE_NAME)) -logo.bmp-type := raw -ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y) -logo.bmp-compression := LZMA -else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) -logo.bmp-compression := LZ4 -endif -endif - ifneq ($(call strip_quotes,$(CONFIG_FSP_HEADER_PATH)),) CPPFLAGS_common+=-I$(CONFIG_FSP_HEADER_PATH) endif diff --git a/src/lib/Makefile.mk b/src/lib/Makefile.mk index 40df2b8..292f5d2 100644 --- a/src/lib/Makefile.mk +++ b/src/lib/Makefile.mk @@ -420,3 +420,15 @@ header_pointer-type := "cbfs header" romstage-y += ux_locales.c + +# Add logo to the cbfs image +ifneq ($(CONFIG_HAVE_CUSTOM_BMP_LOGO),y) +cbfs-files-$(CONFIG_BMP_LOGO) += logo.bmp +logo.bmp-file := $(call strip_quotes,$(CONFIG_FSP2_0_LOGO_FILE_NAME)) +logo.bmp-type := raw +ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y) +logo.bmp-compression := LZMA +else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) +logo.bmp-compression := LZ4 +endif +endif -- To view, visit https://review.coreboot.org/c/coreboot/+/86367?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I16ed1cf29b839c25b6ea1c2f10faf3d99dd707c9 Gerrit-Change-Number: 86367 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Add low battery indicator screen
by Subrata Banik (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Ronak Kanabar, Subrata Banik. Hello Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Ronak Kanabar, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86225?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+2 by Julius Werner, Verified+1 by build bot (Jenkins) Change subject: drivers/intel/fsp2_0: Add low battery indicator screen ...................................................................... drivers/intel/fsp2_0: Add low battery indicator screen This commit adds low battery indicator bitmap into CBFS. This screen is displayed when the system detects a critically low battery condition. The screen displays a logo and can be configured with a custom path. An option to display an early low battery indicator in text mode is also included. This early indicator can defer the firmware update. This feature is controlled by the PLATFORM_HAS_LOW_BATTERY_INDICATOR Kconfig option. BUG=b:339673254 TEST=Able to see low-battery user notification in text mode before memory init. Verified low-battery boot event listed in the eventlog. Change-Id: I711c53455639b449fe85903139bbc06cdab08d09 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/drivers/intel/fsp2_0/Kconfig M src/lib/Makefile.mk 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/86225/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/86225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711c53455639b449fe85903139bbc06cdab08d09 Gerrit-Change-Number: 86225 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[XS] Change in coreboot[main]: util/docker/coreboot-sdk: Add xxd
by Yu-Ping Wu (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Martin L Roth. Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86366?usp=email ) Change subject: util/docker/coreboot-sdk: Add xxd ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I suppose this is the environment where Jenkins build coreboot boards. Martin, what's the process to update the docker image that Jenkins use? -- To view, visit https://review.coreboot.org/c/coreboot/+/86366?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icc95d25504cdccae5967ecf9276b7c1f904a14a2 Gerrit-Change-Number: 86366 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 14:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: util/docker/coreboot-sdk: Add xxd
by Yu-Ping Wu (Code Review) 11 Feb '25

11 Feb '25

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86366?usp=email ) Change subject: util/docker/coreboot-sdk: Add xxd ...................................................................... util/docker/coreboot-sdk: Add xxd The 'xxd' tool is Alderlake's hsphy_fw.bin (when HSPHY_FW_FILE is specified) and Intel's cse_rw.version (when SOC_INTEL_CSE_RW_VERSION is not specified). Change-Id: Icc95d25504cdccae5967ecf9276b7c1f904a14a2 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/86366/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 6c3a06b..861110a 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -88,6 +88,7 @@ vim-common \ wget \ xfonts-unifont \ + xxd \ xz-utils \ zlib1g-dev \ && apt-get clean -- To view, visit https://review.coreboot.org/c/coreboot/+/86366?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icc95d25504cdccae5967ecf9276b7c1f904a14a2 Gerrit-Change-Number: 86366 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: Update blobs submodule to upstream main
by Yu-Ping Wu (Code Review) 11 Feb '25

11 Feb '25

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86365?usp=email ) Change subject: Update blobs submodule to upstream main ...................................................................... Update blobs submodule to upstream main Updating from commit id 14f8fcc1b426: 2024-11-28 05:07:49 +0000 - (soc/mediatek/mt8196: Update SSPM firmware to v2.0) to commit id a0726508b86d: 2025-02-06 17:31:46 +0800 - (soc/mediatek/mt8196: Update SSPM firmware to v4.0) This brings in 10 new commits: a0726508b86d soc/mediatek/mt8196: Update SSPM firmware to v4.0 efe57af33c41 soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 ec3eb123e329 soc/mediatek/mt8196: Update SSPM firmware to v3.0 f7428ce40d6a soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 4b3be4b01f10 soc/mediatek/mt8196: Add mtk_fsp_romstage version v1.0 11da5595c96c soc/mediatek/mt8196: Add PI_IMG firmware v1.0 491c2f791901 soc/mediatek/mt8196: Update MCUPM firmware to v1.1 316468e7befd soc/mediatek/mt8196: Add GPUEB firmware v1.0 288ebf18db56 soc/mediatek/mt8196: Add SPM firmware v1.0 7130fc0c8eba soc/mediatek/mt8196: Update DRAM blob to 0.4.0 Change-Id: Ic0e99e28c9705c769042a29fbf86e44af9ba7e68 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/86365/1 diff --git a/3rdparty/blobs b/3rdparty/blobs index 14f8fcc..a072650 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 14f8fcc1b426cb0884a21a9b715da6e0c1c7f434 +Subproject commit a0726508b86dafe490ff9908274eff408298b15d -- To view, visit https://review.coreboot.org/c/coreboot/+/86365?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0e99e28c9705c769042a29fbf86e44af9ba7e68 Gerrit-Change-Number: 86365 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XL] Change in coreboot[main]: mb/teleplatforms/D4E4S16P8: Add CRB using intel/denverton_ns
by Angel Pons (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Dmitry Ponamorev, King Sumo, Kyösti Mälkki, Mariusz Szafrański, Michal Motyl, Patrick Rudolph, Suresh Bellampalli, Vanessa Eusebio. Angel Pons has posted comments on this change by Dmitry Ponamorev. ( https://review.coreboot.org/c/coreboot/+/57194?usp=email ) Change subject: mb/teleplatforms/D4E4S16P8: Add CRB using intel/denverton_ns ...................................................................... Patch Set 26: (1 comment) File src/mainboard/teleplatforms/D4E4S16P8/dsdt.asl: https://review.coreboot.org/c/coreboot/+/57194/comment/ebf25f7b_e331f0d5?us… : PS26, Line 10: // OEM revision I think this comment is copy-pasta, so I would prefer to remove it -- To view, visit https://review.coreboot.org/c/coreboot/+/57194?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If654fc7a391643b50f2e52755fd7c11a37bfd188 Gerrit-Change-Number: 57194 Gerrit-PatchSet: 26 Gerrit-Owner: Dmitry Ponamorev <dponamorev(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dmitry Ponamorev <dponamorev(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: King Sumo <kingsumos(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Dmitry Ponamorev <dponamorev(a)gmail.com> Gerrit-Attention: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Attention: King Sumo <kingsumos(a)gmail.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 14:40:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025