coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: payloads/external/Makefile.inc: Remove CONFIG_LINUXBOOT_INITRAMFS
by Maximilian Brune (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Martin L Roth, Maximilian Brune. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77775?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: payloads/external/Makefile.inc: Remove CONFIG_LINUXBOOT_INITRAMFS ...................................................................... payloads/external/Makefile.inc: Remove CONFIG_LINUXBOOT_INITRAMFS That variable doesn't exist anymore and the target has been moved to payloads/external/Linuxboot Makefiles. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I5d8396f73c2dd7f393e99a8ed5791b51c7ae3f9a --- M payloads/external/Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/77775/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/77775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d8396f73c2dd7f393e99a8ed5791b51c7ae3f9a Gerrit-Change-Number: 77775 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[L] Change in coreboot[main]: treewide: Add generation of CFR Tables
by Maximilian Brune (Code Review) 03 Jan '25

03 Jan '25

Maximilian Brune has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/82494?usp=email ) Change subject: treewide: Add generation of CFR Tables ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/82494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3408e9166139a95b7dcf4b151472a01951597133 Gerrit-Change-Number: 82494 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Lean Sheng Tan <tanleansheng(a)outlook.com>

1 0

[XL] Change in coreboot[main]: util/kconfig: Add SOT support to kconfig parser
by Maximilian Brune (Code Review) 03 Jan '25

03 Jan '25

Maximilian Brune has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83073?usp=email ) Change subject: util/kconfig: Add SOT support to kconfig parser ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/83073?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91b5b13a6bbfcdea442d5ef884cf9da11c0cd422 Gerrit-Change-Number: 83073 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-CC: Lean Sheng Tan <tanleansheng(a)outlook.com>

1 0

[S] Change in coreboot[main]: arch/riscv/pmp: Avoid race conditions in logging
by Maximilian Brune (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Angel Pons, Arthur Heymans, Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83056?usp=email ) Change subject: arch/riscv/pmp: Avoid race conditions in logging ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83056/comment/83fc7fc5_3875e3e2?us… : PS4, Line 15: This adds a printk macro in the PMP code to avoid all harts writing onto : the serial which causes crappy/broken output. We already have a `console_lock`. Check why that doesn't seem to work. -- To view, visit https://review.coreboot.org/c/coreboot/+/83056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icaded168bd7302ad1ea29bebb7900810ebeff92d Gerrit-Change-Number: 83056 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Jan 2025 12:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add clk_buf drivers
by Yidi Lin (Code Review) 03 Jan '25

03 Jan '25

1 0

[L] Change in coreboot[main]: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC
by Anand Vaikar (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Ana Carolina Cabral, Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Anand Vaikar has posted comments on this change by Anand Vaikar. ( https://review.coreboot.org/c/coreboot/+/85749?usp=email ) Change subject: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC ...................................................................... Patch Set 8: (2 comments) File src/mainboard/amd/crater/Kconfig: https://review.coreboot.org/c/coreboot/+/85749/comment/2a19fb93_7e22f785?us… : PS7, Line 49: EC_birmanplus_sig > Birmanplus file Done https://review.coreboot.org/c/coreboot/+/85749/comment/cbb2cd87_669b8b99?us… : PS7, Line 78: This is a birmanplus specific override of soc/amd/(phoenix | glinda)/Kconfig > Birmanplus file Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdb276fc160326c666d5990e34de5327813d9403 Gerrit-Change-Number: 85749 Gerrit-PatchSet: 8 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 12:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ana Carolina Cabral

1 0

[L] Change in coreboot[main]: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC
by Anand Vaikar (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Anand Vaikar, Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Hello Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85749?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC ...................................................................... mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC 1) Initial commit for crater mainboard changes for RN/CZ SOC 2) Add the initial DXIO descriptors for crater 3) Add the DDI descriptors for crater 4) GPIO changes for crater mainboard TEST:Build crater mainboard changes with cezanne SOC Change-Id: Ibdb276fc160326c666d5990e34de5327813d9403 Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- A src/mainboard/amd/crater/Kconfig A src/mainboard/amd/crater/Kconfig.name A src/mainboard/amd/crater/Makefile.mk A src/mainboard/amd/crater/board_info.txt A src/mainboard/amd/crater/board_renoir.fmd A src/mainboard/amd/crater/bootblock.c A src/mainboard/amd/crater/chromeos.c A src/mainboard/amd/crater/chromeos_renoir.fmd A src/mainboard/amd/crater/devicetree_renoir.cb A src/mainboard/amd/crater/dsdt.asl A src/mainboard/amd/crater/early_gpio.c A src/mainboard/amd/crater/ec.c A src/mainboard/amd/crater/ec.h A src/mainboard/amd/crater/gpio.c A src/mainboard/amd/crater/gpio.h A src/mainboard/amd/crater/mainboard.c A src/mainboard/amd/crater/port_descriptors_renoir.c M src/soc/amd/cezanne/chip.h M src/soc/amd/cezanne/include/soc/gpio.h 19 files changed, 941 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/85749/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/85749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdb276fc160326c666d5990e34de5327813d9403 Gerrit-Change-Number: 85749 Gerrit-PatchSet: 8 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add srclken_rc drivers
by Yidi Lin (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85842?usp=email ) Change subject: soc/mediatek/mt8196: Add srclken_rc drivers ...................................................................... Patch Set 1: (14 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85842/comment/122078bb_d774b180?us… : PS1, Line 9: Mt8196 MT8196 https://review.coreboot.org/c/coreboot/+/85842/comment/3f6f082a_b4748832?us… : PS1, Line 8: : Mt8196 use new RC mode with clk_buf driver, and need srclken_rc to send : cmd. Can you elaborate more ? What is RC mode ? What is this driver for ? File src/soc/mediatek/mt8196/include/soc/srclken_rc.h: https://review.coreboot.org/c/coreboot/+/85842/comment/d42ce3d5_eae44a9f?us… : PS1, Line 6: /*********************************************************************************** : ** Definitions : ************************************************************************************/ remove https://review.coreboot.org/c/coreboot/+/85842/comment/3305315d_9c55b956?us… : PS1, Line 192: remove one tab File src/soc/mediatek/mt8196/srclken_rc.c: https://review.coreboot.org/c/coreboot/+/85842/comment/85957d5b_39f4fe91?us… : PS1, Line 69: #define SW_BBLPM_HIGH 1 : #define SW_BBLPM_LOW 0 : #define SW_FPM_HIGH 1 : #define SW_FPM_LOW 0 use enum ? https://review.coreboot.org/c/coreboot/+/85842/comment/1c7770b6_1b57a511?us… : PS1, Line 149: | move `|` to above line https://review.coreboot.org/c/coreboot/+/85842/comment/2f17b35e_020173e4?us… : PS1, Line 278: DCXO_SETTLE_BLK_EN align with first param https://review.coreboot.org/c/coreboot/+/85842/comment/dbb1e742_d0da4092?us… : PS1, Line 312: else : return; ``` if (mode == ... ) .... else .... ``` We can assume the parameter is correct if the function is not visible to other files. https://review.coreboot.org/c/coreboot/+/85842/comment/4ff9ae6a_b905639b?us… : PS1, Line 318: id, read32(&rc_regs->rc_mxx_srclken_cfg[id])); move to above line https://review.coreboot.org/c/coreboot/+/85842/comment/5ac57d2a_b595363e?us… : PS1, Line 320: remove one blank line https://review.coreboot.org/c/coreboot/+/85842/comment/34a24b90_bc456ca6?us… : PS1, Line 359: retry(ACK_DELAY_TIMES, (read32(&rc_status_regs->rc_mxx_req_sta_0[chn]) & 0xa) == state, udelay(ACK_DELAY_US)) ``` if (!retry(ACK_DELAY_TIMES, (read32(&rc_status_regs->rc_mxx_req_sta_0[chn]) & 0xa) == state, udelay(ACK_DELAY_US))) { ``` https://review.coreboot.org/c/coreboot/+/85842/comment/97f8b272_1e4782ed?us… : PS1, Line 360: 0x%x %#x https://review.coreboot.org/c/coreboot/+/85842/comment/0b8ac618_a65a557f?us… : PS1, Line 362: chn, move to the above line https://review.coreboot.org/c/coreboot/+/85842/comment/f16dbbe6_90880309?us… : PS1, Line 385: dsb coreboot read/write APIs already include `dmb()`. Are you sure dsb is necessary ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85842?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40f8d2b12027955e6bd57b666e9f04c0116a0a93 Gerrit-Change-Number: 85842 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 03 Jan 2025 12:34:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Correct the argument type of ADC
by Jarried Lin (Code Review) 03 Jan '25

03 Jan '25

Jarried Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/85840?usp=email ) Change subject: mb/google/rauru: Correct the argument type of ADC ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/85840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3d55e787dd86d474c299b2f7ad4a2fefda436a60 Gerrit-Change-Number: 85840 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Correct the argument type of MT6363
by Jarried Lin (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Hello Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85839?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8196: Correct the argument type of MT6363 ...................................................................... soc/mediatek/mt8196: Correct the argument type of MT6363 Correct the argument type of the mt6363_sdmadc_read API and the return value type of the mt6363_read16 API. TEST=Build pass BUG=b:317009620 Change-Id: I0f768e23473fa924245d90ab1e4fa383ec437db3 Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> --- M src/mainboard/google/rauru/boardid.c M src/soc/mediatek/common/include/soc/mt6363.h M src/soc/mediatek/common/include/soc/mt6363_sdmadc.h M src/soc/mediatek/common/mt6363.c M src/soc/mediatek/common/mt6363_sdmadc.c 5 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/85839/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85839?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f768e23473fa924245d90ab1e4fa383ec437db3 Gerrit-Change-Number: 85839 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025