coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[L] Change in coreboot[main]: Documentation/internals: Add devicetree documentation
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Martin L Roth. Nicholas Chin has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/84709?usp=email ) Change subject: Documentation/internals: Add devicetree documentation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Any plans to continue work on this? -- To view, visit https://review.coreboot.org/c/coreboot/+/84709?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a43a96911844bd2b682004d5423126ad00a4bf3 Gerrit-Change-Number: 84709 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 18:16:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: Documentation/internals: Add devicetree language documentation
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Martin L Roth. Nicholas Chin has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/84710?usp=email ) Change subject: Documentation/internals: Add devicetree language documentation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Any plans to continue work on this? -- To view, visit https://review.coreboot.org/c/coreboot/+/84710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If868ad9a87cb2903bf144996fe3b87d29d4fc755 Gerrit-Change-Number: 84710 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 18:16:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/qemu-i440fx: refactor fw_cfg logic as separate driver
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Carlos López, Maximilian Brune, Philipp Hug, ron minnich. Nicholas Chin has posted comments on this change by Carlos López. ( https://review.coreboot.org/c/coreboot/+/85673?usp=email ) Change subject: mb/qemu-i440fx: refactor fw_cfg logic as separate driver ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c5c4cb5f5478abd21aab8e8d0b503db41d81d40 Gerrit-Change-Number: 85673 Gerrit-PatchSet: 1 Gerrit-Owner: Carlos López <carlos.lopezr4096(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Carlos López <carlos.lopezr4096(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 18:14:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/asus/p8x7x-series: Add Z77-A as a variant
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Keith Hui. Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85836?usp=email ) Change subject: mb/asus/p8x7x-series: Add Z77-A as a variant ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/mainboard/asus/p8x7x-series/variants/z77-a/hda/hda_verb.c: PS1: Seems like an extra file which wasn't supposed to be committed? -- To view, visit https://review.coreboot.org/c/coreboot/+/85836?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1a81b321c236bb1fd2763d69531958ef6f4b4e6 Gerrit-Change-Number: 85836 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 18:09:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/asus/h61-series: Add P8H67-I DELUXE variant
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons, Riku Viitanen. Nicholas Chin has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85832?usp=email ) Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant ...................................................................... Patch Set 7: Code-Review+1 (6 comments) File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/early_init.c: https://review.coreboot.org/c/coreboot/+/85832/comment/c686895b_1da4fd29?us… : PS7, Line 8: PCI_DEV(0, 0x1f, 0), 0x82, 0x3f00 Could be replaced with macros in `sb/intel/bd82x6x/pch.h`: ```suggestion pci_write_config16(PCH_LPC_DEV, LPC_EN, CNF2_LPC_EN | CNF1_LPC_EN | MC_LPC_EN | KBC_LPC_EN | GAMEH_LPC_EN | GAMEL_LPC_EN);``` https://review.coreboot.org/c/coreboot/+/85832/comment/4ffc9c52_cd3490c6?us… : PS7, Line 9: PCI_DEV(0, 0x1f, 0), 0x80, 0x0010 Same here: ```suggestion pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x0010); ``` Also, since COMB_LPC_EN isn't enabled in the LPC_EN register, setting a value for the COMB Decode Range (bits 6:4) to 0x1 (decode 0x2f8 - 0x2ff to LPC) wouldn't have any effect. File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb: PS7: Add SPDX header https://review.coreboot.org/c/coreboot/+/85832/comment/d9f763b1_e3146bd6?us… : PS7, Line 2: register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" Move under igd https://review.coreboot.org/c/coreboot/+/85832/comment/dcf770e1_23e392a3?us… : PS7, Line 40: subsystemid 0x1043 0x848d It looks like it is possible to use a `subsystemid 0xnnnn 0xnnnn inherit` and then still specify a subsystemid for an individual device which will override it (refer to the `subsystem_device` fields in the generated `static.c` file). That way all the `subsystemid 0x1043 0x844d` lines could be dropped and this one could be kept in place. https://review.coreboot.org/c/coreboot/+/85832/comment/4160f17d_f3e30f5b?us… : PS7, Line 62: device ref pci_bridge off end Defaults to off in chipset devicetree and can be removed from the overridetree -- To view, visit https://review.coreboot.org/c/coreboot/+/85832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Gerrit-Change-Number: 85832 Gerrit-PatchSet: 7 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 17:57:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Documentation/mb/hp: Rename pro_3500_series
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

1 0

[XS] Change in coreboot[main]: Documentation/mb/hp: Rename pro_3500_series
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons, Václav Straka. Nicholas Chin has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85846?usp=email ) Change subject: Documentation/mb/hp: Rename pro_3500_series ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85846/comment/047c9b4e_2730e62a?us… : PS1, Line 7: Documentation/mb/hp: Rename pro_3500_series Maybe: "Doc/mb/hp: Rename pro_3500_series to pro_3x00 series" to better summarize what actually changed https://review.coreboot.org/c/coreboot/+/85846/comment/b22d270c_0601defe?us… : PS1, Line 9: Follow-up to CB:85825 Avoiding CB: references in commit messages is generally preferred. Maybe: "The pro_3500_series was converted to a variant to include the Pro 3400, so rename the corresponding documentation." If CB:85825 gets merged before this then the commit message here could also be changed to incorporate the actual commit hash. -- To view, visit https://review.coreboot.org/c/coreboot/+/85846?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5977f223d6f004a801e163397d1c97febd7ee1d4 Gerrit-Change-Number: 85846 Gerrit-PatchSet: 1 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 17:20:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/hp/pro_3x00_series: Remove unused brightness control
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Václav Straka. Nicholas Chin has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85847?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/hp/pro_3x00_series: Remove unused brightness control ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85847/comment/59bfcd0f_647a7e9a?us… : PS1, Line 7: Remove unused brightness control Maybe: "Remove unused ACPI brightness control" to make it more clear what this patch is actually changing. https://review.coreboot.org/c/coreboot/+/85847/comment/a4eeb8fa_3e5224b6?us… : PS1, Line 10: a display Maybe: "an integrated display" -- To view, visit https://review.coreboot.org/c/coreboot/+/85847?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id39cd18713cc596eb2c92e028dad480fe7de8ef2 Gerrit-Change-Number: 85847 Gerrit-PatchSet: 1 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 17:13:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/hp/pro_3x00_series: Remove unused brightness control
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Václav Straka. Nicholas Chin has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85847?usp=email ) Change subject: mb/hp/pro_3x00_series: Remove unused brightness control ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85847?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id39cd18713cc596eb2c92e028dad480fe7de8ef2 Gerrit-Change-Number: 85847 Gerrit-PatchSet: 1 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 16:58:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Felix Singer (Code Review) 04 Jan '25

04 Jan '25

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85851?usp=email ) Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... 3rdparty/fsp: Update submodule to upstream master Updating from commit id 909cf43ad6cc: 2024-12-09 14:08:48 +0800 - (IoT ADL-N IPU25.1 (5354_00)) to commit id fa3362bf4896: 2025-01-03 11:23:50 +0800 - (Merge branch 'master' of https://github.com/intel/FSP) This brings in 3 new commits: fa3362bf4896 Merge branch 'master' of https://github.com/intel/FSP 0a9eafc9737b IoT ADL-N MR6 (5481_00) e276be95bac3 NEX MTL-UH_MTL-PS MR2 (4122_56) FSP Change-Id: I2d04308773ccc99983275355c928cd01b034da26 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/85851/1 diff --git a/3rdparty/fsp b/3rdparty/fsp index 909cf43..fa3362b 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 909cf43ad6ccebb6adee482bc0a4f098c32c9a6d +Subproject commit fa3362bf489681185db3a2b28e7d487c06475f2a -- To view, visit https://review.coreboot.org/c/coreboot/+/85851?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d04308773ccc99983275355c928cd01b034da26 Gerrit-Change-Number: 85851 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025