coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[L] Change in coreboot[main]: mb/asus/h61-series: Add P8H67-I DELUXE variant
by Riku Viitanen (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons, Riku Viitanen. Hello Angel Pons, Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85832?usp=email to look at the new patch set (#11). Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant ...................................................................... mb/asus/h61-series: Add P8H67-I DELUXE variant On vendor firmware, the IFD is read-only and ME completely locked. But the BIOS region can be internally flashed with coreboot. Super I/O GP15 is connected to HDA_SDO, potentially enabling write access to entire flash. Simply setting this GPIO, and restarting the board wasn't enough. Tested: - i5-2500K - 8GB or 2x8GB Hynix HMT41GS6BFR8A-RD (@1333MHz) - 8+4GB Hynix HMT351S6EFR8A-PB (@1333MHz) - Internal SATA ports - Realtek Ethernet - libgfxinit, onboard DVI - All rear USB and USB3 ports, internal Bluetooth dongle is detected - SeaBIOS boots to Void Linux and Devuan - PS/2 keyboard and mouse (only combo port, one at a time) - PEG slot - Mini-PCIe WLAN slot Not tested: - eSATA - SPDIF - LEDs: front panel Not working: - Super I/O shows weird temperatures in lm_sensors: CPU -51°C AUX +84°C - Resuming from S3 when root partition is on an USB 3.0 stick (works when it's attached to USB 2.0 or SATA). - DRAM_LED (on vendor firmware, it stays lit if there are DRAM problems) Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/h61-series/Kconfig.name A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/board_info.txt A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/cmos.default A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/cmos.layout A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/data.vbt A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/early_init.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/gma-mainboard.ads A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/gpio.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/hda_verb.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb 11 files changed, 443 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/85832/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/85832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Gerrit-Change-Number: 85832 Gerrit-PatchSet: 11 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asus/h61-series: Add P8H67-I DELUXE variant
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons, Riku Viitanen. Nicholas Chin has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85832?usp=email ) Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant ...................................................................... Patch Set 10: (2 comments) File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85832/comment/4c971455_f5d8c8c1?us… : PS10, Line 34: device ref mei1 on end Oh, I guess with the subsystemid entries removed this is now unnecessary as it's the same as the chipset devicetree. https://review.coreboot.org/c/coreboot/+/85832/comment/206c7f99_43371379?us… : PS10, Line 99: device ref smbus on end Same here, can be removed. -- To view, visit https://review.coreboot.org/c/coreboot/+/85832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Gerrit-Change-Number: 85832 Gerrit-PatchSet: 10 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 20:43:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/asus/h61-series: Add P8H67-I DELUXE variant
by Riku Viitanen (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons, Nicholas Chin. Hello Angel Pons, Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85832?usp=email to look at the new patch set (#10). Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant ...................................................................... mb/asus/h61-series: Add P8H67-I DELUXE variant On vendor firmware, the IFD is read-only and ME completely locked. But the BIOS region can be internally flashed with coreboot. Super I/O GP15 is connected to HDA_SDO, potentially enabling write access to entire flash. Simply setting this GPIO, and restarting the board wasn't enough. Tested: - i5-2500K - 8GB or 2x8GB Hynix HMT41GS6BFR8A-RD (@1333MHz) - 8+4GB Hynix HMT351S6EFR8A-PB (@1333MHz) - Internal SATA ports - Realtek Ethernet - libgfxinit, onboard DVI - All rear USB and USB3 ports, internal Bluetooth dongle is detected - SeaBIOS boots to Void Linux and Devuan - PS/2 keyboard and mouse (only combo port, one at a time) - PEG slot - Mini-PCIe WLAN slot Not tested: - eSATA - SPDIF - LEDs: front panel Not working: - Super I/O shows weird temperatures in lm_sensors: CPU -51°C AUX +84°C - Resuming from S3 when root partition is on an USB 3.0 stick (works when it's attached to USB 2.0 or SATA). - DRAM_LED (on vendor firmware, it stays lit if there are DRAM problems) Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/h61-series/Kconfig.name A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/board_info.txt A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/cmos.default A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/cmos.layout A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/data.vbt A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/early_init.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/gma-mainboard.ads A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/gpio.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/hda_verb.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb 11 files changed, 448 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/85832/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/85832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Gerrit-Change-Number: 85832 Gerrit-PatchSet: 10 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asus/h61-series: Add P8H67-I DELUXE variant
by Riku Viitanen (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons, Nicholas Chin. Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85832?usp=email ) Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant ...................................................................... Patch Set 8: (6 comments) File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/early_init.c: https://review.coreboot.org/c/coreboot/+/85832/comment/4439c7f3_884f51db?us… : PS7, Line 8: PCI_DEV(0, 0x1f, 0), 0x82, 0x3f00 > Could be replaced with macros in `sb/intel/bd82x6x/pch.h`: […] Done https://review.coreboot.org/c/coreboot/+/85832/comment/866e7018_1e7127af?us… : PS7, Line 9: PCI_DEV(0, 0x1f, 0), 0x80, 0x0010 > Same here: […] removed File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb: PS7: > Add SPDX header Done https://review.coreboot.org/c/coreboot/+/85832/comment/8e4a889a_615c65d2?us… : PS7, Line 2: register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" > Move under igd Done https://review.coreboot.org/c/coreboot/+/85832/comment/d5871938_b80402c1?us… : PS7, Line 40: subsystemid 0x1043 0x848d > It looks like it is possible to use a `subsystemid 0xnnnn 0xnnnn inherit` and then still specify a s […] Done https://review.coreboot.org/c/coreboot/+/85832/comment/18576708_be78afe1?us… : PS7, Line 62: device ref pci_bridge off end > Defaults to off in chipset devicetree and can be removed from the overridetree Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Gerrit-Change-Number: 85832 Gerrit-PatchSet: 8 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 19:47:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asus/h61-series: Add P8H67-I DELUXE variant
by Riku Viitanen (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons, Nicholas Chin, Riku Viitanen. Hello Angel Pons, Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85832?usp=email to look at the new patch set (#9). Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant ...................................................................... mb/asus/h61-series: Add P8H67-I DELUXE variant On vendor firmware, the IFD is read-only and ME completely locked. But the BIOS region can be internally flashed with coreboot. Super I/O GP15 is connected to HDA_SDO, potentially enabling write access to entire flash. Simply setting this GPIO, and restarting the board wasn't enough. Tested: - i5-2500K - 8GB or 2x8GB Hynix HMT41GS6BFR8A-RD (@1333MHz) - 8+4GB Hynix HMT351S6EFR8A-PB (@1333MHz) - Internal SATA ports - Realtek Ethernet - libgfxinit, onboard DVI - All rear USB and USB3 ports, internal Bluetooth dongle is detected - SeaBIOS boots to Void Linux and Devuan - PS/2 keyboard and mouse (only combo port, one at a time) - PEG slot - Mini-PCIe WLAN slot Not tested: - eSATA - SPDIF - LEDs: front panel Not working: - Super I/O shows weird temperatures in lm_sensors: CPU -51°C AUX +84°C - Resuming from S3 when root partition is on an USB 3.0 stick (works when it's attached to USB 2.0 or SATA). - DRAM_LED (on vendor firmware, it stays lit if there are DRAM problems) Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/h61-series/Kconfig.name A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/board_info.txt A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/cmos.default A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/cmos.layout A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/data.vbt A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/early_init.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/gma-mainboard.ads A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/gpio.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/hda_verb.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb 11 files changed, 448 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/85832/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/85832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Gerrit-Change-Number: 85832 Gerrit-PatchSet: 9 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asus/h61-series: Add P8H67-I DELUXE variant
by Riku Viitanen (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons, Nicholas Chin, Riku Viitanen. Hello Angel Pons, Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85832?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+1 by Nicholas Chin, Verified+1 by build bot (Jenkins) Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant ...................................................................... mb/asus/h61-series: Add P8H67-I DELUXE variant On vendor firmware, the IFD is read-only and ME completely locked. But the BIOS region can be internally flashed with coreboot. Super I/O GP15 is connected to HDA_SDO, potentially enabling write access to entire flash. Simply setting this GPIO, and restarting the board wasn't enough. Tested: - i5-2500K - 8GB or 2x8GB Hynix HMT41GS6BFR8A-RD (@1333MHz) - 8+4GB Hynix HMT351S6EFR8A-PB (@1333MHz) - Internal SATA ports - Realtek Ethernet - libgfxinit, onboard DVI - All rear USB and USB3 ports, internal Bluetooth dongle is detected - SeaBIOS boots to Void Linux and Devuan - PS/2 keyboard and mouse (only combo port, one at a time) - PEG slot - Mini-PCIe WLAN slot Not tested: - eSATA - SPDIF - LEDs: front panel Not working: - Super I/O shows weird temperatures in lm_sensors: CPU -51°C AUX +84°C - Resuming from S3 when root partition is on an USB 3.0 stick (works in when it's attached to USB 2.0 or SATA). - DRAM_LED (on vendor firmware, it stays lit if there are DRAM problems) Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/h61-series/Kconfig.name A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/board_info.txt A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/cmos.default A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/cmos.layout A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/data.vbt A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/early_init.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/gma-mainboard.ads A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/gpio.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/hda_verb.c A src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb 11 files changed, 448 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/85832/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/85832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7de37a5cb8bf8d44253fe3418ffc9e07caca9703 Gerrit-Change-Number: 85832 Gerrit-PatchSet: 8 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: doc/util/ifdtool: Update instructions
by Felix Singer (Code Review) 04 Jan '25

04 Jan '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85235?usp=email ) Change subject: doc/util/ifdtool: Update instructions ...................................................................... doc/util/ifdtool: Update instructions - Add step for building ifdtool (might not be obvious) - Remove "./ifdtool COREBOOT_NAME" because it does nothing - Add a small comment explaining what the -d and -x args do. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I868ea8918a1566cfade3bc161117f2ca8dfed31d Reviewed-on: https://review.coreboot.org/c/coreboot/+/85235 Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M Documentation/util/ifdtool/binary_extraction.md 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Nicholas Chin: Looks good to me, approved diff --git a/Documentation/util/ifdtool/binary_extraction.md b/Documentation/util/ifdtool/binary_extraction.md index fe8c25c..6b5a37a 100644 --- a/Documentation/util/ifdtool/binary_extraction.md +++ b/Documentation/util/ifdtool/binary_extraction.md @@ -9,9 +9,9 @@ **Note:** Make sure you are in the root coreboot directory. cd /path/to/coreboot/util/ifdtool - ./ifdtool COREBOOT_IMAGE - ./ifdtool -d COREBOOT_IMAGE - ./ifdtool -x COREBOOT_IMAGE + make + ./ifdtool -d COREBOOT_IMAGE # dump flash descriptor to stdout + ./ifdtool -x COREBOOT_IMAGE # extract IFD binaries into files (e.g. ME, IFD, GBE...) In the above steps, COREBOOT_IMAGE is the name of the ROM image to extract the binaries from, including the file path (ex. /build/coreboot.rom). -- To view, visit https://review.coreboot.org/c/coreboot/+/85235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I868ea8918a1566cfade3bc161117f2ca8dfed31d Gerrit-Change-Number: 85235 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: doc/util/ifdtool: Update instructions
by Felix Singer (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Martin L Roth, Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/85235?usp=email ) Change subject: doc/util/ifdtool: Update instructions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I868ea8918a1566cfade3bc161117f2ca8dfed31d Gerrit-Change-Number: 85235 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 19:30:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[master]: util/cbfstool: Add a new mechanism to provide a memory map
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Arthur Heymans. Nicholas Chin has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/68160?usp=email ) Change subject: util/cbfstool: Add a new mechanism to provide a memory map ...................................................................... Patch Set 8: (1 comment) File util/cbfstool/cbfstool.c: https://review.coreboot.org/c/coreboot/+/68160/comment/53c43869_98777d7d?us… : PS8, Line 1974: " [--ext-win-base win-base --ext-win-size win-size] " > I just noticed that you forgot to update the help text here, it still says --ext-win-base today. Addressed in CB:85619 -- To view, visit https://review.coreboot.org/c/coreboot/+/68160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38ab4c369704497f711e14ecda3ff3a8cdc0d089 Gerrit-Change-Number: 68160 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 04 Jan 2025 18:21:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: cbfs: Remove remnants of ext-win-*
by Nicholas Chin (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Maximilian Brune. Nicholas Chin has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/85619?usp=email ) Change subject: cbfs: Remove remnants of ext-win-* ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85619?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I33cfb59d9dbe88c4f618301ac1506e3281b1a483 Gerrit-Change-Number: 85619 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 18:20:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025