coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[M] Change in coreboot[main]: mb/google/nissa/var/telith: Reduce power limits according to battery ...
by Kun Liu (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Rui Zhou. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85894?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Rui Zhou, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/telith: Reduce power limits according to battery status ...................................................................... mb/google/nissa/var/telith: Reduce power limits according to battery status When battery is not present, reduce power limits, avoid inability to enter the system. This will check the current battery status and configure cpu power limits using current PD power value. BUG=b:384883899 BRANCH=none TEST=built and verified PL4 values,power engineer verify pass. Change-Id: I7e0c7289c20c4ce51eae2a48eb8f09acfcb9e958 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/baseboard/nissa/ramstage.c M src/mainboard/google/brya/variants/telith/Makefile.mk A src/mainboard/google/brya/variants/telith/ramstage.c 3 files changed, 92 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/85894/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85894?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e0c7289c20c4ce51eae2a48eb8f09acfcb9e958 Gerrit-Change-Number: 85894 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>

1 0

[L] Change in coreboot[main]: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC
by Felix Held (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Fred Reitberger, Jason Glenesk, Matt DeVillier. Felix Held has posted comments on this change by Anand Vaikar. ( https://review.coreboot.org/c/coreboot/+/85749?usp=email ) Change subject: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC ...................................................................... Patch Set 9: (4 comments) Patchset: PS9: one small change request; the rest looks good to me. the other comments are more todos for future patches File src/mainboard/amd/crater/Kconfig: https://review.coreboot.org/c/coreboot/+/85749/comment/5a8b177d_bb5169f1?us… : PS9, Line 28: && BOARD_AMD_CRATER_RENOIR this condition is redundant, sonce it's already in an if BOARD_AMD_CRATER_RENOIR block. missed that one in the last review round File src/mainboard/amd/crater/port_descriptors_renoir.c: https://review.coreboot.org/c/coreboot/+/85749/comment/b6b0194e_2d25174d?us… : PS9, Line 46: ASPM_DISABLED disabling ASPM for the SSD seems unexpected to me, but that power optimization can be looked into later. let's land the board first and then do some of the smaller optimizations https://review.coreboot.org/c/coreboot/+/85749/comment/d4bbc7f6_5c56bde7?us… : PS9, Line 54: }; without having checked the schematic, it looks to me that we're missing some dxio descriptors here. i'm ok with addressing that one in some a follow-up patch in the future -- To view, visit https://review.coreboot.org/c/coreboot/+/85749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdb276fc160326c666d5990e34de5327813d9403 Gerrit-Change-Number: 85749 Gerrit-PatchSet: 9 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Comment-Date: Wed, 08 Jan 2025 21:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/amd/cezanne: Disable I2S internal clock based on mainboard config
by Felix Held (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Anand Vaikar, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nick Kochlowski. Felix Held has posted comments on this change by Anand Vaikar. ( https://review.coreboot.org/c/coreboot/+/85865?usp=email ) Change subject: soc/amd/cezanne: Disable I2S internal clock based on mainboard config ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85865/comment/67f037e5_ddcc92f6?us… : PS3, Line 7: soc/amd/cezanne: Disable I2S internal clock based on mainboard config maybe: soc/amd/cezanne: add option to disable I2S master clock output of FCH Add a devicetree option to disable the 48MHz clock output of the FCH when an I2S audio coded uses a separate oscillator for its 48 MHz master clock instead of the FCH clock output. This code was ported from the Picasso code base. File src/soc/amd/cezanne/fch.c: https://review.coreboot.org/c/coreboot/+/85865/comment/6af47058_70707bd1?us… : PS3, Line 86: const struct soc_amd_cezanne_config *cfg; : cfg = config_of_soc(); i'd do the creation of the local variable and the assignment in one line: const struct soc_amd_picasso_config *cfg = config_of_soc(); that's more compact and in line with the picasso code https://review.coreboot.org/c/coreboot/+/85865/comment/083ab5e3_3d9df732?us… : PS3, Line 89: /* Master clock is dsabled as the clock is given externally*/ i'd say that this line of comments is a bit redundant and could be dropped. also a typo in d\*i\*sabled and a space missing before the \*/ -- To view, visit https://review.coreboot.org/c/coreboot/+/85865?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0c1bee121f528d28d591dace260507b345dfec26 Gerrit-Change-Number: 85865 Gerrit-PatchSet: 3 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 21:18:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: Update Maintainers file
by Martin Roth (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Martin L Roth. Martin Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/85883?usp=email ) Change subject: Update Maintainers file ...................................................................... Patch Set 3: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/coreboot/+/85883/comment/73e8ab82_d1d6e512?us… : PS2, Line 775: Maintained > this should be kept as odd fixes, since that's the old pre-soc/amd code. […] The issue is that src/vendorcode/amd is not all legacy code. That contains the openSIL code. I can separate out vc/amd/opensil, but then I think I need to add everything else in vc/amd to this list: vc/amd/fsp vc/amd/include vc/amd/pi vc/amd/psp_verstage Instead of doing that, I just marked it as maintained saying that someone would typically respond in a month or so... -- To view, visit https://review.coreboot.org/c/coreboot/+/85883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2feac94595081fcea9becd9d8067ddd99a50123c Gerrit-Change-Number: 85883 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 19:42:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[M] Change in coreboot[main]: Update Maintainers file
by Fred Reitberger (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Martin L Roth. Fred Reitberger has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/85883?usp=email ) Change subject: Update Maintainers file ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2feac94595081fcea9becd9d8067ddd99a50123c Gerrit-Change-Number: 85883 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 19:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: Documentation: Add a statement about committer responsibilities
by Jérémy Compostella (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Martin L Roth. Jérémy Compostella has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/85898?usp=email ) Change subject: Documentation: Add a statement about committer responsibilities ...................................................................... Patch Set 1: (1 comment) File Documentation/contributing/index.md: https://review.coreboot.org/c/coreboot/+/85898/comment/9299a7b5_90e9e977?us… : PS1, Line 21: created: legal frameworks, work contracts, "AI" tooling, or other > s/"AI"/Artificial Intelligence ("AI")/ "Generative" ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibfc92fc76149f96bd8e65befce99f3a2ddc3d847 Gerrit-Change-Number: 85898 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:58:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[M] Change in coreboot[main]: Update Maintainers file
by Matt DeVillier (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Martin L Roth. Matt DeVillier has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/85883?usp=email ) Change subject: Update Maintainers file ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2feac94595081fcea9becd9d8067ddd99a50123c Gerrit-Change-Number: 85883 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:58:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: Documentation: Add a statement about committer responsibilities
by Jérémy Compostella (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Martin L Roth. Jérémy Compostella has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/85898?usp=email ) Change subject: Documentation: Add a statement about committer responsibilities ...................................................................... Patch Set 1: (1 comment) File Documentation/contributing/index.md: https://review.coreboot.org/c/coreboot/+/85898/comment/1eb7f43f_dc799c93?us… : PS1, Line 21: created: legal frameworks, work contracts, "AI" tooling, or other s/"AI"/Artificial Intelligence ("AI")/ -- To view, visit https://review.coreboot.org/c/coreboot/+/85898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibfc92fc76149f96bd8e65befce99f3a2ddc3d847 Gerrit-Change-Number: 85898 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:56:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: Documentation: Add a statement about committer responsibilities
by Martin L Roth (Code Review) 08 Jan '25

08 Jan '25

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85898?usp=email ) Change subject: Documentation: Add a statement about committer responsibilities ...................................................................... Documentation: Add a statement about committer responsibilities This statement clarifies committer responsibilities, including using generative AI. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ibfc92fc76149f96bd8e65befce99f3a2ddc3d847 --- M Documentation/contributing/index.md 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/85898/1 diff --git a/Documentation/contributing/index.md b/Documentation/contributing/index.md index 38a67c0..cfbc96c 100644 --- a/Documentation/contributing/index.md +++ b/Documentation/contributing/index.md @@ -9,3 +9,19 @@ Documentation Ideas <documentation_ideas.md> Google Summer of Code <gsoc.md> ``` + +The coreboot project uses the Developer Certificate of Origin as its +policy of accepting contributions. As such, a submitter bears the burden +that they have all necessary rights to submit their contribution to the +project under the project's licenses as appropriate. Violations of third +party rights will lead to the code's removal or replacement as suitable +to bring the project back into compliance. + +This applies no matter under which circumstances a contribution has been +created: legal frameworks, work contracts, "AI" tooling, or other +aspects that may affect the ownership and copyright status of a +contribution are outside the project's control. + +See the [Sign-off procedure] for more information. + +[Sign-off procedure]: gerrit_guidelines.md#sign-off-procedure -- To view, visit https://review.coreboot.org/c/coreboot/+/85898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibfc92fc76149f96bd8e65befce99f3a2ddc3d847 Gerrit-Change-Number: 85898 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>

1 0

[M] Change in coreboot[main]: Update Maintainers file
by Martin L Roth (Code Review) 08 Jan '25

08 Jan '25

Attention is currently required from: Martin L Roth, Martin Roth. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85883?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Update Maintainers file ...................................................................... Update Maintainers file - Update AMD maintainers lists to reflect current situation - Remove Ron Minnich as maintainer (At his request) - Update the Infrastructure owners to reflect the current situation. Change-Id: I2feac94595081fcea9becd9d8067ddd99a50123c Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M MAINTAINERS 1 file changed, 24 insertions(+), 54 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/85883/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2feac94595081fcea9becd9d8067ddd99a50123c Gerrit-Change-Number: 85883 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025