coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
3342 discussions

[XS] Change in coreboot[main]: soc/intel/baytrail: Use nullptr instead of NULL
by Elyes Haouas (Code Review) 09 Sep '24

09 Sep '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83919?usp=email to look at the new patch set (#2). Change subject: soc/intel/baytrail: Use nullptr instead of NULL ...................................................................... soc/intel/baytrail: Use nullptr instead of NULL nullptr was introduced in C11 spec and gcc 4.7. https://en.cppreference.com/w/cpp/language/nullptr https://stackoverflow.com/questions/16256586/how-to-enable-c11-on-later-ver… coreboot switched to GCC 4.7.2 on October 25, 2021, prior to coreboot v4.1. https://review.coreboot.org/c/coreboot/+/1609 GCC-13 implemented nullptr constant: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3042.htm So use it insted of NULL macro. Change-Id: Ibb9eb58550364e533e5ca3e97e44a608fe13eba0 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/intel/baytrail/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83919/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83919?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibb9eb58550364e533e5ca3e97e44a608fe13eba0 Gerrit-Change-Number: 83919 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: i945: Use nullptr instead of NULL
by Elyes Haouas (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Alexander Couzens, Elyes Haouas, Evgeny Zinoviev. Hello Alexander Couzens, Evgeny Zinoviev, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83860?usp=email to look at the new patch set (#5). Change subject: i945: Use nullptr instead of NULL ...................................................................... i945: Use nullptr instead of NULL nullptr was introduced in C11 spec and gcc 4.7. https://en.cppreference.com/w/cpp/language/nullptr https://stackoverflow.com/questions/16256586/how-to-enable-c11-on-later-ver… coreboot switched to GCC 4.7.2 on October 25, 2021, prior to coreboot v4.1. https://review.coreboot.org/c/coreboot/+/1609 GCC-13 implemented nullptr constant: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3042.htm So use it insted of NULL macro. Change-Id: I7d47e692a33d739345a81f589d4329a31beeb8c5 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/apple/macbook21/mptable.c M src/mainboard/getac/p470/mptable.c M src/mainboard/ibase/mb899/mptable.c M src/mainboard/intel/d945gclf/mptable.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/kontron/986lcd-m/mptable.c M src/mainboard/lenovo/t60/mptable.c M src/mainboard/lenovo/x60/mptable.c M src/mainboard/roda/rk886ex/mptable.c M src/northbridge/intel/i945/northbridge.c M src/northbridge/intel/i945/raminit.c M src/southbridge/intel/i82801gx/ide.c M src/southbridge/intel/i82801gx/pcie.c M src/southbridge/intel/i82801gx/sata.c 14 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/83860/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/83860?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d47e692a33d739345a81f589d4329a31beeb8c5 Gerrit-Change-Number: 83860 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: include/stdbool: Don't unconditionally typedef bool
by Elyes Haouas (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Elyes Haouas, Nico Huber. Hello Martin L Roth, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83909?usp=email to look at the new patch set (#7). Change subject: include/stdbool: Don't unconditionally typedef bool ...................................................................... include/stdbool: Don't unconditionally typedef bool When compiling with the C23 standard, bool, true, and false are pre-defined by the language, so defining them in stdbool.h isn't allowed. This fixes the following error: src/include/stdbool.h:6:17: error: two or more data types in declaration specifiers 6 | typedef _Bool bool; | ^~~~ src/include/stdbool.h:6:1: error: useless type name in empty declaration [-Werror] 6 | typedef _Bool bool; | ^~~~~~~ Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/stdbool.h 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/83909/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/83909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea Gerrit-Change-Number: 83909 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: mb/google/brox/var/lotso: Configure cpu power limits by battery status
by Karthik Ramasubramanian (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Dengwu Yu, Jian Tong, Subrata Banik, wen zhang. Karthik Ramasubramanian has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/84202?usp=email ) Change subject: mb/google/brox/var/lotso: Configure cpu power limits by battery status ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84202/comment/6c0ae6ba_2563c25c?us… : PS3, Line 9: When battery not persent, limit PL4 to 40. We are working along with Intel on Brox regarding a common solution for this - CB:83752. Hopefully should be resolved sooner. -- To view, visit https://review.coreboot.org/c/coreboot/+/84202?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5848c776399a1bdc455db604bb3b22d16f6b2928 Gerrit-Change-Number: 84202 Gerrit-PatchSet: 3 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Sep 2024 19:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/lotso: Enable ASPM for PCIe4 SSD of CPU
by Karthik Ramasubramanian (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Jian Tong, Wentao Qin. Karthik Ramasubramanian has posted comments on this change by Wentao Qin. ( https://review.coreboot.org/c/coreboot/+/84241?usp=email ) Change subject: mb/google/brox/var/lotso: Enable ASPM for PCIe4 SSD of CPU ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84241?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a7f69bb82ad24b29566541d7694f87f9c6458d6 Gerrit-Change-Number: 84241 Gerrit-PatchSet: 2 Gerrit-Owner: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Sep 2024 19:39:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: [Prepare for C23]i945: Use nullptr instead of NULL
by Martin L Roth (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Alexander Couzens, Elyes Haouas, Evgeny Zinoviev. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83860?usp=email ) Change subject: [Prepare for C23]i945: Use nullptr instead of NULL ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83860/comment/502f389e_b8745bcf?us… : PS4, Line 7: [Prepare for C23] I'd probably remove the C23 text since it doesn't seem to be completely accurate. Maybe just "Use nullptr instead of NULL." BTW, here's the argument paper for it: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf https://review.coreboot.org/c/coreboot/+/83860/comment/c0f67562_9d2b1584?us… : PS4, Line 10: Maybe mention that nullptr was introduced in C11 spec and gcc 4.7. - https://en.cppreference.com/w/cpp/language/nullptr - https://stackoverflow.com/questions/16256586/how-to-enable-c11-on-later-ver… coreboot switched to GCC 4.7.2 on October 25, 2021, prior to coreboot v4.1. - https://review.coreboot.org/c/coreboot/+/1609 -- To view, visit https://review.coreboot.org/c/coreboot/+/83860?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d47e692a33d739345a81f589d4329a31beeb8c5 Gerrit-Change-Number: 83860 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 09 Sep 2024 19:19:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: include/stdbool: Fix useless type name in empty declaration error
by Martin L Roth (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Elyes Haouas, Nico Huber. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83909?usp=email ) Change subject: include/stdbool: Fix useless type name in empty declaration error ...................................................................... Patch Set 6: Code-Review+2 (3 comments) Patchset: PS6: The change looks good, but I think the commit message could be updated with info on why this is an issue. Commit Message: https://review.coreboot.org/c/coreboot/+/83909/comment/3bf8e216_e1d1c843?us… : PS6, Line 7: include/stdbool: Fix useless type name in empty declaration error I preferred your original subject: include/stdbool: Don't unconditionally typedef bool I think we just need to explain why as in my below comment. https://review.coreboot.org/c/coreboot/+/83909/comment/3b5aa2e2_86486a15?us… : PS6, Line 8: Maybe add something like "When compiling with the C23 standard, bool, true, and false are pre-defined by the language, so defining them in stdbool.h isn't allowed." -- To view, visit https://review.coreboot.org/c/coreboot/+/83909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea Gerrit-Change-Number: 83909 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 09 Sep 2024 19:01:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/brox/variants/brox: remove PL4 value modification
by Sowmya Aralguppe (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Balaji Manigandan, Eric Lai, Karthik Ramasubramanian, Paul Menzel, Shelley Chen, Subrata Banik, Sumeet R.P.. Sowmya Aralguppe has posted comments on this change by Sumeet R.P.. ( https://review.coreboot.org/c/coreboot/+/83662?usp=email ) Change subject: mb/google/brox/variants/brox: remove PL4 value modification ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83662/comment/bdb71ba5_5c9bbce7?us… : PS3, Line 9: Remove PL4 value modification based on PsysPL3 value. > For Brox -pl4 value is fixed as 114 watts. […] Done https://review.coreboot.org/c/coreboot/+/83662/comment/6c2d9a23_3ed5d849?us… : PS3, Line 13: TEST=Built and boot on brox system > we can check pl4 value to be initialized at 114 watts Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83662?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7fbc6386769aa9f76a8665a742c97dfd790fd1d Gerrit-Change-Number: 83662 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R.P. <sumeet4linux(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R.P. <sumeet4linux(a)gmail.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 09 Sep 2024 18:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/brox/variants/brox: remove PL4 value modification
by Sowmya Aralguppe (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Balaji Manigandan, Eric Lai, Karthik Ramasubramanian, Paul Menzel, Shelley Chen, Subrata Banik, Sumeet R.P.. Sowmya Aralguppe has posted comments on this change by Sumeet R.P.. ( https://review.coreboot.org/c/coreboot/+/83662?usp=email ) Change subject: mb/google/brox/variants/brox: remove PL4 value modification ...................................................................... Patch Set 4: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83662/comment/4ce093c5_2a1f5364?us… : PS3, Line 7: mb/google/brox/variants/brox:remove PL4 value modification > Please add a space after the colon (:). Done https://review.coreboot.org/c/coreboot/+/83662/comment/8894cc7f_17498e8a?us… : PS3, Line 9: Remove PL4 value modification based on PsysPL3 value. > Why? For Brox -pl4 value is fixed as 114 watts. It was wrongly getting modified to 113watts based on psyspl3.This impacted power and performance measurements for Brox. This patch is addressing that issue by removing pl4 modification. https://review.coreboot.org/c/coreboot/+/83662/comment/e091fda0_b5b79546?us… : PS3, Line 13: TEST=Built and boot on brox system > What difference can be seen? we can check pl4 value to be initialized at 114 watts -- To view, visit https://review.coreboot.org/c/coreboot/+/83662?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7fbc6386769aa9f76a8665a742c97dfd790fd1d Gerrit-Change-Number: 83662 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R.P. <sumeet4linux(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R.P. <sumeet4linux(a)gmail.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 09 Sep 2024 18:47:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: soc/intel/cmn/block/cpu: Simplify calculation of non-eviction ways
by Jérémy Compostella (Code Review) 09 Sep '24

09 Sep '24

Attention is currently required from: Eric Lai, Kapil Porwal, Pranava Y N, Subrata Banik. Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84236?usp=email ) Change subject: soc/intel/cmn/block/cpu: Simplify calculation of non-eviction ways ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/common/block/cpu/car/cache_as_ram.S: https://review.coreboot.org/c/coreboot/+/84236/comment/db4cdd96_7058ce23?us… : PS1, Line 519: add %edx, %eax > > Seems better, did you run a debugger to verify that the registers through this logic ? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7cf5ff19ec440d049edc3bf52c660dea96b1f08a Gerrit-Change-Number: 84236 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Mon, 09 Sep 2024 18:46:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024