coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
by Simon Yang (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik. Simon Yang has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/84098?usp=email ) Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/brya/variants/anraggar/variant.c: https://review.coreboot.org/c/coreboot/+/84098/comment/61794891_bb7117e5?us… : PS5, Line 60: graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, (-1 & ~(TRANS_DDI_AUDIO_MUTE_OVERRIDE_MASK)), : TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET); > > Done […] yes, your suggestion is better, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/84098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Gerrit-Change-Number: 84098 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Aug 2024 15:21:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
by Simon Yang (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Simon Yang. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84098?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick ...................................................................... mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick Panel CSOT MNB601LS1-3 will flicker once during enter Chrome login screen, it is because it inserts 12 blank frames if it receives the unmute in VB-ID. Always override the mute in VB-ID to avoid Tcon EC detected the audiomute_flag change. BUG:b=357764688 BRANCH=firmware-nissa-15217.B TEST:Verfied on Anraggar and cannot reproduce the issue Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Signed-off-by: Simon Yang <simon1.yang(a)intel.com> --- M src/mainboard/google/brya/variants/anraggar/variant.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/84098/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/84098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Gerrit-Change-Number: 84098 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
by Subrata Banik (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Simon Yang. Subrata Banik has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/84098?usp=email ) Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/brya/variants/anraggar/variant.c: https://review.coreboot.org/c/coreboot/+/84098/comment/b7214396_02a73e0a?us… : PS5, Line 60: graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, (-1 & ~(TRANS_DDI_AUDIO_MUTE_OVERRIDE_MASK)), : TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET); > Done my bad, i meant for `~0` and not `~1` you can also do something like this to clear BIT7 and BIT6 ``` graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, ~TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET, TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET); ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/84098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Gerrit-Change-Number: 84098 Gerrit-PatchSet: 6 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:53:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com>

1 0

[S] Change in coreboot[main]: util/hda-decoder: Protect 'fields' slice if empty string
by Angel Pons (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Maxim, Nicholas Sudsgaard. Angel Pons has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/84101?usp=email ) Change subject: util/hda-decoder: Protect 'fields' slice if empty string ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File util/hda-decoder/main.go: https://review.coreboot.org/c/coreboot/+/84101/comment/97850ce6_55f7ae2f?us… : PS1, Line 85: } Log that something went wrong? ```suggestion } else { fmt.Printf("// Something went wrong\n") } ``` I would prefer to log a more descriptive error message, but this may require more refactoring (which would be better taken care of in a follow-up). -- To view, visit https://review.coreboot.org/c/coreboot/+/84101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ae8544e52d82e8d8a82a88a85a2de7d2f295ec1 Gerrit-Change-Number: 84101 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:48:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/hda-decoder: Protect 'fields' slice if empty string
by Maxim (Code Review) 27 Aug '24

27 Aug '24

Maxim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84101?usp=email ) Change subject: util/hda-decoder: Protect 'fields' slice if empty string ...................................................................... util/hda-decoder: Protect 'fields' slice if empty string This avoids panic if the file contains an empty string or an incorrect configuration: goroutine 1 [running]: main.decodeFile({0x7ffd63da92a0?, 0xc000014070?}, 0x8?) /path/to/coreboot/util/hda-decoder/main.go:72 +0x2ef main.main() /path/to/coreboot/util/hda-decoder/main.go:158 +0x2a5 Change-Id: I9ae8544e52d82e8d8a82a88a85a2de7d2f295ec1 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/hda-decoder/main.go 1 file changed, 13 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/84101/1 diff --git a/util/hda-decoder/main.go b/util/hda-decoder/main.go index 83ddcbb..c1a1b13 100644 --- a/util/hda-decoder/main.go +++ b/util/hda-decoder/main.go @@ -68,19 +68,20 @@ scanner := bufio.NewScanner(file) for scanner.Scan() { - fields := strings.Fields(scanner.Text()) - pin := stringToUint32(fields[0]) - config := stringToUint32(fields[1]) + if fields := strings.Fields(scanner.Text()); len(fields) == 2 { + pin := stringToUint32(fields[0]) + config := stringToUint32(fields[1]) - indentedPrintf("AZALIA_PIN_CFG(%d, 0x%02x, ", codec, pin) - if decoder.PortIsConnected(config) { - fmt.Printf("AZALIA_PIN_DESC(\n") - indentLevel += 1 - decodeConfig(config) - indentLevel -= 1 - indentedPrintf(")),\n") - } else { - printDisconnectedPort(config) + indentedPrintf("AZALIA_PIN_CFG(%d, 0x%02x, ", codec, pin) + if decoder.PortIsConnected(config) { + fmt.Printf("AZALIA_PIN_DESC(\n") + indentLevel += 1 + decodeConfig(config) + indentLevel -= 1 + indentedPrintf(")),\n") + } else { + printDisconnectedPort(config) + } } } } -- To view, visit https://review.coreboot.org/c/coreboot/+/84101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ae8544e52d82e8d8a82a88a85a2de7d2f295ec1 Gerrit-Change-Number: 84101 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
by Simon Yang (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik. Simon Yang has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/84098?usp=email ) Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/brya/variants/anraggar/variant.c: https://review.coreboot.org/c/coreboot/+/84098/comment/be341438_08485b29?us… : PS5, Line 60: graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, (-1 & ~(TRANS_DDI_AUDIO_MUTE_OVERRIDE_MASK)), : TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET); > ~1 is 0xfffffffe but I'd like to pass 0xffffff3f for clearing BIT7 and BIT6 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Gerrit-Change-Number: 84098 Gerrit-PatchSet: 6 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Aug 2024 13:49:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
by Simon Yang (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik. Simon Yang has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/84098?usp=email ) Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick ...................................................................... Patch Set 6: (2 comments) File src/mainboard/google/brya/variants/anraggar/variant.c: https://review.coreboot.org/c/coreboot/+/84098/comment/2f2c2f82_30a737d2?us… : PS5, Line 16: #define TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_RESET (2 << 6) > why we need this ? Done https://review.coreboot.org/c/coreboot/+/84098/comment/f852a1b1_af9f9599?us… : PS5, Line 60: graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, (-1 & ~(TRANS_DDI_AUDIO_MUTE_OVERRIDE_MASK)), : TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET); > ```graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, ~1, TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET);``` ~1 is 0xfffffffe but I'd like to pass 0xffffff3f for clearing BIT7 and BIT6 -- To view, visit https://review.coreboot.org/c/coreboot/+/84098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Gerrit-Change-Number: 84098 Gerrit-PatchSet: 6 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Aug 2024 13:47:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
by Simon Yang (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Simon Yang. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84098?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick ...................................................................... mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick Panel CSOT MNB601LS1-3 will flicker once during enter Chrome login screen, it is because it inserts 12 blank frames if it receives the unmute in VB-ID. Always override the mute in VB-ID to avoid Tcon EC detected the audiomute_flag change. BUG:b=357764688 BRANCH=firmware-nissa-15217.B TEST:Verfied on Anraggar and cannot reproduce the issue Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Signed-off-by: Simon Yang <simon1.yang(a)intel.com> --- M src/mainboard/google/brya/variants/anraggar/variant.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/84098/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/84098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Gerrit-Change-Number: 84098 Gerrit-PatchSet: 6 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
by Subrata Banik (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Simon Yang. Subrata Banik has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/84098?usp=email ) Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick ...................................................................... Patch Set 5: (2 comments) File src/mainboard/google/brya/variants/anraggar/variant.c: https://review.coreboot.org/c/coreboot/+/84098/comment/6b5207da_dddcfd9f?us… : PS5, Line 16: #define TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_RESET (2 << 6) why we need this ? https://review.coreboot.org/c/coreboot/+/84098/comment/ea7d250c_75aed273?us… : PS5, Line 60: graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, (-1 & ~(TRANS_DDI_AUDIO_MUTE_OVERRIDE_MASK)), : TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET); ```graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, ~1, TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET);``` -- To view, visit https://review.coreboot.org/c/coreboot/+/84098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d Gerrit-Change-Number: 84098 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Aug 2024 13:40:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/nivviks: Prevent camera LED blinking during boot
by Dinesh Gehlot (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik, V Sowmya. Dinesh Gehlot has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/84019?usp=email ) Change subject: mb/google/nissa/var/nivviks: Prevent camera LED blinking during boot ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > @digehlot@google.com@google.com can you please test this Code. […] Verified that neither camera LED blinks during boot. Post boot, both cameras work as expected with and without current changes. -- To view, visit https://review.coreboot.org/c/coreboot/+/84019?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I979207d1b6d55f78dea20d3366ef4a833ee9c86d Gerrit-Change-Number: 84019 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 27 Aug 2024 13:39:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024