Attention is currently required from: Evgeny Zinoviev, Felix Singer.
Angel Pons has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83783?usp=email )
Change subject: mb/apple/macbookair4_2/dt: Move iGPU settings into igd device scope
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83783?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3161c7d99a2d94d6c85a6c9652b8e78d3f447252
Gerrit-Change-Number: 83783
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Comment-Date: Tue, 06 Aug 2024 07:41:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Evgeny Zinoviev, Felix Singer.
Angel Pons has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83782?usp=email )
Change subject: mb/apple/macbookair4_2: Clean up devicetree
......................................................................
Patch Set 1: Code-Review+2
(4 comments)
File src/mainboard/apple/macbookair4_2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83782/comment/b214677d_05271612?us… :
PS1, Line 2: register "gfx.did" = "{ 0x80000410, 0x80000320, 0x80000410, 0x80000410, 0x00000005 }"
: register "gfx.ndid" = "2"
For another patch: trim `gfx.did` to size (`gfx.ndid` is 2)
https://review.coreboot.org/c/coreboot/+/83782/comment/6f04c0ad_225fed52?us… :
PS1, Line 36: subsystemid 0x8086 0x7270
For another patch: inherit the subsystemid
https://review.coreboot.org/c/coreboot/+/83782/comment/4f653065_b865aa50?us… :
PS1, Line 63: device ref host_bridge on
: subsystemid 0x106b 0x00eb
: end
: device ref peg10 on
: subsystemid 0x106b 0x00eb
: end
: device ref igd on
: subsystemid 0x106b 0x00eb
: end
For another patch: put northbridge devices "north of" (above) southbridge (PCH) devices
https://review.coreboot.org/c/coreboot/+/83782/comment/d050cc93_610697f8?us… :
PS1, Line 72: device pci 1a.7 on
: subsystemid 0x8086 0x7270
: end
: device pci 1d.7 on
: subsystemid 0x8086 0x7270
: end
For another patch: these are functions of the EHCI controllers, and don't seem to exist when the RMH (Rate Matching Hub) is enabled. So I would remove them.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83782?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07005ae1db7d92fd50e72351031a5eb491768d3e
Gerrit-Change-Number: 83782
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Comment-Date: Tue, 06 Aug 2024 07:40:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Paul Menzel, Xixi Chen.
Yu-Ping Wu has posted comments on this change by Xixi Chen. ( https://review.coreboot.org/c/blobs/+/83748?usp=email )
Change subject: soc/mediatek/mt8186: Update DRAM binary from 0.1.0 to 0.1.1
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/83748?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Id7df502346d590d3cf3827f48d868da021f6ec9d
Gerrit-Change-Number: 83748
Gerrit-PatchSet: 6
Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 06 Aug 2024 07:37:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Paul Menzel, Xixi Chen.
Yu-Ping Wu has posted comments on this change by Xixi Chen. ( https://review.coreboot.org/c/blobs/+/83748?usp=email )
Change subject: soc/mediatek/mt8186: Update DRAM binary from 0.1.0 to 0.1.1
......................................................................
Patch Set 6: Verified+1
--
To view, visit https://review.coreboot.org/c/blobs/+/83748?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Id7df502346d590d3cf3827f48d868da021f6ec9d
Gerrit-Change-Number: 83748
Gerrit-PatchSet: 6
Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 06 Aug 2024 07:37:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Weimin Wu.
Eric Lai has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83724?usp=email )
Change subject: mb/google/dedede/var/awasuki: Add Fn key scancode
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83724?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic7aa183bf314fed4901133dc70d848d84fab0784
Gerrit-Change-Number: 83724
Gerrit-PatchSet: 3
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 06 Aug 2024 06:53:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Karthik Ramasubramanian, Weimin Wu.
Eric Lai has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83704?usp=email )
Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb
Gerrit-Change-Number: 83704
Gerrit-PatchSet: 7
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 06 Aug 2024 06:51:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes