Attention is currently required from: Anil Kumar K, Naveen M.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81920?usp=email
to look at the new patch set (#8).
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
drivers/soundwire: Support Realtek ALC722 codec
This patch adds SoundWire driver to support ALC722 audio codec.
The existing ALC711 codec driver is refactored to include support for
ALC722 device based on config flag.
The ACPI address for the codec is calculated with the information in
the codec driver combined with the devicetree.cb hierarchy where the
link and unique IDs are extracted from the device path.
For example this device is connected to master link ID 0 and has strap
settings configuring it for unique ID 1:
chip drivers/soundwire/alc711
register "desc" = ""Headset Codec""
device generic 0.1 on end
end
reference datasheet: Realtek ALC722-CG ver. 0.56
TEST=This driver was tested on Intel RVP with on board ALC722 codec
by booting and disassembling the runtime SSDT to ensure that the
devices have the expected address and properties. Test soundcard
binding works and devices are detected and check for audio playback
using speaker output.
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
---
M src/drivers/soundwire/alc711/Kconfig
M src/drivers/soundwire/alc711/Makefile.mk
M src/drivers/soundwire/alc711/alc711.c
M src/include/mipi/ids.h
4 files changed, 32 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/81920/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 8
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Naveen M <naveen.m(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-CC: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Naveen M <naveen.m(a)intel.com>
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jack Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, Tyler Wang, YH Lin.
Jérémy Compostella has posted comments on this change by Tyler Wang. ( https://review.coreboot.org/c/coreboot/+/83791?usp=email )
Change subject: mb/google/rex/karis: Set PCIE WLAN bluetooth companion device
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/rex/variants/karis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83791/comment/755832c9_464579b7?us… :
PS1, Line 350: use usb2_port10 as bluetooth_companion
> @Jeremy, more details in b/345373187#comment76 that this is not needed. […]
cf. https://review.coreboot.org/c/coreboot/+/83836
--
To view, visit https://review.coreboot.org/c/coreboot/+/83791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I28541e7a23dd486d3e0ec38ee89e1ab13595fc72
Gerrit-Change-Number: 83791
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jack Lai <jack.lai(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Jack Lai <jack.lai(a)intel.corp-partner.google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 08 Aug 2024 21:50:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: YH Lin <yueherngl(a)google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83836?usp=email
to look at the new patch set (#2).
Change subject: mb/google/rex/karis: Unset CNVI WLAN bluetooth companion device
......................................................................
mb/google/rex/karis: Unset CNVI WLAN bluetooth companion device
CNVI Wifi does not Bluetooth Regulator Domain Settings and therefore,
the bluetooth companion device declaration is unnecessary.
BUG=b:345373187
TEST=Build for karis
Change-Id: I66143ecab27631e7b31922496b1d647508f77a39
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M src/mainboard/google/rex/variants/karis/overridetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/83836/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83836?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I66143ecab27631e7b31922496b1d647508f77a39
Gerrit-Change-Number: 83836
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>