Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83816?usp=email )
Change subject: crossgcc: Upgrade binutils from 2.42 to 2.43
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83816/comment/2dc82e7f_c0f012dd?us… :
PS2, Line 7: [wip]
> Remove that
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83816?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c9d1b2e336894ac48ce87e4d3390e9f9557d4f7
Gerrit-Change-Number: 83816
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Fri, 09 Aug 2024 00:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: yuchi.chen(a)intel.com.
Hello Jérémy Compostella, Shuo Liu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83316?usp=email
to look at the new patch set (#11).
Change subject: soc/intel/common/block/gpio/gpio.c: Improve GPIO debug infos
......................................................................
soc/intel/common/block/gpio/gpio.c: Improve GPIO debug infos
1. print host software ownership, SMI enable and NMI enable registers
after configuring
2. read and print GPIO configuration dword registers after writing
3. use %zu to print size_t values according to CI reporting.
Change-Id: I8820956f6db91c7bcc26b46a4361da3dfa8f77b5
Signed-off-by: Yuchi Chen <yuchi.chen(a)intel.com>
---
M src/soc/intel/common/block/gpio/gpio.c
1 file changed, 28 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/83316/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/83316?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8820956f6db91c7bcc26b46a4361da3dfa8f77b5
Gerrit-Change-Number: 83316
Gerrit-PatchSet: 11
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: yuchi.chen(a)intel.com
Attention is currently required from: Elyes Haouas, Martin L Roth.
Hello Felix Singer, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83816?usp=email
to look at the new patch set (#3).
Change subject: crossgcc: Upgrade binutils from 2.42 to 2.43
......................................................................
crossgcc: Upgrade binutils from 2.42 to 2.43
Change-Id: I1c9d1b2e336894ac48ce87e4d3390e9f9557d4f7
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/binutils-2.43_as-ipxe.patch
R util/crossgcc/patches/binutils-2.43_no-makeinfo.patch
D util/crossgcc/sum/binutils-2.42.tar.xz.cksum
A util/crossgcc/sum/binutils-2.43.tar.xz.cksum
5 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/83816/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83816?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c9d1b2e336894ac48ce87e4d3390e9f9557d4f7
Gerrit-Change-Number: 83816
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Arthur Heymans.
Yu-Ping Wu has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83559?usp=email )
Change subject: Makefile.mk: Remove linker warning on RWX segments
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> Done
CB:83693 fixes ChromiumOS as well. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83559?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1e0f51c69dabaea314ac45924474d446a9ab68f4
Gerrit-Change-Number: 83559
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 09 Aug 2024 00:12:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Jakub Czapiga, Julius Werner, Maximilian Brune.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83830?usp=email )
Change subject: commonlib/bsd: Add strlen() and strnlen() functions
......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/bsd/string.c:
https://review.coreboot.org/c/coreboot/+/83830/comment/ea968074_b4fb3b18?us… :
PS1, Line 12: return len;
> nit: This is probably overthinking it, but I get a shorter loop in assembly with […]
Done
https://review.coreboot.org/c/coreboot/+/83830/comment/c5911bb5_a757906b?us… :
PS1, Line 20: return len;
> Here it would be […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83830?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1203ec9affabe493bd14b46662d212b08240cced
Gerrit-Change-Number: 83830
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Fri, 09 Aug 2024 00:10:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Jakub Czapiga, Julius Werner, Yu-Ping Wu.
Hello Jakub Czapiga, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83765?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+2 by Julius Werner, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: commonlib/bsd: Add strcat() and strncat() functions
......................................................................
commonlib/bsd: Add strcat() and strncat() functions
An upcoming vboot feature [1] will need strcat() to be defined in
string.h. Therefore, add strcat() and strncat() to commonlib/bsd. Remove
those functions from libpayload.
[1] https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_refere…
Change-Id: If02fce0eafb4f6fa01d8bab17d87a32360f4ac83
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
---
M payloads/libpayload/include/string.h
M payloads/libpayload/libc/string.c
M src/commonlib/bsd/include/commonlib/bsd/string.h
M src/commonlib/bsd/string.c
M tests/commonlib/bsd/string-test.c
5 files changed, 99 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/83765/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83765?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If02fce0eafb4f6fa01d8bab17d87a32360f4ac83
Gerrit-Change-Number: 83765
Gerrit-PatchSet: 6
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Jakub Czapiga, Julius Werner, Maximilian Brune, Yu-Ping Wu.
Hello Jakub Czapiga, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83830?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Julius Werner, Verified+1 by build bot (Jenkins)
Change subject: commonlib/bsd: Add strlen() and strnlen() functions
......................................................................
commonlib/bsd: Add strlen() and strnlen() functions
Add strlen() and strnlen() to commonlib/bsd by rewriting them from
scratch, and remove the same functions from coreboot and libpayload.
Note that in the existing libpayload implementation, these functions
return 0 for NULL strings. Given that POSIX doesn't require the NULL
check and that other major libc implementations (e.g. glibc [1]) don't
seem to do that, the new functions also don't perform the NULL check.
[1] https://github.com/bminor/glibc/blob/master/sysdeps/i386/strlen.c
Change-Id: I1203ec9affabe493bd14b46662d212b08240cced
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
---
M payloads/libpayload/include/string.h
M payloads/libpayload/libc/string.c
M src/commonlib/bsd/include/commonlib/bsd/string.h
M src/commonlib/bsd/string.c
M src/include/string.h
M src/lib/string.c
M tests/commonlib/bsd/string-test.c
M tests/lib/string-test.c
8 files changed, 70 insertions(+), 103 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/83830/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83830?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1203ec9affabe493bd14b46662d212b08240cced
Gerrit-Change-Number: 83830
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83816?usp=email )
Change subject: [wip]crossgcc: Upgrade binutils from 2.42 to 2.43
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83816/comment/497cb4d2_a239fa6d?us… :
PS2, Line 7: [wip]
Remove that
--
To view, visit https://review.coreboot.org/c/coreboot/+/83816?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c9d1b2e336894ac48ce87e4d3390e9f9557d4f7
Gerrit-Change-Number: 83816
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 08 Aug 2024 23:40:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Naveen M, Paul Menzel, Subrata Banik.
Anil Kumar K has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/81920?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
Patch Set 8:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81920/comment/c91b55dd_ad04f708?us… :
PS7, Line 32: reference datasheet : Realtek ALC722-CG ver. 0.56
> I’d add it above the TEST= line.
Done
https://review.coreboot.org/c/coreboot/+/81920/comment/e62378bd_4d5df17d?us… :
PS7, Line 32: reference datasheet :
> Remove the space before the colon?
Done
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/81920/comment/da20987a_98c69c43?us… :
PS7, Line 22: #endif
> there should be a else case to handle a scenario where user might have selected DRIVERS_SOUNDWIRE_AL […]
Done
https://review.coreboot.org/c/coreboot/+/81920/comment/b7d3030b_8a73f7ef?us… :
PS7, Line 162: .name = "Realtek ALC722 SoundWire Codec",
> add a else case with "unknown" may be ?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 8
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Naveen M <naveen.m(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-CC: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Naveen M <naveen.m(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 08 Aug 2024 22:58:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>