Attention is currently required from: Elyes Haouas, Felix Singer, Jason Glenesk, Martin L Roth.
Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83005?usp=email )
Change subject: crossgcc: Upgrade LLVM from 18.1.6 to 18.1.8
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83005/comment/31ddca5a_790838f7?us… :
PS6, Line 7: [wip]
> It's a bit late since I usually do some tests before toolchain updates are merged, and during the ti […]
Maybe look into it after OSFC is done?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83005?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id74ba772f105a5c36308b8e1dd803ae50840002b
Gerrit-Change-Number: 83005
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 09 Aug 2024 06:32:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Jérémy Compostella, Maxim, Subrata Banik.
Felix Singer has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83708?usp=email )
Change subject: soc/intel/cml, pci_ids: Fix IDs for UHD 610/630 S/H
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83708/comment/3a3d1dd9_ce21fb98?us… :
PS8, Line 41: Fix the corresponding IDs and remove duplicate entries.
It's not clear to me which of them are duplicates and why they are duplicates. Please add more explanation on that. Also, move this to the top. Otherwise the links are a bit confusing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83708?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab0a03388af3f6fd5d78a597580037889e8ef2
Gerrit-Change-Number: 83708
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Comment-Date: Fri, 09 Aug 2024 06:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Angel Pons, Elyes Haouas, Jason Glenesk, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83005?usp=email )
Change subject: crossgcc: Upgrade LLVM from 18.1.6 to 18.1.8
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83005/comment/2c7d7549_6cf32fdc?us… :
PS6, Line 7: [wip]
> note: 19.1. […]
It's a bit late since I usually do some tests before toolchain updates are merged, and during the time the OSFC takes places. Maybe, let's see. Thanks for mentioning it!
--
To view, visit https://review.coreboot.org/c/coreboot/+/83005?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id74ba772f105a5c36308b8e1dd803ae50840002b
Gerrit-Change-Number: 83005
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 09 Aug 2024 06:20:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Jérémy Compostella, yuchi.chen(a)intel.com.
Shuo Liu has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83319?usp=email )
Change subject: include/device/pci_def.h: Add PCIe SRIOV definitions
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/include/device/pci_def.h:
https://review.coreboot.org/c/coreboot/+/83319/comment/445663de_5707bdbe?us… :
PS10, Line 584: #define PCIE_EXT_CAP_SRIOV_TOTAL_VFS 0x0e
Sorry, forgot to upload this comment yesterday - Can you mention the spec name in comment block and commit message both?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83319?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4bf76b0e3b20e3d04e8264c6530ab4abb95a013
Gerrit-Change-Number: 83319
Gerrit-PatchSet: 11
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Comment-Date: Fri, 09 Aug 2024 06:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes