Attention is currently required from: Maxim.
Michał Żygowski has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/80318?usp=email )
Change subject: util/superiotool/ite: Add extra dumps for IT8613E EC
......................................................................
Patch Set 5:
(1 comment)
File util/superiotool/ite.c:
https://review.coreboot.org/c/coreboot/+/80318/comment/80a1ff48_7a6e49c7?us… :
PS3, Line 1957: /* Special case: IT8613E EC has banks selectable by EC register index 0x06 */
> Why not use an extra-selector? […]
Added extra-selectors
--
To view, visit https://review.coreboot.org/c/coreboot/+/80318?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Gerrit-Change-Number: 80318
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Fri, 09 Aug 2024 08:17:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim <max.senia.poliak(a)gmail.com>
Attention is currently required from: Michał Żygowski.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80318?usp=email
to look at the new patch set (#6).
Change subject: util/superiotool/ite: Add extra dumps for IT8613E EC
......................................................................
util/superiotool/ite: Add extra dumps for IT8613E EC
IT8613E EC space is divided into 3 banks selectable by EC index 0x06
bits 6:5. Bank0 mostly contains the ITE EC registers known by
coreboot's ITE EC driver. Bank1 contains SB_TSI and PECI temperature
reading registers. Bank2, however, contains additional registers used
to select the temperature source reported in TMPIN reading registers,
PECI briodge registers as well as FAN2-5 controls and extra vectors.
Dump the additional banks using extra-selectors.
TEST=Perform the IT8613E dump on Hardkernel ODROID H4+.
Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M util/superiotool/ite.c
1 file changed, 42 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/80318/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/80318?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Gerrit-Change-Number: 80318
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Attention is currently required from: Michał Żygowski.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80318?usp=email
to look at the new patch set (#5).
Change subject: util/superiotool/ite: Add extra dumps for IT8613E EC
......................................................................
util/superiotool/ite: Add extra dumps for IT8613E EC
IT8613E EC space is divided into 3 banks selectable by EC index 0x06
bits 6:5. Bank0 mostly contains the ITE EC registers known by
coreboot's ITE EC driver. Bank1 contains SB_TSI and PECI temperature
reading registers. Bank2, however, contains additional registers used
to select the temperature source reported in TMPIN reading registers,
PECI briodge registers as well as FAN2-5 controls and extra vectors.
Dump the additional banks using extra-selectors.
TEST=Perform the IT8613E dump on Hardkernel ODROID H4+.
Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M util/superiotool/ite.c
1 file changed, 42 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/80318/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/80318?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Gerrit-Change-Number: 80318
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Attention is currently required from: Michał Żygowski.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80318?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/superiotool/ite: Add extra dumps for IT8613E EC
......................................................................
util/superiotool/ite: Add extra dumps for IT8613E EC
IT8613E EC space is divided into 3 banks selectable by EC index 0x06
bits 6:5. Bank0 mostly contains the ITE EC registers known by
coreboot's ITE EC driver. Bank1 contains SB_TSI and PECI temperature
reading registers. Bank2, however, contains additional registers used
to select the temperature source reported in TMPIN reading registers,
PECI briodge registers as well as FAN2-5 controls and extra vectors.
Describe the additional banks as "LDNs" to use generic dump functions
without modifications.
TEST=Perform the IT8613E dump on Hardkernel ODROID H4+.
Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M util/superiotool/ite.c
1 file changed, 42 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/80318/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80318?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Gerrit-Change-Number: 80318
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>