Attention is currently required from: Martin L Roth, Pablo, Paul Menzel.
Nicholas Chin has posted comments on this change by Pablo. ( https://review.coreboot.org/c/coreboot/+/83817?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Documentation: getting-started: faq: Remove line break in URL breaking link
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83817/comment/d29b1292_20e14a07?us… :
PS7, Line 7: Documentation: getting-started: faq:
Usually we use slashes to separate paths. Documentation can be abbreviated to Docs to help keep the subject line shorter:
`Docs/getting-started/faq:`
--
To view, visit https://review.coreboot.org/c/coreboot/+/83817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825
Gerrit-Change-Number: 83817
Gerrit-PatchSet: 7
Gerrit-Owner: Pablo <Pablo(a)Iranzo.io>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pablo <Pablo(a)Iranzo.io>
Gerrit-Comment-Date: Wed, 14 Aug 2024 03:36:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Sean Rhodes.
Elyes Haouas has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83893?usp=email )
Change subject: Revert "mb/starlabs/starbook/adl: Update the VBT"
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83893?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05f9037cd68b8b29e69156e2372a544985f4442e
Gerrit-Change-Number: 83893
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 14 Aug 2024 03:12:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Martin L Roth, Nicholas Chin, Pablo, Paul Menzel.
Elyes Haouas has posted comments on this change by Pablo. ( https://review.coreboot.org/c/coreboot/+/83817?usp=email )
Change subject: Documentation: getting-started: faq: Remove line break in URL breaking link
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File Documentation/getting_started/faq.md:
https://review.coreboot.org/c/coreboot/+/83817/comment/ef0791f5_c2054385?us… :
PS6, Line 87: )
> Remove trailing whitespace please? […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825
Gerrit-Change-Number: 83817
Gerrit-PatchSet: 7
Gerrit-Owner: Pablo <Pablo(a)Iranzo.io>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pablo <Pablo(a)Iranzo.io>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 03:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>