Attention is currently required from: Ashish Kumar Mishra, Nico Huber.
Hello Ashish Kumar Mishra, Nico Huber, Saurabh Mishra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83887?usp=email
to look at the new patch set (#4).
Change subject: Fix no-op for empty arg in Makefile conditional
......................................................................
Fix no-op for empty arg in Makefile conditional
This change addresses an issue where the Makefile failed with the error:
/bin/bash: -c: option requires an argument
make: *** [Makefile.mk:1261: build/coreboot.pre] Error 2
The error was due to an empty third argument `$(3)` in a conditional
`$(if ...)` statement. The original line did not have an explicit no-op
for the case when `$(3)` is empty, leading to an incomplete command.
By adding a colon `:` as a no-op command in the else-part of the `$(if ...)`,
we ensure execution of a harmless command when `$(3)` is empty, preventing
the Makefile from failing due to a missing argument.
This fix ensures compatibility with newer shell environments and prevents
the Makefile from breaking under the specified conditions.
Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Signed-off-by: Manigandan, Balaji <balaji.manigandan(a)intel.com>
---
M Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83887/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 4
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Ashish Kumar Mishra, Nico Huber.
Balaji Manigandan has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile for Bash 5.2.21
......................................................................
Patch Set 3:
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83887/comment/dded2e49_55d379cf?us… :
PS3, Line 992: # non-empty if file removal requested)
> We need to update this comment, as well.
The change is expected to be intuitive as it is part of the if command syntax
--
To view, visit https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 3
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Tue, 13 Aug 2024 17:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Attention is currently required from: Philipp Hug, ron minnich.
Hello Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83873?usp=email
to look at the new patch set (#2).
Change subject: arch/riscv: Remove ram probing
......................................................................
arch/riscv: Remove ram probing
Previously RAM probing was necessary for our QEMU-RISCV target in order
to find the available amount of memory.
Now we get the memory from the devicetree propagated by QEMU, so there
is no reason to keep it anymore.
Tested:
Start QEMU-RISCV and cause an exception to make sure the trap handler
still works.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I9b1e0dc78fc2a66d6085fe99a71245ff46f8e63c
---
M src/arch/riscv/Makefile.mk
M src/arch/riscv/include/arch/exception.h
D src/arch/riscv/ramdetect.c
M src/arch/riscv/trap_handler.c
M src/arch/riscv/trap_util.S
M src/mainboard/emulation/qemu-riscv/Kconfig
M src/mainboard/emulation/qemu-riscv/cbmem.c
7 files changed, 6 insertions(+), 80 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/83873/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83873?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9b1e0dc78fc2a66d6085fe99a71245ff46f8e63c
Gerrit-Change-Number: 83873
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83897?usp=email )
Change subject: mb/google/octopus/var/phaser: Update VBT
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83897?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb48edb4e74f147e3458f845d921a15a2d1906da
Gerrit-Change-Number: 83897
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Tue, 13 Aug 2024 15:59:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Martin L Roth, Nico Huber, Nigel Tao, Paul Menzel.
Felix Singer has posted comments on this change by Nigel Tao. ( https://review.coreboot.org/c/coreboot/+/83895?usp=email )
Change subject: lib/jpeg: avoid calling malloc and free
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83895?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie4c52520cbce498539517c4898ff765365a6beba
Gerrit-Change-Number: 83895
Gerrit-PatchSet: 2
Gerrit-Owner: Nigel Tao <nigeltao(a)golang.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nigel Tao <nigeltao(a)golang.org>
Gerrit-Comment-Date: Tue, 13 Aug 2024 15:49:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nigel Tao.
Felix Singer has posted comments on this change by Nigel Tao. ( https://review.coreboot.org/c/coreboot/+/83894?usp=email )
Change subject: vc/wuffs: upgrade to Wuffs 0.4.0-alpha.8
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83894?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie90d989384e0db2b23d7d1b3d9a57920ac8a95a2
Gerrit-Change-Number: 83894
Gerrit-PatchSet: 1
Gerrit-Owner: Nigel Tao <nigeltao(a)golang.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nigel Tao <nigeltao(a)golang.org>
Gerrit-Comment-Date: Tue, 13 Aug 2024 15:49:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Christian Walter, Martin L Roth, Matt DeVillier.
Hello Christian Walter, Julius Werner, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74856?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: security/tpm: Add Kconfig to allow payload control of TPM1
......................................................................
security/tpm: Add Kconfig to allow payload control of TPM1
Normally, for TPM1, coreboot will force activate/enable the TPM if
TPM_DEACTIVATE is not selected, but this is not desirable in the case
that the payload needs to be able to control activation/deactivation/
take ownership etc. Add a Kconfig to allow opting out of this forced
enablement.
TEST=build/boot google/lulu with edk2, verify TPM can be enabled/
disabled/cleared from payload TPM menu.
Change-Id: Ieb7db109cbcc1a0166d95b6130b624b635bb7ac9
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/security/tpm/Kconfig
M src/security/tpm/tspi/tspi.c
2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/74856/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/74856?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb7db109cbcc1a0166d95b6130b624b635bb7ac9
Gerrit-Change-Number: 74856
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Jamie Ryu, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ravishankar Sarawadi, Saurabh Mishra, Wonkyu Kim.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83789?usp=email )
Change subject: soc/intel/ptl: Add GPIOs for Panther Lake SOC
......................................................................
Patch Set 28:
(6 comments)
File src/soc/intel/pantherlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83789/comment/be5f23fd_0b8b6557?us… :
PS24, Line 261: config SOC_INTEL_ACPI_GPIO_PINCTRL_COMPACT
> when true, only GPP_[group]_[n] pads will be included in pincrtl. Currently, we follow what BIOS is doing, all PADs.
I'd like to know more about the rationale behind making this config true. If I understand your response correctly, this is a new requirement for LNL onwards SoC, so all PTL SOCs should default to enabling this Kconfig. I can't think of any case where we wouldn't want to select this Kconfig, so I'm wondering if we still need to use a Kconfig if the default behavior is true for PTL SoCs.
File src/soc/intel/pantherlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/83789/comment/42955c9f_97b0d6c4?us… :
PS17, Line 38: GPP_ASPIO
> The GPIO group names come from Intel's GPIO HAS document. GPP_ASPI0 contains GPP_A and SPI0 pads. There are 10 SPI0 pads after GPP_A pads in the same group. Please also see the gpio_soc_defs.h for the complete pad list, although most of these non GPP_[group]_[number] pads are not listed in EDS.
Allow me to elaborate.
If you are stating that you have added a comment that says `GPP_ASPIO` because the GPIO bank has both GPP_A and GPP_SPI0, then I am in agreement. However, you must also change line #37 to reflect both GPP_H and GPP_ISH. In that case, the name should be `GPP_HISH`. The same principle applies to lines #31-32 and many other GPIO banks as well.
Therefore, for the sake of simplicity, please only use meaningful GPIO PAD names (and not the native functions ones).
https://review.coreboot.org/c/coreboot/+/83789/comment/ab5af0ea_552e19c1?us… :
PS17, Line 112: GPP_CPUJTAG_H_ASPIO_VGPIO3
> ASPI0 group is the GPP_A plus the SPI0 pads
In the same logic, why did you skip ISH, which is part of GPIO community 3 along with GPP_H? It appears that you are not using a consistent approach that applies to everyone.
https://review.coreboot.org/c/coreboot/+/83789/comment/4506475a_52ef645f?us… :
PS17, Line 177: { PMC_GPP_E, GPP_E },
> will modify the this order accordingly. GPP_A (GPP_ASPI0 internally) was missing and added in EDS recently.
Please refrain from repeating yourself. We can only program GPP_A as GPE, and we will not be able to program SPI0 as GPE. As a result, adding GPP_ASPI0 does not make sense. Please look at EDS vol 2, GPIO section offset 10 (MISC register). I do not see any PAD name as GPP_ASPI0 there.
File src/soc/intel/pantherlake/include/soc/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/83789/comment/9e46d0a9_d39c1066?us… :
PS28, Line 275:
drop one empty line
File src/soc/intel/pantherlake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/c/coreboot/+/83789/comment/4f1799d4_e62dd38c?us… :
PS28, Line 174: /* 48 */
Do you genuinely require these comments? I believe that lines #164 and #171 are sufficient for anyone to comprehend the beginning and end PAS counts. One can simply count from the beginning of the PAD number to determine the index of GPP_F05. I found that the comments made it too unwieldy.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83789?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae1bc072841214efaec7a10719dbc742f2da795b
Gerrit-Change-Number: 83789
Gerrit-PatchSet: 28
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Tue, 13 Aug 2024 15:26:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh(a)intel.com>
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>