Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83817?usp=email )
Change subject: Docs/getting-started/faq: Remove line break in URL breaking link
......................................................................
Docs/getting-started/faq: Remove line break in URL breaking link
Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83817
Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Documentation/getting_started/faq.md
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Felix Singer: Looks good to me, approved
build bot (Jenkins): Verified
Elyes Haouas: Looks good to me, approved
Nicholas Chin: Looks good to me, approved
diff --git a/Documentation/getting_started/faq.md b/Documentation/getting_started/faq.md
index a92c5ca..494fa6b 100644
--- a/Documentation/getting_started/faq.md
+++ b/Documentation/getting_started/faq.md
@@ -84,8 +84,8 @@
* U-boot, depthcharge, FILO, etc.
-There’s [https://doc.coreboot.org/payloads.html](https://doc.coreboot.org/payloads.
-html) with a list, although it’s not complete.
+There’s [https://doc.coreboot.org/payloads.html](https://doc.coreboot.org/payloads.h…
+with a list, although it’s not complete.
### What does coreboot leave in memory after it's done initializing the hardware?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825
Gerrit-Change-Number: 83817
Gerrit-PatchSet: 9
Gerrit-Owner: Pablo <Pablo(a)Iranzo.io>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Martin L Roth, Pablo, Paul Menzel.
Felix Singer has posted comments on this change by Pablo. ( https://review.coreboot.org/c/coreboot/+/83817?usp=email )
Change subject: Docs/getting-started/faq: Remove line break in URL breaking link
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825
Gerrit-Change-Number: 83817
Gerrit-PatchSet: 8
Gerrit-Owner: Pablo <Pablo(a)Iranzo.io>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pablo <Pablo(a)Iranzo.io>
Gerrit-Comment-Date: Wed, 14 Aug 2024 08:19:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Martin L Roth, Pablo, Paul Menzel.
Felix Singer has posted comments on this change by Pablo. ( https://review.coreboot.org/c/coreboot/+/83817?usp=email )
Change subject: Docs/getting-started/faq: Remove line break in URL breaking link
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83817/comment/25c991db_4490990a?us… :
PS7, Line 7: Documentation: getting-started: faq:
> Usually we use slashes to separate paths. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825
Gerrit-Change-Number: 83817
Gerrit-PatchSet: 8
Gerrit-Owner: Pablo <Pablo(a)Iranzo.io>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pablo <Pablo(a)Iranzo.io>
Gerrit-Comment-Date: Wed, 14 Aug 2024 08:19:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Pranava Y N, Saurabh Mishra, Subrata Banik.
Hello Felix Held, Pranava Y N, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83419?usp=email
to look at the new patch set (#89).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
mb/google/fatcat: Add Panther Lake SOC support
Details:
- This patch updates the original google/fatcat support added
with Meteor Lake support as a workaround.
- Adds initial support to build google/fatcat for Panther Lake SOC based
board till bootblock stage.
BUG=b:348678529
TEST=Able to build the google/fatcat and boot to bootblock stage
using Intel® Simics® Pre Silicon Simulation platform for PTL.
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com>
---
M src/mainboard/google/fatcat/Kconfig
M src/mainboard/google/fatcat/mainboard.c
M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb
A src/mainboard/google/fatcat/variants/baseboard/include/baseboard/gpio.h
M src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/fatcat/variants/fatcat/gpio.c
6 files changed, 22 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83419/89
--
To view, visit https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 89
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Martin L Roth, Pablo, Paul Menzel.
Hello Elyes Haouas, Nicholas Chin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83817?usp=email
to look at the new patch set (#8).
Change subject: Docs/getting-started/faq: Remove line break in URL breaking link
......................................................................
Docs/getting-started/faq: Remove line break in URL breaking link
Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo(a)gmail.com>
---
M Documentation/getting_started/faq.md
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/83817/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/83817?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825
Gerrit-Change-Number: 83817
Gerrit-PatchSet: 8
Gerrit-Owner: Pablo <Pablo(a)Iranzo.io>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pablo <Pablo(a)Iranzo.io>
Attention is currently required from: Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Varun Upadhyay.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83898?usp=email )
Change subject: soc/intel/alderlake: Correct ISH partition availability check
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> No need for enable UFS to make ISH worked?
we need for ADL still because of multi functional device dependencies. But what I'm try to solve here is ISH is default enabled for non-ISH SKUs as well where we need to still show ISH version.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83898?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I411e36606c0697f91050af40e0636f7c64810e95
Gerrit-Change-Number: 83898
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Varun Upadhyay <varun.upadhyay(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Varun Upadhyay <varun.upadhyay(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 14 Aug 2024 07:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>