Attention is currently required from: David Wu, Ren Kuo.
Hello David Wu, Ren Kuo, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83935?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brox/jubilant: Update fw_config
......................................................................
mb/google/brox/jubilant: Update fw_config
Change STORAGE_UNPROVISIONED to STORAGE_UNKNOWN depend on depthcharge setting(chromium:5781110).
Change-Id: I4cfd7322c2940862dfbae46e85522715cd7534c1
Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/jubilant/fw_config.c
M src/mainboard/google/brox/variants/jubilant/overridetree.cb
M src/mainboard/google/brox/variants/jubilant/variant.c
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/83935/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83935?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4cfd7322c2940862dfbae46e85522715cd7534c1
Gerrit-Change-Number: 83935
Gerrit-PatchSet: 3
Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Subrata Banik, hualin wei.
Weimin Wu has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/83906?usp=email )
Change subject: mb/google/dedede/var/awasuki: Adjust I2C frequency to less than 400 KHz
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83906?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb75db1dc95ffd5ca806a194ae678c700fa0741c
Gerrit-Change-Number: 83906
Gerrit-PatchSet: 5
Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: hualin wei <weihualin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 01:22:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Ren Kuo.
Morris Hsu has posted comments on this change by Morris Hsu. ( https://review.coreboot.org/c/coreboot/+/83935?usp=email )
Change subject: mb/google/brox/jubilant: Update fw_config
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83935?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4cfd7322c2940862dfbae46e85522715cd7534c1
Gerrit-Change-Number: 83935
Gerrit-PatchSet: 2
Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 01:21:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Subrata Banik, Weimin Wu.
Hello Eric Lai, Karthik Ramasubramanian, Subrata Banik, Weimin Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83906?usp=email
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/awasuki: Adjust I2C frequency to less than 400 KHz
......................................................................
mb/google/dedede/var/awasuki: Adjust I2C frequency to less than 400 KHz
Before:
I2C2 - 431KHz
I2C4 - 413KHz
After:
I2C2 - 364KHz
I2C4 - 370KHz
BUG=b:351968527
TEST=Rate of the actual measured machine is pass.
Change-Id: Ieb75db1dc95ffd5ca806a194ae678c700fa0741c
Signed-off-by: Wei Hualin <weihualin(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/awasuki/overridetree.cb
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/83906/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83906?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb75db1dc95ffd5ca806a194ae678c700fa0741c
Gerrit-Change-Number: 83906
Gerrit-PatchSet: 5
Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Subrata Banik, Weimin Wu.
hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/83906?usp=email )
Change subject: mb/google/dedede/var/awasuki: Adjust I2C frequency to less than 400 KHz
......................................................................
Patch Set 4:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83906?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb75db1dc95ffd5ca806a194ae678c700fa0741c
Gerrit-Change-Number: 83906
Gerrit-PatchSet: 4
Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 01:11:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Morris Hsu.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83935?usp=email
to look at the new patch set (#2).
Change subject: mb/google/brox/jubilant: Update fw_config
......................................................................
mb/google/brox/jubilant: Update fw_config
Change STORAGE_UNPROVISIONED to STORAGE_UNKNOWN due to depthcharge setting.
Change-Id: I4cfd7322c2940862dfbae46e85522715cd7534c1
Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/jubilant/fw_config.c
M src/mainboard/google/brox/variants/jubilant/overridetree.cb
M src/mainboard/google/brox/variants/jubilant/variant.c
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/83935/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83935?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4cfd7322c2940862dfbae46e85522715cd7534c1
Gerrit-Change-Number: 83935
Gerrit-PatchSet: 2
Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Attention is currently required from: Julius Werner.
Yu-Ping Wu has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/83933?usp=email )
Change subject: commonlib/bsd: Optimize strnlen()
......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/bsd/string.c:
https://review.coreboot.org/c/coreboot/+/83933/comment/83010309_030d55a9?us… :
PS1, Line 28: ptr - str
Just `maxlen`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83933?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic36768fd3a26e2b64143904e78cd0b52ba66898d
Gerrit-Change-Number: 83933
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 16 Aug 2024 00:56:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No