Attention is currently required from: Maximilian Brune, Nico Huber.
Hello Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83617?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Nico Huber, Verified+1 by build bot (Jenkins)
Change subject: util/cbfstool/cbfs-payload-linux: Add error handling
......................................................................
util/cbfstool/cbfs-payload-linux: Add error handling
This adds some error handling to the code that adds the input segments
(e.g. kernel, cmdline, initrd...) to the output file.
Currently the compress function can fail and coreboot will still
build "successfully" leaving whoever build coreboot puzzled.
Change-Id: Ie36ad469c73cb3ff9360acc9bbe66c245e8b4a1e
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M util/cbfstool/cbfs-payload-linux.c
1 file changed, 65 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/83617/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83617?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie36ad469c73cb3ff9360acc9bbe66c245e8b4a1e
Gerrit-Change-Number: 83617
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Attention is currently required from: Nicholas Chin.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83978?usp=email )
Change subject: Doc/mb/starlabs/lite_adl.md: Fix embedded rST syntax
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1f16d594af41a13762ba299b8d4f9d88e59c68ed
Gerrit-Change-Number: 83978
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Aug 2024 14:47:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83977?usp=email )
Change subject: Doc/mb/starlabs: Rename starlite_adl.md to lite_adl.md
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
oops.. Sorry, submitted too early.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83977?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1922940fd18cc806d9647cbe05ad11b2a70e0d08
Gerrit-Change-Number: 83977
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 19 Aug 2024 14:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83977?usp=email )
Change subject: Doc/mb/starlabs: Rename starlite_adl.md to lite_adl.md
......................................................................
Doc/mb/starlabs: Rename starlite_adl.md to lite_adl.md
The reference in Doc/mb/index.md was to starlabs/lite_adl.md, whereas
the file was actually named starlite_adl.md. Rename the file to fix the
broken reference and match the naming scheme of the markdown files for
the other StarLite systems.
Change-Id: I1922940fd18cc806d9647cbe05ad11b2a70e0d08
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83977
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
R Documentation/mainboard/starlabs/lite_adl.md
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
Felix Singer: Looks good to me, approved
diff --git a/Documentation/mainboard/starlabs/starlite_adl.md b/Documentation/mainboard/starlabs/lite_adl.md
similarity index 100%
rename from Documentation/mainboard/starlabs/starlite_adl.md
rename to Documentation/mainboard/starlabs/lite_adl.md
--
To view, visit https://review.coreboot.org/c/coreboot/+/83977?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1922940fd18cc806d9647cbe05ad11b2a70e0d08
Gerrit-Change-Number: 83977
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Nicholas Chin.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83977?usp=email )
Change subject: Doc/mb/starlabs: Rename starlite_adl.md to lite_adl.md
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83977?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1922940fd18cc806d9647cbe05ad11b2a70e0d08
Gerrit-Change-Number: 83977
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Aug 2024 14:46:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Held, Nicholas Chin.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83458?usp=email )
Change subject: util/find_usbdebug: Add 8/9 Series PCH rate matching hub IDs
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83458?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52858e2c75e8a3e1424a13bcddc2f5ec1216164b
Gerrit-Change-Number: 83458
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 19 Aug 2024 14:45:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83421?usp=email )
(
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: drivers/efi: add optional ESRT-friendly coreboot table tag
......................................................................
drivers/efi: add optional ESRT-friendly coreboot table tag
EFI System Resource Table (ESRT) is an informational structure that
reports basic details about current system or device firmware. This is
chiefly used to perform firmware updates.
New CONFIG_DRIVERS_EFI_FW_INFO is off by default, enabling it adds
DRIVERS_EFI_FW_{GUID,VERSION,LSV} to be used to specify firmware
version/update information.
Existing forms of versions wouldn't be sufficient because there is no
universal way of converting string versions to 32-bit unsigned integers
and there are no GUIDs or lowest supported versions.
Change-Id: Ic1b768d7bed43edf7ca8e41552087734054de033
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83421
Reviewed-by: Christian Walter <christian.walter(a)9elements.com>
Reviewed-by: coreboot org <coreboot.org(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/commonlib/include/commonlib/coreboot_tables.h
M src/drivers/efi/Kconfig
M src/drivers/efi/Makefile.mk
A src/drivers/efi/info.c
M src/include/boot/coreboot_tables.h
M src/lib/coreboot_table.c
6 files changed, 89 insertions(+), 0 deletions(-)
Approvals:
coreboot org: Looks good to me, approved
Christian Walter: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/commonlib/include/commonlib/coreboot_tables.h b/src/commonlib/include/commonlib/coreboot_tables.h
index 94985b1..a9e14c7 100644
--- a/src/commonlib/include/commonlib/coreboot_tables.h
+++ b/src/commonlib/include/commonlib/coreboot_tables.h
@@ -87,6 +87,7 @@
LB_TAG_TYPE_C_INFO = 0x0042,
LB_TAG_ACPI_RSDP = 0x0043,
LB_TAG_PCIE = 0x0044,
+ LB_TAG_EFI_FW_INFO = 0x0045,
/* The following options are CMOS-related */
LB_TAG_CMOS_OPTION_TABLE = 0x00c8,
LB_TAG_OPTION = 0x00c9,
@@ -578,4 +579,23 @@
lb_uint64_t rsdp_pointer; /* Address of the ACPI RSDP */
};
+/*
+ * Machine-friendly version of a system firmware component. A component is
+ * identified by a GUID. coreboot is an obvious main component but there could
+ * be others (like EC) which should get their own instances of the tag.
+ *
+ * The main consumer of this information is UEFI firmware but something else
+ * could reuse it too.
+ *
+ * Larger number in a version field corresponds to a more recent version.
+ */
+struct lb_efi_fw_info {
+ uint32_t tag;
+ uint32_t size;
+ uint8_t guid[16]; /* Called "firmware class" in UEFI */
+ uint32_t version; /* Current version */
+ uint32_t lowest_supported_version; /* Lowest allowed version for downgrades */
+ uint32_t fw_size; /* Size of firmware in bytes */
+} __packed;
+
#endif
diff --git a/src/drivers/efi/Kconfig b/src/drivers/efi/Kconfig
index ad27d68..399443b 100644
--- a/src/drivers/efi/Kconfig
+++ b/src/drivers/efi/Kconfig
@@ -6,3 +6,35 @@
help
Adds a driver that is able to read and write an EFI formatted
VariableStore as used by tianocore.
+
+config DRIVERS_EFI_FW_INFO
+ bool "Expose firmware version in a EFI-friendly form"
+ depends on UDK_BASE
+ help
+ Adds firmware version information to coreboot table in a form similar to
+ EFI System Resource Table (ESRT) that can be used for firmware updates.
+
+config DRIVERS_EFI_MAIN_FW_GUID
+ string "GUID of the firmware"
+ default "00112233-4455-6677-8899-aabbccddeeff"
+ depends on DRIVERS_EFI_FW_INFO
+ help
+ GUID used to identify firmware kind for the purposes of updates.
+
+config DRIVERS_EFI_MAIN_FW_VERSION
+ hex "Version of the firmware"
+ range 0x00000000 0xFFFFFFFF
+ default 0x00000000
+ depends on DRIVERS_EFI_FW_INFO
+ help
+ 32-bit unsigned integer representing current firmware's version.
+
+config DRIVERS_EFI_MAIN_FW_LSV
+ hex "Lowest supported firmware version"
+ range 0x00000000 0xFFFFFFFF
+ default 0x00000000
+ depends on DRIVERS_EFI_FW_INFO
+ help
+ 32-bit unsigned integer representing lowest firmware version number
+ that is allowed to replace the current one. Can be used to forbid
+ bugged versions.
diff --git a/src/drivers/efi/Makefile.mk b/src/drivers/efi/Makefile.mk
index 2597c09..47f0e82 100644
--- a/src/drivers/efi/Makefile.mk
+++ b/src/drivers/efi/Makefile.mk
@@ -5,3 +5,5 @@
all-$(CONFIG_USE_UEFI_VARIABLE_STORE) += option.c
smm-$(CONFIG_USE_UEFI_VARIABLE_STORE) += option.c
+
+ramstage-$(CONFIG_DRIVERS_EFI_FW_INFO) += info.c
diff --git a/src/drivers/efi/info.c b/src/drivers/efi/info.c
new file mode 100644
index 0000000..fc1cfea
--- /dev/null
+++ b/src/drivers/efi/info.c
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <boot/coreboot_tables.h>
+#include <console/console.h>
+#include <stdint.h>
+#include <string.h>
+#include <uuid.h>
+
+void lb_efi_fw_info(struct lb_header *header)
+{
+ uint8_t guid[16];
+ struct lb_efi_fw_info *fw_info;
+
+ if (parse_uuid(guid, CONFIG_DRIVERS_EFI_MAIN_FW_GUID)) {
+ printk(BIOS_ERR, "%s(): failed to parse firmware's GUID: '%s'\n", __func__,
+ CONFIG_DRIVERS_EFI_MAIN_FW_GUID);
+ return;
+ }
+
+ fw_info = (struct lb_efi_fw_info *)lb_new_record(header);
+ fw_info->tag = LB_TAG_EFI_FW_INFO;
+ fw_info->size = sizeof(*fw_info);
+
+ memcpy(fw_info->guid, guid, sizeof(guid));
+ fw_info->version = CONFIG_DRIVERS_EFI_MAIN_FW_VERSION;
+ fw_info->lowest_supported_version = CONFIG_DRIVERS_EFI_MAIN_FW_LSV;
+ fw_info->fw_size = CONFIG_ROM_SIZE;
+}
diff --git a/src/include/boot/coreboot_tables.h b/src/include/boot/coreboot_tables.h
index e209e4b..a87933d 100644
--- a/src/include/boot/coreboot_tables.h
+++ b/src/include/boot/coreboot_tables.h
@@ -27,6 +27,9 @@
/* Define this in mainboard.c to add board-specific table entries. */
void lb_board(struct lb_header *header);
+/* Adds LB_TAG_EFI_FW_INFO table entry. */
+void lb_efi_fw_info(struct lb_header *header);
+
/* Define this function to fill in the frame buffer returning 0 on success and
< 0 on error. */
int fill_lb_framebuffer(struct lb_framebuffer *framebuffer);
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index d7b6126..913588f 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -536,6 +536,10 @@
if (CONFIG(SMMSTORE_V2))
lb_smmstorev2(head);
+ /* Add information about firmware in form suitable for EFI updates. */
+ if (CONFIG(DRIVERS_EFI_FW_INFO))
+ lb_efi_fw_info(head);
+
/* Add board-specific table entries, if any. */
lb_board(head);
--
To view, visit https://review.coreboot.org/c/coreboot/+/83421?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic1b768d7bed43edf7ca8e41552087734054de033
Gerrit-Change-Number: 83421
Gerrit-PatchSet: 6
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>
Attention is currently required from: Martin Roth, Nicholas Chin.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83973?usp=email )
Change subject: toolchain: Add support for sccache
......................................................................
Patch Set 3:
(3 comments)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83973/comment/ac769a7a_c917c8ae?us… :
PS1, Line 87: sccace
> sccache […]
Done
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/83973/comment/162ddbb0_40f7b86f?us… :
PS1, Line 119: config SCCACHE
> Should this be mutually exclusive with CONFIG_CCACHE? Based on the logic in tookchain. […]
Done
File toolchain.mk:
https://review.coreboot.org/c/coreboot/+/83973/comment/88cc1c5a_9a05d3d4?us… :
PS1, Line 22: ccache
> sccache […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83973?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia28e696dfe9eab0fc73ba8c7c6bdfc90cbdb790e
Gerrit-Change-Number: 83973
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Aug 2024 13:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83978?usp=email )
Change subject: Doc/mb/starlabs/lite_adl.md: Fix embedded rST syntax
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1f16d594af41a13762ba299b8d4f9d88e59c68ed
Gerrit-Change-Number: 83978
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 19 Aug 2024 13:53:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes