Attention is currently required from: Alexander Couzens, Angel Pons, Martin L Roth, Nicholas Chin.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/79025?usp=email )
Change subject: nb/intel/haswell: Move SPD addresses to devicetree
......................................................................
Patch Set 6:
(1 comment)
File src/northbridge/intel/haswell/raminit.h:
https://review.coreboot.org/c/coreboot/+/79025/comment/a1b77c62_0e21a2df?us… :
PS5, Line 19: get_spd_addresses
> Yes, because this function fills in a `struct spd_info`, which contains more than SPD addresses.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79025?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34
Gerrit-Change-Number: 79025
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:14:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>
Attention is currently required from: Alexander Couzens, Keith Hui, Martin L Roth, Nicholas Chin.
Hello Alexander Couzens, Angel Pons, Martin L Roth, Nicholas Chin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79025?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: nb/intel/haswell: Move SPD addresses to devicetree
......................................................................
nb/intel/haswell: Move SPD addresses to devicetree
Introduce a sandybridge-style devicetree setting for SPD addresses,
and use it instead of runtime code in mb_get_spd_map() for all
haswell boards without CONFIG(HAVE_SPD_IN_CBFS) - effectively all
boards except google/slippy.
Patch also covers recently added Z97 boards using Broadwell MRC.
Also update util/autoport to match.
abuild passes for all affected boards.
autoport builds, but otherwise untested.
Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34
Signed-off-by: Keith Hui <buurin(a)gmail.com>
---
M src/mainboard/asrock/b85m_pro4/devicetree.cb
M src/mainboard/asrock/b85m_pro4/romstage.c
M src/mainboard/asrock/fatal1ty_z87_professional/devicetree.cb
M src/mainboard/asrock/fatal1ty_z87_professional/romstage.c
M src/mainboard/asrock/h81m-hds/devicetree.cb
M src/mainboard/asrock/h81m-hds/romstage.c
M src/mainboard/asrock/z87e-itx/devicetree.cb
M src/mainboard/asrock/z87e-itx/romstage.c
M src/mainboard/asrock/z87m_oc_formula/devicetree.cb
M src/mainboard/asrock/z87m_oc_formula/romstage.c
M src/mainboard/asrock/z97_extreme6/devicetree.cb
M src/mainboard/asrock/z97_extreme6/romstage.c
M src/mainboard/asrock/z97e-itx_ac/devicetree.cb
M src/mainboard/asrock/z97e-itx_ac/romstage.c
M src/mainboard/dell/e7240/devicetree.cb
M src/mainboard/dell/e7240/romstage.c
M src/mainboard/dell/optiplex_9020/devicetree.cb
M src/mainboard/dell/optiplex_9020/romstage.c
M src/mainboard/google/beltino/devicetree.cb
M src/mainboard/google/beltino/romstage.c
M src/mainboard/hp/folio_9480m/devicetree.cb
M src/mainboard/hp/folio_9480m/romstage.c
M src/mainboard/intel/baskingridge/devicetree.cb
M src/mainboard/intel/baskingridge/romstage.c
M src/mainboard/lenovo/haswell/romstage.c
M src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
M src/mainboard/lenovo/haswell/variants/t440p/romstage.c
M src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
M src/mainboard/lenovo/haswell/variants/w541/romstage.c
M src/mainboard/msi/h81m-p33/devicetree.cb
M src/mainboard/msi/h81m-p33/romstage.c
M src/mainboard/supermicro/x10slm-f/devicetree.cb
M src/mainboard/supermicro/x10slm-f/romstage.c
M src/northbridge/intel/haswell/Makefile.mk
M src/northbridge/intel/haswell/broadwell_mrc/raminit.c
M src/northbridge/intel/haswell/chip.h
M src/northbridge/intel/haswell/haswell_mrc/raminit.c
M src/northbridge/intel/haswell/native_raminit/spd_bitmunching.c
M src/northbridge/intel/haswell/raminit.h
A src/northbridge/intel/haswell/raminit_shared.c
M util/autoport/haswell.go
M util/autoport/lynxpoint.go
42 files changed, 43 insertions(+), 145 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/79025/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/79025?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34
Gerrit-Change-Number: 79025
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84007?usp=email )
Change subject: libpayload: Use unsigned integet for PDG_MASK
......................................................................
Patch Set 3:
(1 comment)
File payloads/libpayload/arch/arm/virtual.c:
https://review.coreboot.org/c/coreboot/+/84007/comment/d0e6e18e_c4b38df9?us… :
PS3, Line 82: return 1 << PAGE_SHIFT;
> I don't think it is. Shifting a signed but positive integer is defined. […]
That's why I put quotes around "problem" 😛
But yes, I agree with you. I think it'd only be a problem if the result of shifting would overflow an `int`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84007?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4ce64207393ec4a8d6b188b35e0f436342826de
Gerrit-Change-Number: 84007
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:10:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth.
Matt DeVillier has posted comments on this change by Jason Glenesk. ( https://review.coreboot.org/c/coreboot/+/84036?usp=email )
Change subject: Documentation/releases: Add 24.11 release notes template
......................................................................
Patch Set 3:
(1 comment)
File Documentation/releases/index.md:
https://review.coreboot.org/c/coreboot/+/84036/comment/07dd1267_34626760?us… :
PS2, Line 25: 24.08 - August 2024 <coreboot-24.08-relnotes.md>
> nit: Oh no, the alignment! […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84036?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1e524f1db0090bf8815b08315f9cbc9894965af7
Gerrit-Change-Number: 84036
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:09:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84044?usp=email )
Change subject: Makefile.mk: Suppress stack-usage LTO link warning
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> Does clang allow suppressing warnings from within the .c files? I think it's just a single function that requires potentially unbounded stack space.
Yes and this already happens at the compilation step. This is about linking which takes all files at once.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84044?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If08d6d543a4fcff07003af8d1f8dd59ab79f42f8
Gerrit-Change-Number: 84044
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84034?usp=email )
Change subject: documentation/release: Update release checklist
......................................................................
Patch Set 3:
(2 comments)
File Documentation/releases/checklist.md:
https://review.coreboot.org/c/coreboot/+/84034/comment/cd5de5c7_d0223b29?us… :
PS2, Line 76: Freezing
> nit: […]
Done
https://review.coreboot.org/c/coreboot/+/84034/comment/2b5dc062_2f567ba7?us… :
PS2, Line 77: - [ ] Schedule release meetings
> nit: try to be consistent with trailing period?
done?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84034?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id49b3f38d3501382b7fb7ac791190c0cacd58a11
Gerrit-Change-Number: 84034
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Arthur Heymans, Nico Huber.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84056?usp=email )
Change subject: drivers/intel/gma: Fix mismatching types for fb_add_framebuffer_info
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
Patchset:
PS6:
> I don't mind doing this, but want to provide some context / alternatives: […]
100% agree
--
To view, visit https://review.coreboot.org/c/coreboot/+/84056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d5a9a86dbb91a5505891a30c6e9072b1b4dfc92
Gerrit-Change-Number: 84056
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:06:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84044?usp=email )
Change subject: Makefile.mk: Suppress stack-usage LTO link warning
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Patchset:
PS7:
Does clang allow suppressing warnings from within the .c files? I think it's just a single function that requires potentially unbounded stack space.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84044?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If08d6d543a4fcff07003af8d1f8dd59ab79f42f8
Gerrit-Change-Number: 84044
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:05:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84055?usp=email )
Change subject: nb/snb: Fix uninitialised variable
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84055/comment/e20335c9_4d26d223?us… :
PS3, Line 7: nb/snb: Fix unused variable
> Is the error about the variable being unused, or uninitialised? […]
I'd also expand the path to `nb/intel/sandybridge`
--
To view, visit https://review.coreboot.org/c/coreboot/+/84055?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f78b9973729bdedb40bd63b8989e94c9c498814
Gerrit-Change-Number: 84055
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:04:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84049?usp=email )
Change subject: arch/x86/Kconfig: Fix LTO linking
......................................................................
Patch Set 11: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/84049?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a6a5ef9dc6d824fa108681689a69df3faefd3c6
Gerrit-Change-Number: 84049
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:03:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes