Attention is currently required from: Angel Pons, Nico Huber.
Hello Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/83602?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons
Change subject: gma connectors: Add Claim() and Prepare() steps
......................................................................
gma connectors: Add Claim() and Prepare() steps
Claim() ensures that we have a working connection, e.g. when things
need to be muxed for Type-C ports. This is necessary in particular,
before we probe an EDID.
Prepare() will be used to adapt a `Port_Config' to platform quirks.
For instance the FDI usage on Ironlake, USB-C usage on Tiger Lake.
Change-Id: I2fb3ed026077f0371112682b90bea751a28bf994
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/g45/hw-gfx-gma-connectors.adb
M common/haswell_shared/hw-gfx-gma-connectors.adb
M common/hw-gfx-gma-connectors.ads
M common/hw-gfx-gma-display_probing.adb
M common/hw-gfx-gma.adb
M common/ironlake/hw-gfx-gma-connectors.adb
M common/tigerlake/hw-gfx-gma-connectors.adb
7 files changed, 101 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/02/83602/2
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83602?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I2fb3ed026077f0371112682b90bea751a28bf994
Gerrit-Change-Number: 83602
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/c/libgfxinit/+/83604?usp=email )
Change subject: gma config: Introduce `Last_TC_Port'
......................................................................
gma config: Introduce `Last_TC_Port'
Similar to `Last_Digital_Port', note the last Type-C port of the
configured platform. Odd enough, this is at most TC1..TC4 on all
known Tiger Lake SKUs. Even though the TGL PRM refers to six TC
ports.
Change-Id: I0114e4070a20ae4218f41faf750ad59283e5dc3d
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-config.ads.template
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/04/83604/2
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83604?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I0114e4070a20ae4218f41faf750ad59283e5dc3d
Gerrit-Change-Number: 83604
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Angel Pons, Dinesh Gehlot, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#41) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67499?usp=email )
Change subject: gma tgl: Add connector programming
......................................................................
gma tgl: Add connector programming
This patch adds support for enabling displays on both combo PHY ports
and Type-C ports over DP-Alt mode.
Verified eDP, HDMI (not Type-C), and DP Alt mode on google/delbin.
Change-Id: I908e8bef8451d21eecde9ce6defddc2b3df7f738
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-config.ads.template
M common/hw-gfx-gma.adb
M common/hw-gfx-gma.ads
M common/tigerlake/Makefile.inc
A common/tigerlake/hw-gfx-gma-connectors-combo_phy.adb
A common/tigerlake/hw-gfx-gma-connectors-combo_phy.ads
A common/tigerlake/hw-gfx-gma-connectors-tc.adb
A common/tigerlake/hw-gfx-gma-connectors-tc.ads
M common/tigerlake/hw-gfx-gma-connectors.adb
M common/tigerlake/hw-gfx-gma-power_and_clocks.adb
10 files changed, 1,707 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/99/67499/41
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67499?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I908e8bef8451d21eecde9ce6defddc2b3df7f738
Gerrit-Change-Number: 67499
Gerrit-PatchSet: 41
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Subrata Banik.
Hello Felix Held, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83419?usp=email
to look at the new patch set (#6).
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
mb/google/fatcat: Add Panther Lake SOC support
Details:
- This patch updates the orignal google/fatcat support added
with Meteor Lake support as a workaround.
- Adds initial support to build google/fatcat for Panther Lake SOC based
board till bootblock stage.
BUG=b:348678529
TEST=Able to build the google/fatcat and boot to bootblock stage
using Intel® Simics® Pre Silicon Simulation platform for PTL.
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com>
---
M src/mainboard/google/fatcat/Kconfig
M src/mainboard/google/fatcat/mainboard.c
M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb
M src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83419/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 6
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Subrata Banik.
Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
Patch Set 4:
(5 comments)
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/83419/comment/029a4439_fc252b76?us… :
PS4, Line 29: SOC_INTEL_IOE_DIE_SUPPORT
> we should keep this to ensure P2SB#2 support exists
Acknowledged
https://review.coreboot.org/c/coreboot/+/83419/comment/afff6cc0_61e18865?us… :
PS4, Line 13: if !SIMICS_ENV
> please drop the simics support. […]
Sure. Dropping Simics support for Fatcat.
https://review.coreboot.org/c/coreboot/+/83419/comment/04660a40_efe8392f?us… :
PS4, Line 16: DRIVERS_UART_8250IO
> this is non-POR for chrome board
Acknowledged
https://review.coreboot.org/c/coreboot/+/83419/comment/cc7bc184_62e24c3e?us… :
PS4, Line 30: SOC_INTEL_PANTHERLAKE_A0
> SOC_INTEL_PANTHERLAKE_U_H
Acknowledged
https://review.coreboot.org/c/coreboot/+/83419/comment/73eaa643_07fbdb2c?us… :
PS4, Line 108: config SIMICS_ENV
: default y
:
> drop this as we don't need, plus the Kconfig implementation itself is not correct […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 23 Jul 2024 12:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Saurabh Mishra.
Hello Felix Held, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83419?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
mb/google/fatcat: Add Panther Lake SOC support
Details:
- This patch updates the orignal google/fatcat support added
with Meteor Lake support as a workaround.
- Adds initial support to build google/fatcat for Panther Lake SOC based
board till bootblock stage.
- Add support for Simics using config SIMICS_ENV.
BUG=b:348678529
TEST=Able to build the google/fatcat and boot to bootblock stage
using Intel® Simics® Pre Silicon Simulation platform for PTL.
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com>
---
M src/mainboard/google/fatcat/Kconfig
M src/mainboard/google/fatcat/mainboard.c
M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb
M src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83419/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>