Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83605?usp=email )
Change subject: mb/google/dedede/var/galtic: Group fw_config fields together
......................................................................
mb/google/dedede/var/galtic: Group fw_config fields together
No need to have separate sections, and will be cleaner when adding
another section in a subsequent patch.
Change-Id: I4ad6be9dd67b5adbc9c5b0fcab51ce0c54351173
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83605
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/galtic/overridetree.cb
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/galtic/overridetree.cb b/src/mainboard/google/dedede/variants/galtic/overridetree.cb
index 7eb059d..51d5a7a 100644
--- a/src/mainboard/google/dedede/variants/galtic/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/galtic/overridetree.cb
@@ -4,9 +4,6 @@
option TOUCHSCREEN_ELAN1001 1
option TOUCHSCREEN_ELAN9008 2
end
-end
-
-fw_config
field AUDIO_CODEC_SOURCE 41 43
option AUDIO_CODEC_UNPROVISIONED 0
option AUDIO_CODEC_ALC5682 1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83605?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ad6be9dd67b5adbc9c5b0fcab51ce0c54351173
Gerrit-Change-Number: 83605
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak.
Angel Pons has posted comments on this change by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email )
Change subject: gma pipe_setup: Update for TGL & ADL
......................................................................
Patch Set 35:
(1 comment)
File common/hw-gfx-gma-pipe_setup.adb:
https://review.coreboot.org/c/libgfxinit/+/67494/comment/0ecdc807_b45df464?… :
PS32, Line 354: if Config.Has_New_Mbus_Dbox_Credits then
> I doubt we have that. I couldn't find much about it, but it's something that i915 […]
Hmmm, yeah, seems like it's for hi-BW situations. I don't mind, choose whichever approach works best for you.
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67494?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3
Gerrit-Change-Number: 67494
Gerrit-PatchSet: 35
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 23 Jul 2024 17:53:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/83599?usp=email )
Change subject: gma: Re-structure TC port types
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/83599/comment/55d2b6b0_09ae020d?… :
PS2, Line 20: sets only. Hence we keep only 4 respective TC ports for now.
For reference: TGL and ADL-S seem to have up to 6 sets of TC registers, but only 4 of them are used. ADL-P (XeLPD) only has 4 sets of TC registers.
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83599?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: If9755fe8e1f9252e6e77e22fe910964ad3c3743b
Gerrit-Change-Number: 83599
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Tue, 23 Jul 2024 17:47:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Paul Menzel, yuchi.chen(a)intel.com.
Jérémy Compostella has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83192?usp=email )
Change subject: vc/intel/fsp/fsp2_0/snowridge: Add FSP headers for Snow Ridge SoC
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83192?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I333b137c1dc08a3c06bdd3f7a78ca44a5dd043cc
Gerrit-Change-Number: 83192
Gerrit-PatchSet: 6
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 17:10:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes