Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83624?usp=email )
Change subject: mb/starlabs/starbook/rpl: Disconnect SCI/SMI GPIOs
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83624?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I81470658263f4b601c9964ff5bed86b22d24df3b
Gerrit-Change-Number: 83624
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 23 Jul 2024 20:06:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83623?usp=email )
Change subject: mb/starlabs/starbook/rpl: Add USB ACPi to devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83623?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iab8b6e03c8c05e459fb354bc008109c873a4846f
Gerrit-Change-Number: 83623
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 23 Jul 2024 20:06:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83622?usp=email )
Change subject: mb/starlabs/starbook/rpl: Merge and alphabetise FSP UPDs
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83622?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c4a963b233f549c7a76c76333af87c887550ac3
Gerrit-Change-Number: 83622
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 23 Jul 2024 20:06:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83621?usp=email )
Change subject: mb/starlabs/*: Add the subsystem ids for HDA
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83621?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I01b36554d5322018efc72734a8e749cc06263577
Gerrit-Change-Number: 83621
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 20:06:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83620?usp=email )
Change subject: mb/starlabs/starbook/rpl: Don't set tcss_aux_ori
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83620?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0e90179dd05b23f1f36935be51327250c5a8684
Gerrit-Change-Number: 83620
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 23 Jul 2024 20:06:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83619?usp=email )
Change subject: ec/starlabs/merlin: Improve accuracy of RSOC
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83619?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I974cad3af4e1f86ae58e90c68db463fc436223af
Gerrit-Change-Number: 83619
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 23 Jul 2024 19:32:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83619?usp=email )
Change subject: ec/starlabs/merlin: Improve accuracy of RSOC
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83619?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I974cad3af4e1f86ae58e90c68db463fc436223af
Gerrit-Change-Number: 83619
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 23 Jul 2024 19:17:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Andrey Petrov, Sean Rhodes.
Hello Andrey Petrov, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66103?usp=email
to look at the new patch set (#13).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/apollolake: Add the Kconfig options for IFWI Boot Profile
......................................................................
soc/intel/apollolake: Add the Kconfig options for IFWI Boot Profile
The Boot Profile for use with the IFWI Boot Flow. The selected profile
should be equal to or higher than the one configured in IFWI.
No Profile
Since its inception, coreboot has ignored the Boot Flow designed by
Intel; this only uses an IBB and OBB. Neither are measured or verified
and mapped without assistance.
Legacy
Profile 0 is for platforms that do not wish to enable Boot Guard boot
block verification or measurement enforcement.
Verified
Profile 1 is strict Verification enforcement. It prevents unverified
BIOS components from running.
Verified and Measured
Boot Guard Profile 2 is strict Verification and Measurement
enforcement; this prevents unverified BIOS components from running.
Upon manufacturing completion, this value is burned into an FPF
and is permanent. This setting is only configurable when OEM signing
is enabled.
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I83d2fd134e1a893766f625fe2e2ddd81d48f9f8a
---
M src/soc/intel/apollolake/Kconfig
1 file changed, 84 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/66103/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/66103?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I83d2fd134e1a893766f625fe2e2ddd81d48f9f8a
Gerrit-Change-Number: 66103
Gerrit-PatchSet: 13
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Attention is currently required from: Andrey Petrov, Arthur Heymans, Sean Rhodes.
Hello Andrey Petrov, Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/65272?usp=email
to look at the new patch set (#51).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/apollolake: Add support for IFWI Measured Boot
......................................................................
soc/intel/apollolake: Add support for IFWI Measured Boot
Add Measureed Boot that is specific to Apollolake, and is used
for measuring the IBBL, IBB and TXE. The IBB is measured only if it
exists, and only after it has been loaded into the CSE.
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I61ce4a34875d6d3357d4088167cdd887bafdff23
---
M src/soc/intel/apollolake/Makefile.mk
A src/soc/intel/apollolake/include/soc/fit.h
A src/soc/intel/apollolake/include/soc/measured_boot.h
A src/soc/intel/apollolake/measured_boot.c
4 files changed, 174 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/65272/51
--
To view, visit https://review.coreboot.org/c/coreboot/+/65272?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I61ce4a34875d6d3357d4088167cdd887bafdff23
Gerrit-Change-Number: 65272
Gerrit-PatchSet: 51
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>