coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XS] Change in coreboot[main]: Makefile.mk: Move recently introduced warning options to xcompile
by Uwe Poeche (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Felix Singer, Martin L Roth. Uwe Poeche has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83306?usp=email ) Change subject: Makefile.mk: Move recently introduced warning options to xcompile ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Thanks Felix, exact this I tried successfully (for the cflag -Walloc-size which made problems on our side) before I wrote my comment in CB:82734. I was not shure if I should send the commit... -- To view, visit https://review.coreboot.org/c/coreboot/+/83306?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibadcd22f99703ced700a1b671e7696255ecf9e71 Gerrit-Change-Number: 83306 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:40:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Makefile.mk: Move recently introduced warning options to xcompile
by Felix Singer (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Martin L Roth, Uwe Poeche. Hello Martin L Roth, Uwe Poeche, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83306?usp=email to look at the new patch set (#3). Change subject: Makefile.mk: Move recently introduced warning options to xcompile ...................................................................... Makefile.mk: Move recently introduced warning options to xcompile -Walloc-size was introduced with GCC 14 and -Wcast-function-type with GCC 8, which is still shipped by some distros with LTS support. In order to be backwards compatible to older GCC versions, move these options to xcompile, which only applies them if the GCC version supports it. Change-Id: Ibadcd22f99703ced700a1b671e7696255ecf9e71 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Makefile.mk M util/xcompile/xcompile 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/83306/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83306?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibadcd22f99703ced700a1b671e7696255ecf9e71 Gerrit-Change-Number: 83306 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Uwe Poeche <uwe.poeche(a)siemens.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z97E-ITX/ac (Haswell/Broadwell)
by Nicholas Chin (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Angel Pons, Jan Philipp Groß, Máté Kukri. Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82760?usp=email ) Change subject: mb/asrock: Add Z97E-ITX/ac (Haswell/Broadwell) ...................................................................... Patch Set 15: Code-Review+2 (2 comments) File src/mainboard/asrock/z97e-itx_ac/Kconfig: https://review.coreboot.org/c/coreboot/+/82760/comment/c1ccce99_4a8f83f0?us… : PS14, Line 1: if BOARD_ASROCK_Z97E_ITX_AC > Add SPDX header […] Fix applied. File src/mainboard/asrock/z97e-itx_ac/hda_verb.c: https://review.coreboot.org/c/coreboot/+/82760/comment/fa63eb02_c1e04888?us… : PS14, Line 14: 0x411111f0 > ```suggestion […] Fix applied. -- To view, visit https://review.coreboot.org/c/coreboot/+/82760?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3b940e9281814e8360900221714c0dfa3ae39540 Gerrit-Change-Number: 82760 Gerrit-PatchSet: 15 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:14:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87M OC Formula (Haswell)
by Nicholas Chin (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Angel Pons, Felix Singer, Jan Philipp Groß, Máté Kukri. Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82906?usp=email ) Change subject: mb/asrock: Add Z87M OC Formula (Haswell) ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaa156b34ed65e66dd5de5a26010409999a5f8746 Gerrit-Change-Number: 82906 Gerrit-PatchSet: 12 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:13:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/asrock: Add Fatal1ty Z87 Professional (Haswell)
by Nicholas Chin (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Angel Pons, Felix Singer, Jan Philipp Groß, Máté Kukri, Paul Menzel. Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82913?usp=email ) Change subject: mb/asrock: Add Fatal1ty Z87 Professional (Haswell) ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82913?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae0b73d8e81be90ec3a2d5463df3ed170f603266 Gerrit-Change-Number: 82913 Gerrit-PatchSet: 9 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:13:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Walloc-size GCC option
by Felix Singer (Code Review) 02 Jul '24

02 Jul '24

Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82734?usp=email ) Change subject: Makefile.mk: Use Walloc-size GCC option ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Actually we use on our build system ggc 13.2.0. […] Sorry for that. I should have looked more closely. I've created CB:83306 moving them to xcompile. @ehaouas@noos.fr, please add new options to xcompile from now on until we decide how far backwards compatible we want to be. -- To view, visit https://review.coreboot.org/c/coreboot/+/82734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia26dcf097db125a5a734660d08d875459179241b Gerrit-Change-Number: 82734 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:11:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Uwe Poeche <uwe.poeche(a)siemens.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Move recently introduced warning options to xcompile
by Felix Singer (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Martin L Roth. Hello Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83306?usp=email to look at the new patch set (#2). Change subject: Makefile.mk: Move recently introduced warning options to xcompile ...................................................................... Makefile.mk: Move recently introduced warning options to xcompile -Walloc-size was introduced with GCC 14 and -Wcast-function-type with GCC 8, which is still shipped by some distros with LTS support. In order to be backwards compatible to these GCC versions, move these options to xcompile, which only applies them if the GCC version supports it. Change-Id: Ibadcd22f99703ced700a1b671e7696255ecf9e71 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Makefile.mk M util/xcompile/xcompile 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/83306/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83306?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibadcd22f99703ced700a1b671e7696255ecf9e71 Gerrit-Change-Number: 83306 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Move recently introduced warning options to xcompile
by Felix Singer (Code Review) 02 Jul '24

02 Jul '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83306?usp=email ) Change subject: Makefile.mk: Move recently introduced warning options to xcompile ...................................................................... Makefile.mk: Move recently introduced warning options to xcompile -Walloc-size was introduced with GCC 14 and -Wcast-function-type with GCC 8, which is still shipped by some distros with LTS support. In order to be backwards compatible to these GCC versions, move them to xcompile, which only applies them if the GCC version supports it. Change-Id: Ibadcd22f99703ced700a1b671e7696255ecf9e71 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Makefile.mk M util/xcompile/xcompile 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/83306/1 diff --git a/Makefile.mk b/Makefile.mk index a16089d..1b658b5 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -528,8 +528,6 @@ CFLAGS_common += -Wstring-compare ifeq ($(CONFIG_COMPILER_GCC),y) CFLAGS_common += -Wold-style-declaration -CFLAGS_common += -Walloc-size -CFLAGS_common += -Wcast-function-type # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) CFLAGS_common += -Wno-packed-not-aligned diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index ff067d2..a7be0c7 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -208,6 +208,12 @@ testcc "$GCC" "$CFLAGS_GCC -Wcalloc-transposed-args" && CFLAGS_GCC="$CFLAGS_GCC -Wcalloc-transposed-args" + testcc "$GCC" "$CFLAGS_GCC -Walloc-size" && + CFLAGS_GCC="$CFLAGS_GCC -Walloc-size" + + testcc "$GCC" "$CFLAGS_GCC -Wcast-function-type" && + CFLAGS_GCC="$CFLAGS_GCC -Wcast-function-type" + case "$architecture" in x86) ;; -- To view, visit https://review.coreboot.org/c/coreboot/+/83306?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibadcd22f99703ced700a1b671e7696255ecf9e71 Gerrit-Change-Number: 83306 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87M OC Formula (Haswell)
by Jan Philipp Groß (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Angel Pons, Felix Singer, Máté Kukri, Nicholas Chin. Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82906?usp=email ) Change subject: mb/asrock: Add Z87M OC Formula (Haswell) ...................................................................... Patch Set 12: (1 comment) File src/mainboard/asrock/z87m_oc_formula/hda_verb.c: https://review.coreboot.org/c/coreboot/+/82906/comment/1f6190fb_8a4d2478?us… : PS11, Line 14: 0x411111f0 > This macro means the same thing as that raw hex value. […] Fix applied. -- To view, visit https://review.coreboot.org/c/coreboot/+/82906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaa156b34ed65e66dd5de5a26010409999a5f8746 Gerrit-Change-Number: 82906 Gerrit-PatchSet: 12 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:05:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Fatal1ty Z87 Professional (Haswell)
by Jan Philipp Groß (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Angel Pons, Felix Singer, Máté Kukri, Nicholas Chin, Paul Menzel. Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82913?usp=email ) Change subject: mb/asrock: Add Fatal1ty Z87 Professional (Haswell) ...................................................................... Patch Set 9: (4 comments) File src/mainboard/asrock/fatal1ty_z87_professional/Kconfig: https://review.coreboot.org/c/coreboot/+/82913/comment/9182a623_fd01d9e7?us… : PS8, Line 1: if BOARD_ASROCK_FATAL1TY_Z87_PROFESSIONAL > Add SPDX header […] Fix applied. File src/mainboard/asrock/fatal1ty_z87_professional/Kconfig.name: https://review.coreboot.org/c/coreboot/+/82913/comment/1b55144e_0d275ea9?us… : PS8, Line 1: config BOARD_ASROCK_FATAL1TY_Z87_PROFESSIONAL > Add SPDX header […] Fix applied. File src/mainboard/asrock/fatal1ty_z87_professional/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/82913/comment/2fb90315_7c344d2a?us… : PS8, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ > ```suggestion […] Fix applied. File src/mainboard/asrock/fatal1ty_z87_professional/acpi/superio.asl: https://review.coreboot.org/c/coreboot/+/82913/comment/a5f17a16_8883e8bb?us… : PS8, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ > ```suggestion […] Fix applied. -- To view, visit https://review.coreboot.org/c/coreboot/+/82913?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae0b73d8e81be90ec3a2d5463df3ed170f603266 Gerrit-Change-Number: 82913 Gerrit-PatchSet: 9 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:04:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024