coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[M] Change in coreboot[main]: drivers/wifi: Support Bluetooth Regulator Domain Settings
by Jérémy Compostella (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Eric Lai, Subrata Banik, dinesh.sharma(a)intel.com. Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83200?usp=email ) Change subject: drivers/wifi: Support Bluetooth Regulator Domain Settings ...................................................................... Patch Set 9: (2 comments) File src/drivers/wifi/generic/acpi.c: https://review.coreboot.org/c/coreboot/+/83200/comment/4acb52bc_264f80b5?us… : PS9, Line 493: bsar > why we have skipped the NULL check ? Because it can't be NULL as the variable is on the stack. https://review.coreboot.org/c/coreboot/+/83200/comment/b5119dce_a11b9868?us… : PS9, Line 684: if (path) { > nit: please add a comment here to say, which device is this. I am not sure I understand you comment. Do you mean add C code comment like the one on line 681 or do you mean print the path as a debug message ? -- To view, visit https://review.coreboot.org/c/coreboot/+/83200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209 Gerrit-Change-Number: 83200 Gerrit-PatchSet: 9 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dinesh.sharma(a)intel.com Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: dinesh.sharma(a)intel.com Gerrit-Comment-Date: Tue, 02 Jul 2024 16:15:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: ec/system76/ec: Remove RPM calculation
by Tim Crawford (Code Review) 02 Jul '24

02 Jul '24

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83308?usp=email ) Change subject: ec/system76/ec: Remove RPM calculation ...................................................................... ec/system76/ec: Remove RPM calculation System76 EC since system76/ec#456 performs the RPM calculation itself and stores it in EC RAM where previously the raw tachometer values were saved. The SBIOS is no longer required to make the conversion. Ref: https://github.com/system76/ec/pull/456 Change-Id: I82a4e25a8ce0f274b2d98e7ff2b12595acf6c3c5 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/ec/system76/ec/acpi/s76.asl 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/83308/1 diff --git a/src/ec/system76/ec/acpi/s76.asl b/src/ec/system76/ec/acpi/s76.asl index 329c5d3..06000a4 100644 --- a/src/ec/system76/ec/acpi/s76.asl +++ b/src/ec/system76/ec/acpi/s76.asl @@ -146,10 +146,6 @@ Local1 = ^^PCI0.LPCB.EC0.RPM2 } } - If (Local1 != 0) { - // 60 * (EC frequency / 120) / 2 - Local1 = 2156250 / Local1 - } Return ((Local1 << 8) | Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/83308?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I82a4e25a8ce0f274b2d98e7ff2b12595acf6c3c5 Gerrit-Change-Number: 83308 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>

1 0

[XS] Change in coreboot[main]: tests/drivers/efivars: Remove duplicated <limits.h>
by Elyes Haouas (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Jakub Czapiga. Hello Jakub Czapiga, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82724?usp=email to look at the new patch set (#2). Change subject: tests/drivers/efivars: Remove duplicated <limits.h> ...................................................................... tests/drivers/efivars: Remove duplicated <limits.h> Already included <types.h> is supposed to provide <limits.h>. See `Documentation/contributing/coding_style.md` section `Headers and includes` Change-Id: I945eeeeccb16851f64d85cf5c67ea6e256082e11 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M tests/drivers/efivars.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/82724/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I945eeeeccb16851f64d85cf5c67ea6e256082e11 Gerrit-Change-Number: 82724 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>

1 0

[XS] Change in coreboot[main]: tree: Remove duplicated <arch/mmio.h>
by Elyes Haouas (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Philipp Hug, Ron Minnich. Hello Philipp Hug, Ron Minnich, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82693?usp=email to look at the new patch set (#3). Change subject: tree: Remove duplicated <arch/mmio.h> ...................................................................... tree: Remove duplicated <arch/mmio.h> <device/mmio.h> is supposed to chain-include <arch/mmio.h>. See `Documentation/contributing/coding_style.md` section `Headers and includes` Change-Id: I08f7480650b42df1613994146a026bd1e12dbf66 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/sifive/fu740/gpio.c M src/soc/sifive/fu740/sdram.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/82693/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I08f7480650b42df1613994146a026bd1e12dbf66 Gerrit-Change-Number: 82693 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Temporarily silence git-commit-clangfmt
by Elyes Haouas (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Arthur Heymans, Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83289?usp=email ) Change subject: Makefile.mk: Temporarily silence git-commit-clangfmt ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83289/comment/e96e49e8_30e60cb0?us… : PS1, Line 8: > Please explain why. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/83289?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d3e6e213ba08fb0699c309e064f585e66d985c7 Gerrit-Change-Number: 83289 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 02 Jul 2024 15:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Temporarily silence git-commit-clangfmt
by Elyes Haouas (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Arthur Heymans, Elyes Haouas, Martin L Roth. Hello Arthur Heymans, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83289?usp=email to look at the new patch set (#2). Change subject: Makefile.mk: Temporarily silence git-commit-clangfmt ...................................................................... Makefile.mk: Temporarily silence git-commit-clangfmt "git-commit-clangfmt" displays a long unnecessary message on the console since "clang-format" is not yet mature for use. Change-Id: I8d3e6e213ba08fb0699c309e064f585e66d985c7 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/83289/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83289?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d3e6e213ba08fb0699c309e064f585e66d985c7 Gerrit-Change-Number: 83289 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Temporarily silence clang-format
by Felix Singer (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Arthur Heymans, Elyes Haouas, Martin L Roth. Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83289?usp=email ) Change subject: Makefile.mk: Temporarily silence clang-format ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83289/comment/e1f66f9b_58e995d7?us… : PS1, Line 8: Please explain why. -- To view, visit https://review.coreboot.org/c/coreboot/+/83289?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d3e6e213ba08fb0699c309e064f585e66d985c7 Gerrit-Change-Number: 83289 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 02 Jul 2024 15:31:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Makefile.mk: Move recently introduced warning options to xcompile
by Felix Singer (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Martin L Roth, Uwe Poeche. Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83306?usp=email ) Change subject: Makefile.mk: Move recently introduced warning options to xcompile ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > Thanks Felix, exact this I tried successfully (for the cflag -Walloc-size which made problems on our […] No worries. I think there is no problem with just sending patches :) PS3: Looks like some other parts needs to be adjusted. I will look at the issues this evening. -- To view, visit https://review.coreboot.org/c/coreboot/+/83306?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibadcd22f99703ced700a1b671e7696255ecf9e71 Gerrit-Change-Number: 83306 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 15:28:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Uwe Poeche <uwe.poeche(a)siemens.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Fatal1ty Z87 Professional (Haswell)
by Felix Singer (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Jan Philipp Groß, Máté Kukri, Paul Menzel. Felix Singer has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82913?usp=email ) Change subject: mb/asrock: Add Fatal1ty Z87 Professional (Haswell) ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82913?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae0b73d8e81be90ec3a2d5463df3ed170f603266 Gerrit-Change-Number: 82913 Gerrit-PatchSet: 9 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 15:16:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87M OC Formula (Haswell)
by Angel Pons (Code Review) 02 Jul '24

02 Jul '24

Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82906?usp=email ) Change subject: mb/asrock: Add Z87M OC Formula (Haswell) ...................................................................... Patch Set 13: Code-Review+2 (1 comment) File src/mainboard/asrock/z87m_oc_formula/bootblock.c: https://review.coreboot.org/c/coreboot/+/82906/comment/6840917f_5864df4e?us… : PS13, Line 7: { I never got around to looking into this -- To view, visit https://review.coreboot.org/c/coreboot/+/82906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaa156b34ed65e66dd5de5a26010409999a5f8746 Gerrit-Change-Number: 82906 Gerrit-PatchSet: 13 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 15:13:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024