Attention is currently required from: Elyes Haouas.
Nicholas Chin has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83387?usp=email )
Change subject: Documentation/community/forums.md: Workaround for "ircs" link
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Maybe look into https://myst-parser.readthedocs.io/en/latest/syntax/cross-referencing. […]
Adding additional protocols using `myst_url_schemes` in `conf.py` is probably the cleanest option as it avoids requiring additional markup to be added to the documentation pages themselves
--
To view, visit https://review.coreboot.org/c/coreboot/+/83387?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief55fd353ca86eb91be14acedbe88462ef3c40e1
Gerrit-Change-Number: 83387
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 09 Jul 2024 13:24:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Elyes Haouas.
Nicholas Chin has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83387?usp=email )
Change subject: Documentation/community/forums.md: Workaround for "ircs" link
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Maybe look into https://myst-parser.readthedocs.io/en/latest/syntax/cross-referencing.html#… It seems like by default MyST only recognizes http, https, ftp, and mailto, but it seems like you can either add additional schemes or mark links using other protocols as external links using an extension. Both of these would require modifications to `Documentation/conf.py`
PS1:
> 2nd solution is to use "https://web.libera.chat/" link , but here the chat room is missing. […]
It seems like you can add the channel to a libera web chat link: https://web.libera.chat/#coreboothttps://libera.chat/guides/webchat#kiwiirc
--
To view, visit https://review.coreboot.org/c/coreboot/+/83387?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief55fd353ca86eb91be14acedbe88462ef3c40e1
Gerrit-Change-Number: 83387
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 09 Jul 2024 13:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Nicholas Chin.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83387?usp=email )
Change subject: Documentation/community/forums.md: Workaround for "ircs" link
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
2nd solution is to use "https://web.libera.chat/" link , but here the chat room is missing.
Thx
--
To view, visit https://review.coreboot.org/c/coreboot/+/83387?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief55fd353ca86eb91be14acedbe88462ef3c40e1
Gerrit-Change-Number: 83387
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Tue, 09 Jul 2024 12:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Martin L Roth, Nico Huber.
Elyes Haouas has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82764?usp=email )
Change subject: sconfig: Provide simple constants for aliased devices
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/82764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d1cfe12b1e7309f8235c84dd220bd090ebfe1b5
Gerrit-Change-Number: 82764
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Tue, 09 Jul 2024 12:38:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Wentao Qin has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/83388?usp=email )
Change subject: mb/google/brox/var/lotso: Add FW_CONFIG for FP
......................................................................
mb/google/brox/var/lotso: Add FW_CONFIG for FP
This patch adds FW_CONFIG to accommodate different Lotso BoM
components across various SKUs.
1. Fingerprint sensor - FP Present/Absent
BUG=b:350360162
BRANCH=None
TEST=Boot image on SKU2 and check FP working.
Change-Id: I1ee5fcd1c29099bdbee741ef76c00cf45fcc1189
Signed-off-by: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/lotso/overridetree.cb
1 file changed, 10 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/83388/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83388?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ee5fcd1c29099bdbee741ef76c00cf45fcc1189
Gerrit-Change-Number: 83388
Gerrit-PatchSet: 2
Gerrit-Owner: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83387?usp=email )
Change subject: Documentation/community/forums.md: Workaround for "ircs" link
......................................................................
Documentation/community/forums.md: Workaround for "ircs" link
Change-Id: Ief55fd353ca86eb91be14acedbe88462ef3c40e1
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Documentation/community/forums.md
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83387/1
diff --git a/Documentation/community/forums.md b/Documentation/community/forums.md
index e334edc..a246982 100644
--- a/Documentation/community/forums.md
+++ b/Documentation/community/forums.md
@@ -13,7 +13,7 @@
## Real time chat
-We also have a real time chat room on [IRC](ircs://irc.libera.chat/#coreboot),
+We also have a real time chat room on IRC <a href="ircs://irc.libera.chat/#coreboot">ircs://irc.libera.chat/#coreboot</a>,
also bridged to [Matrix](https://matrix.to/#/#coreboot:matrix.org) and a
[Discord](https://discord.gg/JqT8NM5Zbg) presence. You can also find us on
[OSF Slack](https://osfw.slack.com/), which has channels on many open source
--
To view, visit https://review.coreboot.org/c/coreboot/+/83387?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief55fd353ca86eb91be14acedbe88462ef3c40e1
Gerrit-Change-Number: 83387
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Subrata Banik.
Hello Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83354?usp=email
to look at the new patch set (#4).
Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock
......................................................................
soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock
List of changes:
1. Add required Pather Lake SoC programming till bootblock.
2. Include only required headers into include/soc.
3. Include PTL related DID, BDF.
4. Ref: Processor EDS documents
vol0.51 #815002
BUG=b:329787286
TEST=verified on Panther Lake Simics PSS using google/fatcat mainboard.
Change-Id: Ibcfe71eec27cebf04f10ec343a73dd92f1272aca
Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com>
---
A src/soc/intel/pantherlake/Kconfig
A src/soc/intel/pantherlake/Makefile.mk
A src/soc/intel/pantherlake/bootblock/bootblock.c
A src/soc/intel/pantherlake/bootblock/pch.c
A src/soc/intel/pantherlake/bootblock/report_platform.c
A src/soc/intel/pantherlake/include/soc/bootblock.h
A src/soc/intel/pantherlake/include/soc/espi.h
A src/soc/intel/pantherlake/include/soc/iomap.h
A src/soc/intel/pantherlake/include/soc/p2sb.h
A src/soc/intel/pantherlake/include/soc/pci_devs.h
A src/soc/intel/pantherlake/include/soc/pcr_ids.h
A src/soc/intel/pantherlake/include/soc/pm.h
A src/soc/intel/pantherlake/include/soc/smbus.h
13 files changed, 1,115 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/83354/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83354?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibcfe71eec27cebf04f10ec343a73dd92f1272aca
Gerrit-Change-Number: 83354
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Subrata Banik.
Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83354?usp=email )
Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> Hi Subrata, sure, valid point. Let me use the fatcat mainboard to build with PTL SoC.
Hi Subrata, with some required changes in MB fatcat, i am able to boot the bootblock stage.
Changes done:
1. rename config variable to "struct soc_intel_pantherlake_config *config" in file:fatcat/mainboard.c
2. rename DT soc var from "chip soc/intel/meteorlake" to "chip soc/intel/pantherlake"
3. rename config variable to "struct soc_intel_pantherlake_config *config" in file: fatcat/variants/baseboard/include/baseboard/variants.h
4. Add "SOC_INTEL_PANTHERLAKE" and remove mtl specific config such as "SOC_INTEL_METEORLAKE_U_H", "SOC_INTEL_IOE_DIE_SUPPORT" in file: fatcat/Kconfig
"
--
To view, visit https://review.coreboot.org/c/coreboot/+/83354?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibcfe71eec27cebf04f10ec343a73dd92f1272aca
Gerrit-Change-Number: 83354
Gerrit-PatchSet: 3
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Tue, 09 Jul 2024 10:59:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>