Attention is currently required from: Elyes Haouas, Jason Glenesk, Martin L Roth.
Hello Angel Pons, Jason Glenesk, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83384?usp=email
to look at the new patch set (#3).
Change subject: releases/coreboot-24.08: Remove ACPICA line
......................................................................
releases/coreboot-24.08: Remove ACPICA line
ACPICA reverted from 20240321 to 20230628 (commit 7c1813c1).
Change-Id: Id238f77c6a0b4052ae3d835caf98aaf26a7e570f
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Documentation/releases/coreboot-24.08-relnotes.md
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/83384/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83384?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id238f77c6a0b4052ae3d835caf98aaf26a7e570f
Gerrit-Change-Number: 83384
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Felix Singer, Ronald Claveau.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83104?usp=email
to look at the new patch set (#16).
The following approvals got outdated and were removed:
Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins)
Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
......................................................................
mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
Mainboard is identified as 0Y2MRG.
The version tested is with Nvidia dGPU (gfx 560ti).
The flash is a 4MiB Winbond W25Q32BVSIG.
It can be flashed internally with flashrom.
Add a strap on the service mode pin of the mainboard for internal flash.
Tested working:
- SeaBIOS
- All USB ports
- SATA
- dGPU
- Ethernet
- Environment control
- GPIOs
- S3 Sleep mode
- WakeOnLan
Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059
Signed-off-by: Ronald Claveau <sousmangoosta(a)aliel.fr>
---
A src/mainboard/dell/xps_8300/Kconfig
A src/mainboard/dell/xps_8300/Kconfig.name
A src/mainboard/dell/xps_8300/Makefile.mk
A src/mainboard/dell/xps_8300/acpi/ec.asl
A src/mainboard/dell/xps_8300/acpi/platform.asl
A src/mainboard/dell/xps_8300/acpi/superio.asl
A src/mainboard/dell/xps_8300/board_info.txt
A src/mainboard/dell/xps_8300/devicetree.cb
A src/mainboard/dell/xps_8300/dsdt.asl
A src/mainboard/dell/xps_8300/early_init.c
A src/mainboard/dell/xps_8300/gpio.c
A src/mainboard/dell/xps_8300/hda_verb.c
A src/mainboard/dell/xps_8300/mainboard.c
A src/mainboard/dell/xps_8300/smihandler.c
14 files changed, 471 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83104/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/83104?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059
Gerrit-Change-Number: 83104
Gerrit-PatchSet: 16
Gerrit-Owner: Ronald Claveau <sousmangoosta(a)aliel.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Ronald Claveau <sousmangoosta(a)aliel.fr>
Attention is currently required from: Andrey Petrov, Angel Pons, Arthur Heymans, Christian Walter, Elyes Haouas, Felix Held, Fred Reitberger, Jason Glenesk, Jeff Daly, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Matt DeVillier, Patrick Rudolph, Philipp Hug, Ron Minnich, Ronak Kanabar, Shuo Liu, Tim Chu, Vanessa Eusebio.
Jakub Czapiga has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82752?usp=email )
Change subject: cbmem_top: Change the return value to uintptr_t
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82752?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib757c0548f6f643747ba8d70228b3d6dfa5182cd
Gerrit-Change-Number: 82752
Gerrit-PatchSet: 11
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Tue, 09 Jul 2024 08:50:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Jason Glenesk, Martin L Roth.
Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83384?usp=email )
Change subject: releases/coreboot-24.08: Remove ACPIA line
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83384/comment/1bd1caa4_804d19c3?us… :
PS2, Line 7: ACPIA
typo
https://review.coreboot.org/c/coreboot/+/83384/comment/1dbf76fe_ebf18f80?us… :
PS2, Line 9: (Change-Id: I3ce0c579)
Use commit hash instead
--
To view, visit https://review.coreboot.org/c/coreboot/+/83384?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id238f77c6a0b4052ae3d835caf98aaf26a7e570f
Gerrit-Change-Number: 83384
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 09 Jul 2024 08:17:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth.
Hello Angel Pons, Jason Glenesk, Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83384?usp=email
to look at the new patch set (#2).
Change subject: releases/coreboot-24.08: Remove ACPIA line
......................................................................
releases/coreboot-24.08: Remove ACPIA line
ACPICA reverted from 20240321 to 20230628 (Change-Id: I3ce0c579).
Change-Id: Id238f77c6a0b4052ae3d835caf98aaf26a7e570f
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Documentation/releases/coreboot-24.08-relnotes.md
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/83384/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83384?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id238f77c6a0b4052ae3d835caf98aaf26a7e570f
Gerrit-Change-Number: 83384
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83032?usp=email )
Change subject: Doc/tutorial/part1.md: Correct libncurses-dev pkg name for debian
......................................................................
Doc/tutorial/part1.md: Correct libncurses-dev pkg name for debian
Change-Id: I5a71b914d40a9ea45be87f4581ff0072605e8c00
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83032
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Martin L Roth <gaumless(a)gmail.com>
---
M Documentation/tutorial/part1.md
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin L Roth: Looks good to me, approved
diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md
index eea2e17..229c8e2 100644
--- a/Documentation/tutorial/part1.md
+++ b/Documentation/tutorial/part1.md
@@ -30,7 +30,7 @@
Debian based distros:
`sudo apt-get install -y bison build-essential curl flex git gnat
-libncurses5-dev libssl-dev m4 zlib1g-dev pkg-config`
+libncurses-dev libssl-dev m4 zlib1g-dev pkg-config`
Arch based distros:
`sudo pacman -S base-devel curl git gcc-ada ncurses zlib`
@@ -202,7 +202,7 @@
* `build-essential` or `base-devel` are the basic tools for building software.
* `git` is needed to download coreboot from the coreboot git repository.
-* `libncurses5-dev` or `ncurses` is needed to build the menu for 'make menuconfig'
+* `libncurses-dev` or `ncurses` is needed to build the menu for 'make menuconfig'
* `m4, bison, curl, flex, zlib1g-dev, gcc, gnat` and `g++` or `clang`
are needed to build the coreboot toolchain. `gcc` and `gnat` have to be
of the same version.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83032?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5a71b914d40a9ea45be87f4581ff0072605e8c00
Gerrit-Change-Number: 83032
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Jakub Czapiga, Julius Werner.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83157?usp=email )
Change subject: Documentation: Use pkgconf over pkg-config
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83157/comment/5db17cb6_2d870454?us… :
PS5, Line 7: tree: Use pkgconf over pkg-config
> indeed to /usr/local/bin/pkg-config […]
Done
File tests/data/lib/lzma-test/data.2.bin:
https://review.coreboot.org/c/coreboot/+/83157/comment/6768ec43_91045c71?us… :
PS1, Line 52: * pkgconf
> You can probably drop `ibs=1`, but `skip=8` is mandatory to drop header from binary data. […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/83157?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8
Gerrit-Change-Number: 83157
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 09 Jul 2024 07:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga <czapiga(a)google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>