Attention is currently required from: Cliff Huang, Martin L Roth.
Anil Kumar K has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83225?usp=email )
Change subject: payloads/depthcharge: support depthcharge build with local changes
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83225/comment/2e33e3c3_8a42d083?us… :
PS1, Line 12: Fix 'git fetch' for the repo other than origin/main.
Can u share more details on the issue that u fixed here ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83225?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I95c1f71ae149537a2191734a62f416b7b6f41fc6
Gerrit-Change-Number: 83225
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2024 18:52:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Cliff Huang, Martin L Roth.
Anil Kumar K has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83225?usp=email )
Change subject: payloads/depthcharge: support depthcharge build with local changes
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83225?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I95c1f71ae149537a2191734a62f416b7b6f41fc6
Gerrit-Change-Number: 83225
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2024 18:50:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Anil Kumar K, Cliff Huang, Martin L Roth.
Bora Guvendik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83225?usp=email )
Change subject: payloads/depthcharge: support depthcharge build with local changes
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83225/comment/bb8ea27c_d6d041aa?us… :
PS1, Line 11: geneerated
generated
--
To view, visit https://review.coreboot.org/c/coreboot/+/83225?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I95c1f71ae149537a2191734a62f416b7b6f41fc6
Gerrit-Change-Number: 83225
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2024 18:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas, Matt DeVillier, Sean Rhodes.
Felix Singer has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/starlabs/byte_adl/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/80705/comment/0874d68d_72e33d0e?us… :
PS9, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
```suggestion
/* SPDX-License-Identifier: CC-PDDC */
/* Please update the license if adding licensable material. */
```
File src/mainboard/starlabs/byte_adl/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/80705/comment/fd8a4152_29525002?us… :
PS9, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
```suggestion
/* SPDX-License-Identifier: CC-PDDC */
/* Please update the license if adding licensable material. */
```
File src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80705/comment/90c10953_947501ac?us… :
PS9, Line 28: # Device Tree
: device cpu_cluster 0 on end
:
: d
The CPU device already exists in chipset devicetree.
```suggestion
device domain 0 on
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 11 Jul 2024 17:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83413?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: Update amd_blobs submodule to upstream main
......................................................................
Update amd_blobs submodule to upstream main
Updating from commit id ae5fc7d:
2024-03-15 19:58:57 +0100 - (picasso: Update PSP fw to version
00.08.14.7B)
to commit id 26c5729:
2024-07-10 10:10:50 -0500 - (CZN: Update SMU fw to 64.72.0)
This brings in 2 new commits:
26c5729 CZN: Update SMU fw to 64.72.0
942adff Add VanGogh blobs
Change-Id: I4c699379a196a0819201f7a6c9f1b3319edef4ff
Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83413
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
---
M 3rdparty/amd_blobs
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Felix Singer: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs
index ae5fc7d..26c5729 160000
--- a/3rdparty/amd_blobs
+++ b/3rdparty/amd_blobs
@@ -1 +1 @@
-Subproject commit ae5fc7d27720267ceb2ccf2fbef0ab76b023ea26
+Subproject commit 26c572974bcf7255930b0e9a51da3144ed0104b5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83413?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4c699379a196a0819201f7a6c9f1b3319edef4ff
Gerrit-Change-Number: 83413
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83407?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/emulation/qemu-q35: Move QEMU specific macros to "q35.h"
......................................................................
mb/emulation/qemu-q35: Move QEMU specific macros to "q35.h"
As `qemu-q35/memmap.c` includes `qemu-q35/q35.h`, move macros into q35.h
file.
Change-Id: I0bf13def8bc4510053f6bb44e043bbcb0b958b01
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/mainboard/emulation/qemu-q35/memmap.c
M src/mainboard/emulation/qemu-q35/q35.h
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/83407/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83407?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0bf13def8bc4510053f6bb44e043bbcb0b958b01
Gerrit-Change-Number: 83407
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Felix Singer, Michał Żygowski, Nico Huber, Piotr Król.
Matt DeVillier has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83373?usp=email )
Change subject: skl/kbl mainboards: Move PCIe related settings into their device scope
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83373?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ffa87eeee521180f37371e5a0d1f9a1a06091aa
Gerrit-Change-Number: 83373
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Thu, 11 Jul 2024 16:24:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes