coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XL] Change in coreboot[main]: mb/google/brox: Create jubilant variant
by Karthik Ramasubramanian (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Bob Moragues, David Wu, Ren Kuo, Shelley Chen, Subrata Banik, Tyler Wang, YH Lin. Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email ) Change subject: mb/google/brox: Create jubilant variant ...................................................................... Patch Set 24: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic54437697058f8bce2167093bd88c0880d1b7cac Gerrit-Change-Number: 83212 Gerrit-PatchSet: 24 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bob Moragues <moragues(a)chromium.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 23:46:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create jubilant variant
by Bob Moragues (Code Review) 31 Jul '24

31 Jul '24

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create jubilant variant
by Bob Moragues (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: David Wu, Karthik Ramasubramanian, Ren Kuo, Shelley Chen, Subrata Banik, Tyler Wang, YH Lin. Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email ) Change subject: mb/google/brox: Create jubilant variant ...................................................................... Patch Set 23: (4 comments) File src/mainboard/google/brox/Kconfig: https://review.coreboot.org/c/coreboot/+/83212/comment/109054d9_01001ace?us… : PS17, Line 86: : if BOARD_GOOGLE_BROX_COMMON > put this at the end of line 85 (like lines 83) OK. Doing that causes problems. Leaving as is.... File src/mainboard/google/brox/variants/jubilant/overridetree.cb: https://review.coreboot.org/c/coreboot/+/83212/comment/27a3dc59_d77eaa44?us… : PS16, Line 11: 11 12 > Move this after ISH to be bits 14 15 Done https://review.coreboot.org/c/coreboot/+/83212/comment/0572d4fc_c6a7cd19?us… : PS16, Line 15: 17 18 > This should probably match the FP field in config. […] Done https://review.coreboot.org/c/coreboot/+/83212/comment/a0e181f3_c70296cd?us… : PS16, Line 1: fw_config : field STORAGE 2 3 : option STORAGE_UNKNOWN 0 : option STORAGE_UFS 1 : option STORAGE_NVME 2 : end : field WIFI_BT 4 4 : option WIFI_BT_CNVI 0 : option WIFI_BT_PCIE 1 : end : field DB_USB 11 12 : option DB_1A 0 : option DB_1A_LTE 1 : end : field FPMCU 17 18 : option FPMCU_ABSENT 0 : option FPMCU_NUVOTON 1 : end : end > This is what I came up with: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic54437697058f8bce2167093bd88c0880d1b7cac Gerrit-Change-Number: 83212 Gerrit-PatchSet: 23 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bob Moragues <moragues(a)chromium.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 22:35:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bob Moragues <moragues(a)chromium.org>

1 0

[S] Change in coreboot[main]: arch/arm64/armv8/mmu: Improve log format
by Julius Werner (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Yu-Ping Wu. Julius Werner has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83652?usp=email ) Change subject: arch/arm64/armv8/mmu: Improve log format ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83652/comment/40b83169_5eeec342?us… : PS2, Line 9: When using format string with "%p", "(nil)" will be printed for address > See this in unit tests, not on a real ARM device. Let me modify the commit message. I don't feel like we should modify coreboot's code because of printing behavior that only happens in some random libc's `printf()` implementation tbh. -- To view, visit https://review.coreboot.org/c/coreboot/+/83652?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib29c201e1b096b9c7cd750d2541923616bc858ac Gerrit-Change-Number: 83652 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 21:45:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create jubilant variant
by Bob Moragues (Code Review) 30 Jul '24

30 Jul '24

1 0

[XS] Change in coreboot[main]: security/intel/txt: Handle TPM properly when vboot enabled
by Julius Werner (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Christian Walter, Filip Lewiński, Michał Żygowski. Julius Werner has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82695?usp=email ) Change subject: security/intel/txt: Handle TPM properly when vboot enabled ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > and then in ramstage again It's not run in ramstage for vboot, though. `drivers/tpm/tpm.c` (somewhat badly named, it should really be `tpm_init_in_ramstage.c`) is only linked in for `CONFIG_TPM_INIT_RAMSTAGE`, which depends on `!VBOOT`. I don't think any approach that runs `tpm_setup()` twice is a good idea. I think the best solution here is probably to just guard the `tpm_setup()` call in `vboot_setup_tpm()` with `if (!CONFIG(TPM_MEASURED_IN_BOOTBLOCK))`. That means you'll not quite get the right TPM setup error when TPM communication failed, but vboot should still go into recovery on account of not being able to read secdata so it probably doesn't make too much of a difference. -- To view, visit https://review.coreboot.org/c/coreboot/+/82695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I19dc3d910c23fcfd8732465c488f47dd86a96781 Gerrit-Change-Number: 82695 Gerrit-PatchSet: 4 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 21:00:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[L] Change in coreboot[main]: mb/google/brox: Create jubilant variant
by Bob Moragues (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: David Wu, Ren Kuo, Shelley Chen, Subrata Banik, YH Lin. Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email ) Change subject: mb/google/brox: Create jubilant variant ...................................................................... Patch Set 17: (1 comment) Patchset: PS17: The missing changes to overridetree.cb will still cause the depthcharge build to fail. Please incorporate those changes before merging. -- To view, visit https://review.coreboot.org/c/coreboot/+/83212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic54437697058f8bce2167093bd88c0880d1b7cac Gerrit-Change-Number: 83212 Gerrit-PatchSet: 17 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bob Moragues <moragues(a)chromium.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 20:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: commonlib/device_tree.c: Fix results length check
by Julius Werner (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Maximilian Brune. Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83085?usp=email ) Change subject: commonlib/device_tree.c: Fix results length check ...................................................................... Patch Set 4: (1 comment) File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/83085/comment/73be31bd_4bd8e3d4?us… : PS1, Line 363: if (count_results > results_len) { > The current implementation should work. But I am thinking of just ditching the warning. […] Hmm... yeah, realistically, for almost all nodes (except the `/memory` ones), if they have multiple reg areas the caller needs to know specifically what each of them means anyway (either intrinsically or via something like `reg-names`), otherwise it wouldn't know what to do with the remaining entries. And there may be legitimate situations where a caller knows it only wants to read the first X entries even if there may be more. So maybe dropping the warning makes most sense. -- To view, visit https://review.coreboot.org/c/coreboot/+/83085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic1111e8acb72ea1e9159da0d8386f40cbbdbc63f Gerrit-Change-Number: 83085 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 20:07:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: commonlib/device_tree.c: Fix results length check
by Julius Werner (Code Review) 30 Jul '24

30 Jul '24

1 0

[XS] Change in coreboot[main]: soc/amd/common/psp: move buffer sizes to common header
by Matt DeVillier (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk. Matt DeVillier has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83701?usp=email ) Change subject: soc/amd/common/psp: move buffer sizes to common header ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83701?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d4d93760c90ad6e0ecadf70600b1d697a02fa82 Gerrit-Change-Number: 83701 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 19:40:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024