Attention is currently required from: Felix Singer, Martin L Roth, Nico Huber.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83452?usp=email )
Change subject: Makefile.mk: Reorganize CFLAGS_common
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
Thx
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83452/comment/3cf74b27_07167a80?us… :
PS4, Line 507: # Options controlling the kind of output
> I like that the warning options are reorganized and sorted, but not sure if it really makes sense to […]
I'll remove those comments, but in that case, the sorting will not be easy to understand.
anyway, let give it a try
--
To view, visit https://review.coreboot.org/c/coreboot/+/83452?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3216ef2e0b3cd25f343939d5b9ef932f2f91e56c
Gerrit-Change-Number: 83452
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 04:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Dinesh Gehlot, Pranava Y N, Subrata Banik.
Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83491?usp=email )
Change subject: device/pci_ids: Add new Intel PTL device IDs for DID2
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83491?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iab499070c87e020e36901b4ea453a1893bd16ea0
Gerrit-Change-Number: 83491
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 00:08:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Pranava Y N, Subrata Banik.
Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83490?usp=email )
Change subject: device/pci_ids: Add new Intel PTL device IDs for DID0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83490?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie4d77eb489e16d18b996fdda3216e1275083d7e7
Gerrit-Change-Number: 83490
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 00:08:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83226?usp=email )
Change subject: Makefile.mk: Use one line per *_common flag
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83226/comment/55683b66_78db47e7?us… :
PS2, Line 10: It makes the list of options more readable.
I don't see how. Now I have to look up and down which feels
unnatural (I'm used to read line-wise).
If you have trouble finding something, please make more use
of your editors search functions, then you don't have to re-
arrange the world.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83226?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33c500e6eb74daf1e66c2b5e07b50f81c0f4587d
Gerrit-Change-Number: 83226
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Tue, 16 Jul 2024 21:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Singer, Maciej Pijanowski, Michał Żygowski, Piotr Król.
Nico Huber has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/80501?usp=email )
Change subject: mb/protectli/vault_adl_p: Add initial support for VP6630/VP6650/VP6670
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
File src/mainboard/protectli/vault_adl_p/mainboard.c:
https://review.coreboot.org/c/coreboot/+/80501/comment/1fd91190_4506888a?us… :
PS7, Line 29: }
> Created a C file with the beep function
Acknowledged
https://review.coreboot.org/c/coreboot/+/80501/comment/897aeab8_8fb16b6d?us… :
PS7, Line 51: }
> Uhh, I didn't realize there is a function to get a processor name already under cpu/x86/name. […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/80501?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If4ae5b14b69806b6b0727d1ca1dcf56f47cfcd8e
Gerrit-Change-Number: 80501
Gerrit-PatchSet: 10
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 21:35:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Attention is currently required from: Michał Żygowski.
Nico Huber has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83469?usp=email )
Change subject: superio/ite,mb: Switch the mainboards' code to the new ITE GPIO driver
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
LGTM. Not sure if we should try to find people to test things?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83469?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I707ee090ee2551b4935847e12ade678d36ff9302
Gerrit-Change-Number: 83469
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 21:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Michał Żygowski.
Nico Huber has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83468?usp=email )
Change subject: superio/ite: Enable common driver for GPIO and LED configuration
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83468/comment/89545d07_12c7a1bb?us… :
PS2, Line 11: withj
typo
--
To view, visit https://review.coreboot.org/c/coreboot/+/83468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0868ff3e9022b135c21f4c1a6746d6440b8f0798
Gerrit-Change-Number: 83468
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 21:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Michał Żygowski.
Nico Huber has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83355?usp=email )
Change subject: superio/ite/common: Add common driver for GPIO and LED configuration
......................................................................
Patch Set 3: Code-Review+2
(6 comments)
File src/mainboard/samsung/stumpy/smihandler.c:
https://review.coreboot.org/c/coreboot/+/83355/comment/4e8c0c9c_abea00f6?us… :
PS1, Line 25: ite_reg_write(GPIO_DEV, IT8772F_GPIO_REG_SELECT(3), 0x20);
> Done in CB:83469
Acknowledged
https://review.coreboot.org/c/coreboot/+/83355/comment/81eb7abe_19c9be17?us… :
PS1, Line 39: ite_reg_write(GPIO_DEV, IT8772F_GPIO_REG_SELECT(3), 0x20);
> Done in CB:83469
Acknowledged
https://review.coreboot.org/c/coreboot/+/83355/comment/fb1b533d_df71e40f?us… :
PS1, Line 49: ITE_LED_FREQ_1HZ);
> Done in CB:83469
Acknowledged
File src/superio/ite/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/83355/comment/2553f7da_e1159219?us… :
PS1, Line 130: */
> Added the function which checks for the register presence like for the other 2 registers. […]
Acknowledged
File src/superio/ite/it8772f/it8772f.h:
https://review.coreboot.org/c/coreboot/+/83355/comment/3767ae12_3d2eccd4?us… :
PS1, Line 16:
: /* GPIO Polarity Select: 1: Inverting, 0: Non-inverting */
: #define IT8772F_GPIO_REG_POLARITY(x) (0xb0 + (x))
:
: /* GPIO Internal Pull-up: 1: Enable, 0: Disable */
: #define IT8772F_GPIO_REG_PULLUP(x) (0xb8 + (x))
:
: /* GPIO Function Select: 1: Simple I/O, 0: Alternate function */
: #define IT8772F_GPIO_REG_ENABLE(x) (0xc0 + (x))
:
: /* GPIO Mode: 0: input mode, 1: output mode */
: #define IT8772F_GPIO_REG_OUTPUT(x) (0xc8 + (x))
:
> Removed in CB:83469 […]
Acknowledged
File src/superio/ite/it8786e/Kconfig:
https://review.coreboot.org/c/coreboot/+/83355/comment/c7eb6943_9459f3f0?us… :
PS1, Line 16: default 10
> In the "IT8786E-I Preliminary SPecification v0.4.1 for D version" […]
Ok, I only found a v0.2 and was going by the pins. But it's certainly possible
that there are packages with more GPIO.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83355?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If610d2809b56c63444c3406c26fad412c94136a5
Gerrit-Change-Number: 83355
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 21:12:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>