coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[S] Change in coreboot[main]: mb/google/cyan: Prefer include <soc/gpio.h> via <gpio.h>
by Elyes Haouas (Code Review) 04 Jun '24

04 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82798?usp=email ) Change subject: mb/google/cyan: Prefer include <soc/gpio.h> via <gpio.h> ...................................................................... mb/google/cyan: Prefer include <soc/gpio.h> via <gpio.h> Change-Id: I782a8ec7cf2cf1a6ebca3ac6c6720ab8039f445c Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c 13 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/82798/1 diff --git a/src/mainboard/google/cyan/com_init.c b/src/mainboard/google/cyan/com_init.c index b11ae36..ab1ec99 100644 --- a/src/mainboard/google/cyan/com_init.c +++ b/src/mainboard/google/cyan/com_init.c @@ -3,7 +3,7 @@ #include <bootblock_common.h> #include <device/mmio.h> #include <device/pci_ops.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/lpc.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/google/cyan/smihandler.c b/src/mainboard/google/cyan/smihandler.c index d0af1d4..f924619 100644 --- a/src/mainboard/google/cyan/smihandler.c +++ b/src/mainboard/google/cyan/smihandler.c @@ -6,7 +6,7 @@ #include "ec.h" #include <ec/google/chromeec/smm.h> #include <soc/pm.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/onboard.h> diff --git a/src/mainboard/google/cyan/variants/banon/gpio.c b/src/mainboard/google/cyan/variants/banon/gpio.c index 4e91db4..4acd794 100644 --- a/src/mainboard/google/cyan/variants/banon/gpio.c +++ b/src/mainboard/google/cyan/variants/banon/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/celes/gpio.c b/src/mainboard/google/cyan/variants/celes/gpio.c index 71e209e..9fb9fea 100644 --- a/src/mainboard/google/cyan/variants/celes/gpio.c +++ b/src/mainboard/google/cyan/variants/celes/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/cyan/gpio.c b/src/mainboard/google/cyan/variants/cyan/gpio.c index 5723acf..2d4e448 100644 --- a/src/mainboard/google/cyan/variants/cyan/gpio.c +++ b/src/mainboard/google/cyan/variants/cyan/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/edgar/gpio.c b/src/mainboard/google/cyan/variants/edgar/gpio.c index d285c04..da5b1c4 100644 --- a/src/mainboard/google/cyan/variants/edgar/gpio.c +++ b/src/mainboard/google/cyan/variants/edgar/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/kefka/gpio.c b/src/mainboard/google/cyan/variants/kefka/gpio.c index 23fe4e1..b814d23 100644 --- a/src/mainboard/google/cyan/variants/kefka/gpio.c +++ b/src/mainboard/google/cyan/variants/kefka/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/reks/gpio.c b/src/mainboard/google/cyan/variants/reks/gpio.c index 13cc639..2c4f7a5 100644 --- a/src/mainboard/google/cyan/variants/reks/gpio.c +++ b/src/mainboard/google/cyan/variants/reks/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/relm/gpio.c b/src/mainboard/google/cyan/variants/relm/gpio.c index 2d308f5..edeeb43 100644 --- a/src/mainboard/google/cyan/variants/relm/gpio.c +++ b/src/mainboard/google/cyan/variants/relm/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/setzer/gpio.c b/src/mainboard/google/cyan/variants/setzer/gpio.c index c57d28c..ed23ce2 100644 --- a/src/mainboard/google/cyan/variants/setzer/gpio.c +++ b/src/mainboard/google/cyan/variants/setzer/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/terra/gpio.c b/src/mainboard/google/cyan/variants/terra/gpio.c index d2e79f1..f0d2b9b 100644 --- a/src/mainboard/google/cyan/variants/terra/gpio.c +++ b/src/mainboard/google/cyan/variants/terra/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/ultima/gpio.c b/src/mainboard/google/cyan/variants/ultima/gpio.c index 13cc639..2c4f7a5 100644 --- a/src/mainboard/google/cyan/variants/ultima/gpio.c +++ b/src/mainboard/google/cyan/variants/ultima/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/wizpig/gpio.c b/src/mainboard/google/cyan/variants/wizpig/gpio.c index 3bb3931..1c4ce8b 100644 --- a/src/mainboard/google/cyan/variants/wizpig/gpio.c +++ b/src/mainboard/google/cyan/variants/wizpig/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/82798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I782a8ec7cf2cf1a6ebca3ac6c6720ab8039f445c Gerrit-Change-Number: 82798 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: mb/google/brox: Prefer include <soc/gpio.h> via <gpio.h>
by Elyes Haouas (Code Review) 04 Jun '24

04 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82797?usp=email ) Change subject: mb/google/brox: Prefer include <soc/gpio.h> via <gpio.h> ...................................................................... mb/google/brox: Prefer include <soc/gpio.h> via <gpio.h> Change-Id: I7ac2ef36c3850c9f6efe3e7f36fb439ae0239f97 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/brox/mainboard.c M src/mainboard/google/brox/variants/baseboard/brox/gpio.c M src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h M src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/brox/variants/brox/gpio.c M src/mainboard/google/brox/variants/greenbayupoc/gpio.c 6 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/82797/1 diff --git a/src/mainboard/google/brox/mainboard.c b/src/mainboard/google/brox/mainboard.c index 9285ae2..0a3ed38 100644 --- a/src/mainboard/google/brox/mainboard.c +++ b/src/mainboard/google/brox/mainboard.c @@ -9,7 +9,7 @@ #include <ec/ec.h> #include <fw_config.h> #include <security/tpm/tss.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/ramstage.h> #include <stdio.h> diff --git a/src/mainboard/google/brox/variants/baseboard/brox/gpio.c b/src/mainboard/google/brox/variants/baseboard/brox/gpio.c index edff2be..877b776 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/gpio.c +++ b/src/mainboard/google/brox/variants/baseboard/brox/gpio.c @@ -10,7 +10,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> /* Pad configuration in ramstage */ diff --git a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h index 2c1fc0a..42da6fc 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h +++ b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h @@ -4,7 +4,7 @@ #define __BASEBOARD_GPIO_H__ #include <soc/gpe.h> -#include <soc/gpio.h> +#include <gpio.h> /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI diff --git a/src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h index ad8eb05..18ffebd 100644 --- a/src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h @@ -4,7 +4,7 @@ #define __BASEBOARD_VARIANTS_H__ #include <chip.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/meminit.h> #include <stdint.h> diff --git a/src/mainboard/google/brox/variants/brox/gpio.c b/src/mainboard/google/brox/variants/brox/gpio.c index 5af3552..143cdb6 100644 --- a/src/mainboard/google/brox/variants/brox/gpio.c +++ b/src/mainboard/google/brox/variants/brox/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <boardid.h> -#include <soc/gpio.h> +#include <gpio.h> const struct pad_config *variant_gpio_override_table(size_t *num) { diff --git a/src/mainboard/google/brox/variants/greenbayupoc/gpio.c b/src/mainboard/google/brox/variants/greenbayupoc/gpio.c index f26f098..182684b 100644 --- a/src/mainboard/google/brox/variants/greenbayupoc/gpio.c +++ b/src/mainboard/google/brox/variants/greenbayupoc/gpio.c @@ -11,7 +11,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/82797?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7ac2ef36c3850c9f6efe3e7f36fb439ae0239f97 Gerrit-Change-Number: 82797 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: mb/google/brya: Prefer include <soc/gpio.h> via <gpio.h>
by Elyes Haouas (Code Review) 04 Jun '24

04 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82796?usp=email to look at the new patch set (#2). Change subject: mb/google/brya: Prefer include <soc/gpio.h> via <gpio.h> ...................................................................... mb/google/brya: Prefer include <soc/gpio.h> via <gpio.h> Change-Id: I8d4342e88fdbac2e326568df9ad03af18a55ce7a Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/agah/gpio.c M src/mainboard/google/brya/variants/anahera/gpio.c M src/mainboard/google/brya/variants/anahera4es/gpio.c M src/mainboard/google/brya/variants/anraggar/gpio.c M src/mainboard/google/brya/variants/aurash/gpio.c M src/mainboard/google/brya/variants/banshee/gpio.c M src/mainboard/google/brya/variants/baseboard/brask/gpio.c M src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/gpio.h M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/gpio.h M src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/gpio.h M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/brya/variants/baseboard/nissa/gpio.c M src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h M src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h M src/mainboard/google/brya/variants/brask/gpio.c M src/mainboard/google/brya/variants/brya0/gpio.c M src/mainboard/google/brya/variants/bujia/gpio.c M src/mainboard/google/brya/variants/craask/gpio.c M src/mainboard/google/brya/variants/craaskov/gpio.c M src/mainboard/google/brya/variants/crota/gpio.c M src/mainboard/google/brya/variants/dochi/gpio.c M src/mainboard/google/brya/variants/felwinter/gpio.c M src/mainboard/google/brya/variants/gaelin/gpio.c M src/mainboard/google/brya/variants/gimble/gpio.c M src/mainboard/google/brya/variants/gimble4es/gpio.c M src/mainboard/google/brya/variants/gladios/gpio.c M src/mainboard/google/brya/variants/glassway/gpio.c M src/mainboard/google/brya/variants/gothrax/gpio.c M src/mainboard/google/brya/variants/hades/gpio.c M src/mainboard/google/brya/variants/joxer/gpio.c M src/mainboard/google/brya/variants/kano/gpio.c M src/mainboard/google/brya/variants/kinox/gpio.c M src/mainboard/google/brya/variants/kuldax/gpio.c M src/mainboard/google/brya/variants/lisbon/gpio.c M src/mainboard/google/brya/variants/marasov/gpio.c M src/mainboard/google/brya/variants/mithrax/gpio.c M src/mainboard/google/brya/variants/nereid/gpio.c M src/mainboard/google/brya/variants/nivviks/gpio.c M src/mainboard/google/brya/variants/nova/gpio.c M src/mainboard/google/brya/variants/omnigul/gpio.c M src/mainboard/google/brya/variants/orisa/gpio.c M src/mainboard/google/brya/variants/osiris/gpio.c M src/mainboard/google/brya/variants/pirrha/gpio.c M src/mainboard/google/brya/variants/primus/gpio.c M src/mainboard/google/brya/variants/pujjo/gpio.c M src/mainboard/google/brya/variants/pujjoga/gpio.c M src/mainboard/google/brya/variants/quandiso/gpio.c M src/mainboard/google/brya/variants/redrix/gpio.c M src/mainboard/google/brya/variants/redrix4es/gpio.c M src/mainboard/google/brya/variants/skolas/gpio.c M src/mainboard/google/brya/variants/skolas4es/gpio.c M src/mainboard/google/brya/variants/sundance/gpio.c M src/mainboard/google/brya/variants/taeko/gpio.c M src/mainboard/google/brya/variants/taeko4es/gpio.c M src/mainboard/google/brya/variants/taniks/gpio.c M src/mainboard/google/brya/variants/trulo/gpio.c M src/mainboard/google/brya/variants/uldren/gpio.c M src/mainboard/google/brya/variants/vell/gpio.c M src/mainboard/google/brya/variants/volmar/gpio.c M src/mainboard/google/brya/variants/xivu/gpio.c M src/mainboard/google/brya/variants/xol/gpio.c M src/mainboard/google/brya/variants/yaviks/gpio.c M src/mainboard/google/brya/variants/yavilla/gpio.c M src/mainboard/google/brya/variants/zydron/gpio.c 66 files changed, 66 insertions(+), 66 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/82796/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82796?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d4342e88fdbac2e326568df9ad03af18a55ce7a Gerrit-Change-Number: 82796 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[M] Change in coreboot[main]: mb/brya: Prefer include <soc/gpio.h> via <gpio.h>
by Elyes Haouas (Code Review) 04 Jun '24

04 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82796?usp=email ) Change subject: mb/brya: Prefer include <soc/gpio.h> via <gpio.h> ...................................................................... mb/brya: Prefer include <soc/gpio.h> via <gpio.h> Change-Id: I8d4342e88fdbac2e326568df9ad03af18a55ce7a Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/agah/gpio.c M src/mainboard/google/brya/variants/anahera/gpio.c M src/mainboard/google/brya/variants/anahera4es/gpio.c M src/mainboard/google/brya/variants/anraggar/gpio.c M src/mainboard/google/brya/variants/aurash/gpio.c M src/mainboard/google/brya/variants/banshee/gpio.c M src/mainboard/google/brya/variants/baseboard/brask/gpio.c M src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/gpio.h M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/gpio.h M src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/gpio.h M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/brya/variants/baseboard/nissa/gpio.c M src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h M src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h M src/mainboard/google/brya/variants/brask/gpio.c M src/mainboard/google/brya/variants/brya0/gpio.c M src/mainboard/google/brya/variants/bujia/gpio.c M src/mainboard/google/brya/variants/craask/gpio.c M src/mainboard/google/brya/variants/craaskov/gpio.c M src/mainboard/google/brya/variants/crota/gpio.c M src/mainboard/google/brya/variants/dochi/gpio.c M src/mainboard/google/brya/variants/felwinter/gpio.c M src/mainboard/google/brya/variants/gaelin/gpio.c M src/mainboard/google/brya/variants/gimble/gpio.c M src/mainboard/google/brya/variants/gimble4es/gpio.c M src/mainboard/google/brya/variants/gladios/gpio.c M src/mainboard/google/brya/variants/glassway/gpio.c M src/mainboard/google/brya/variants/gothrax/gpio.c M src/mainboard/google/brya/variants/hades/gpio.c M src/mainboard/google/brya/variants/joxer/gpio.c M src/mainboard/google/brya/variants/kano/gpio.c M src/mainboard/google/brya/variants/kinox/gpio.c M src/mainboard/google/brya/variants/kuldax/gpio.c M src/mainboard/google/brya/variants/lisbon/gpio.c M src/mainboard/google/brya/variants/marasov/gpio.c M src/mainboard/google/brya/variants/mithrax/gpio.c M src/mainboard/google/brya/variants/nereid/gpio.c M src/mainboard/google/brya/variants/nivviks/gpio.c M src/mainboard/google/brya/variants/nova/gpio.c M src/mainboard/google/brya/variants/omnigul/gpio.c M src/mainboard/google/brya/variants/orisa/gpio.c M src/mainboard/google/brya/variants/osiris/gpio.c M src/mainboard/google/brya/variants/pirrha/gpio.c M src/mainboard/google/brya/variants/primus/gpio.c M src/mainboard/google/brya/variants/pujjo/gpio.c M src/mainboard/google/brya/variants/pujjoga/gpio.c M src/mainboard/google/brya/variants/quandiso/gpio.c M src/mainboard/google/brya/variants/redrix/gpio.c M src/mainboard/google/brya/variants/redrix4es/gpio.c M src/mainboard/google/brya/variants/skolas/gpio.c M src/mainboard/google/brya/variants/skolas4es/gpio.c M src/mainboard/google/brya/variants/sundance/gpio.c M src/mainboard/google/brya/variants/taeko/gpio.c M src/mainboard/google/brya/variants/taeko4es/gpio.c M src/mainboard/google/brya/variants/taniks/gpio.c M src/mainboard/google/brya/variants/trulo/gpio.c M src/mainboard/google/brya/variants/uldren/gpio.c M src/mainboard/google/brya/variants/vell/gpio.c M src/mainboard/google/brya/variants/volmar/gpio.c M src/mainboard/google/brya/variants/xivu/gpio.c M src/mainboard/google/brya/variants/xol/gpio.c M src/mainboard/google/brya/variants/yaviks/gpio.c M src/mainboard/google/brya/variants/yavilla/gpio.c M src/mainboard/google/brya/variants/zydron/gpio.c 66 files changed, 66 insertions(+), 66 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/82796/1 diff --git a/src/mainboard/google/brya/mainboard.c b/src/mainboard/google/brya/mainboard.c index 07aa4b5..9cacbab 100644 --- a/src/mainboard/google/brya/mainboard.c +++ b/src/mainboard/google/brya/mainboard.c @@ -9,7 +9,7 @@ #include <ec/ec.h> #include <fw_config.h> #include <security/tpm/tss.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/ramstage.h> #include <stdio.h> diff --git a/src/mainboard/google/brya/variants/agah/gpio.c b/src/mainboard/google/brya/variants/agah/gpio.c index 02ed698..bf9400a 100644 --- a/src/mainboard/google/brya/variants/agah/gpio.c +++ b/src/mainboard/google/brya/variants/agah/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/anahera/gpio.c b/src/mainboard/google/brya/variants/anahera/gpio.c index 9c73320..be036dd 100644 --- a/src/mainboard/google/brya/variants/anahera/gpio.c +++ b/src/mainboard/google/brya/variants/anahera/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/anahera4es/gpio.c b/src/mainboard/google/brya/variants/anahera4es/gpio.c index b18725c..0cbf123 100644 --- a/src/mainboard/google/brya/variants/anahera4es/gpio.c +++ b/src/mainboard/google/brya/variants/anahera4es/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/anraggar/gpio.c b/src/mainboard/google/brya/variants/anraggar/gpio.c index 03507b0..8423494 100644 --- a/src/mainboard/google/brya/variants/anraggar/gpio.c +++ b/src/mainboard/google/brya/variants/anraggar/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/aurash/gpio.c b/src/mainboard/google/brya/variants/aurash/gpio.c index 78e1243..728fbac 100644 --- a/src/mainboard/google/brya/variants/aurash/gpio.c +++ b/src/mainboard/google/brya/variants/aurash/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/banshee/gpio.c b/src/mainboard/google/brya/variants/banshee/gpio.c index f648453..24b445a 100644 --- a/src/mainboard/google/brya/variants/banshee/gpio.c +++ b/src/mainboard/google/brya/variants/banshee/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c index 3d667b9..1918181 100644 --- a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c @@ -4,7 +4,7 @@ #include <baseboard/variants.h> #include <intelblocks/early_graphics.h> #include <types.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> /* Pad configuration in ramstage */ diff --git a/src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/gpio.h b/src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/gpio.h index 0de7ffd..8554f7a 100644 --- a/src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/gpio.h +++ b/src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/gpio.h @@ -4,7 +4,7 @@ #define __BASEBOARD_GPIO_H__ #include <soc/gpe.h> -#include <soc/gpio.h> +#include <gpio.h> /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI diff --git a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c index 07f8dbd..e2f6297 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <types.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> /* Pad configuration in ramstage */ diff --git a/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/gpio.h b/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/gpio.h index 0de7ffd..8554f7a 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/gpio.h +++ b/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/gpio.h @@ -4,7 +4,7 @@ #define __BASEBOARD_GPIO_H__ #include <soc/gpe.h> -#include <soc/gpio.h> +#include <gpio.h> /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI diff --git a/src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/gpio.h b/src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/gpio.h index b974aa5..8358a51 100644 --- a/src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/gpio.h +++ b/src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/gpio.h @@ -4,7 +4,7 @@ #define __BASEBOARD_GPIO_H__ #include <soc/gpe.h> -#include <soc/gpio.h> +#include <gpio.h> /* TODO: Set the correct values */ /* eSPI virtual wire reporting */ diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h index 583af59..c1ab634 100644 --- a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h @@ -5,7 +5,7 @@ #include <chip.h> #include <intelblocks/power_limit.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/meminit.h> #include <stdint.h> diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/gpio.c b/src/mainboard/google/brya/variants/baseboard/nissa/gpio.c index 7f74256..8b71808 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/nissa/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <types.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> /* Pad configuration in ramstage */ diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h b/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h index 51e4b20..f0aa88b 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h +++ b/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h @@ -4,7 +4,7 @@ #define __BASEBOARD_GPIO_H__ #include <soc/gpe.h> -#include <soc/gpio.h> +#include <gpio.h> /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI diff --git a/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h b/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h index 9ca9ee7..a02c10b 100644 --- a/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h +++ b/src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h @@ -4,7 +4,7 @@ #define __BASEBOARD_GPIO_H__ #include <soc/gpe.h> -#include <soc/gpio.h> +#include <gpio.h> /* TODO: Set the correct values */ #define EC_SCI_GPI 0 diff --git a/src/mainboard/google/brya/variants/brask/gpio.c b/src/mainboard/google/brya/variants/brask/gpio.c index 1938d5a..1bdea2f 100644 --- a/src/mainboard/google/brya/variants/brask/gpio.c +++ b/src/mainboard/google/brya/variants/brask/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/brya0/gpio.c b/src/mainboard/google/brya/variants/brya0/gpio.c index 34b5043..16c11e5 100644 --- a/src/mainboard/google/brya/variants/brya0/gpio.c +++ b/src/mainboard/google/brya/variants/brya0/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <boardid.h> -#include <soc/gpio.h> +#include <gpio.h> static const struct pad_config board_id0_1_overrides[] = { /* B2 : VRALERT# ==> NC */ diff --git a/src/mainboard/google/brya/variants/bujia/gpio.c b/src/mainboard/google/brya/variants/bujia/gpio.c index 484ce29..9254bb9 100644 --- a/src/mainboard/google/brya/variants/bujia/gpio.c +++ b/src/mainboard/google/brya/variants/bujia/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/craask/gpio.c b/src/mainboard/google/brya/variants/craask/gpio.c index b68e406..09684cd 100644 --- a/src/mainboard/google/brya/variants/craask/gpio.c +++ b/src/mainboard/google/brya/variants/craask/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage for craask */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/craaskov/gpio.c b/src/mainboard/google/brya/variants/craaskov/gpio.c index 0d280ce..4d9403a 100644 --- a/src/mainboard/google/brya/variants/craaskov/gpio.c +++ b/src/mainboard/google/brya/variants/craaskov/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/crota/gpio.c b/src/mainboard/google/brya/variants/crota/gpio.c index be9b74c..83da021 100644 --- a/src/mainboard/google/brya/variants/crota/gpio.c +++ b/src/mainboard/google/brya/variants/crota/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/dochi/gpio.c b/src/mainboard/google/brya/variants/dochi/gpio.c index ad1b334..96ef7dc 100644 --- a/src/mainboard/google/brya/variants/dochi/gpio.c +++ b/src/mainboard/google/brya/variants/dochi/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/felwinter/gpio.c b/src/mainboard/google/brya/variants/felwinter/gpio.c index 60a935d..ef0fc5e 100644 --- a/src/mainboard/google/brya/variants/felwinter/gpio.c +++ b/src/mainboard/google/brya/variants/felwinter/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/gaelin/gpio.c b/src/mainboard/google/brya/variants/gaelin/gpio.c index 29abff3..7d27d7f 100644 --- a/src/mainboard/google/brya/variants/gaelin/gpio.c +++ b/src/mainboard/google/brya/variants/gaelin/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/gimble/gpio.c b/src/mainboard/google/brya/variants/gimble/gpio.c index bf205bc..8a72ae8 100644 --- a/src/mainboard/google/brya/variants/gimble/gpio.c +++ b/src/mainboard/google/brya/variants/gimble/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/gimble4es/gpio.c b/src/mainboard/google/brya/variants/gimble4es/gpio.c index 899f597..136758f 100644 --- a/src/mainboard/google/brya/variants/gimble4es/gpio.c +++ b/src/mainboard/google/brya/variants/gimble4es/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/gladios/gpio.c b/src/mainboard/google/brya/variants/gladios/gpio.c index 1dfef5c..061ea0a 100644 --- a/src/mainboard/google/brya/variants/gladios/gpio.c +++ b/src/mainboard/google/brya/variants/gladios/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/glassway/gpio.c b/src/mainboard/google/brya/variants/glassway/gpio.c index 79697d5..675bc80 100644 --- a/src/mainboard/google/brya/variants/glassway/gpio.c +++ b/src/mainboard/google/brya/variants/glassway/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage for glassway */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/gothrax/gpio.c b/src/mainboard/google/brya/variants/gothrax/gpio.c index 077c850..dcedf43 100644 --- a/src/mainboard/google/brya/variants/gothrax/gpio.c +++ b/src/mainboard/google/brya/variants/gothrax/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> #include <fw_config.h> /* Pad configuration in ramstage */ diff --git a/src/mainboard/google/brya/variants/hades/gpio.c b/src/mainboard/google/brya/variants/hades/gpio.c index f826a65..8c3fc64 100644 --- a/src/mainboard/google/brya/variants/hades/gpio.c +++ b/src/mainboard/google/brya/variants/hades/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <types.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> /* Pad configuration in ramstage */ diff --git a/src/mainboard/google/brya/variants/joxer/gpio.c b/src/mainboard/google/brya/variants/joxer/gpio.c index f105861..a89a6f9 100644 --- a/src/mainboard/google/brya/variants/joxer/gpio.c +++ b/src/mainboard/google/brya/variants/joxer/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/kano/gpio.c b/src/mainboard/google/brya/variants/kano/gpio.c index dee853d..cdfaeff 100644 --- a/src/mainboard/google/brya/variants/kano/gpio.c +++ b/src/mainboard/google/brya/variants/kano/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/kinox/gpio.c b/src/mainboard/google/brya/variants/kinox/gpio.c index 7fa9f24..b9adedd 100644 --- a/src/mainboard/google/brya/variants/kinox/gpio.c +++ b/src/mainboard/google/brya/variants/kinox/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <types.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> /* Pad configuration in ramstage */ diff --git a/src/mainboard/google/brya/variants/kuldax/gpio.c b/src/mainboard/google/brya/variants/kuldax/gpio.c index 556e8b6..7c701b2 100644 --- a/src/mainboard/google/brya/variants/kuldax/gpio.c +++ b/src/mainboard/google/brya/variants/kuldax/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/lisbon/gpio.c b/src/mainboard/google/brya/variants/lisbon/gpio.c index 1dfef5c..061ea0a 100644 --- a/src/mainboard/google/brya/variants/lisbon/gpio.c +++ b/src/mainboard/google/brya/variants/lisbon/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/marasov/gpio.c b/src/mainboard/google/brya/variants/marasov/gpio.c index 15760fd..f05e6d1 100644 --- a/src/mainboard/google/brya/variants/marasov/gpio.c +++ b/src/mainboard/google/brya/variants/marasov/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <boardid.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/mithrax/gpio.c b/src/mainboard/google/brya/variants/mithrax/gpio.c index 60a935d..ef0fc5e 100644 --- a/src/mainboard/google/brya/variants/mithrax/gpio.c +++ b/src/mainboard/google/brya/variants/mithrax/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/nereid/gpio.c b/src/mainboard/google/brya/variants/nereid/gpio.c index ab7a47c..20c6dee 100644 --- a/src/mainboard/google/brya/variants/nereid/gpio.c +++ b/src/mainboard/google/brya/variants/nereid/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/nivviks/gpio.c b/src/mainboard/google/brya/variants/nivviks/gpio.c index c61ac2a..247ed2c 100644 --- a/src/mainboard/google/brya/variants/nivviks/gpio.c +++ b/src/mainboard/google/brya/variants/nivviks/gpio.c @@ -4,7 +4,7 @@ #include <baseboard/variants.h> #include <boardid.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage for nivviks board_id = 0 */ static const struct pad_config board_id0_overrides[] = { diff --git a/src/mainboard/google/brya/variants/nova/gpio.c b/src/mainboard/google/brya/variants/nova/gpio.c index 6ed8823..633f4cd 100644 --- a/src/mainboard/google/brya/variants/nova/gpio.c +++ b/src/mainboard/google/brya/variants/nova/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/omnigul/gpio.c b/src/mainboard/google/brya/variants/omnigul/gpio.c index 46d1584..2c752c7 100644 --- a/src/mainboard/google/brya/variants/omnigul/gpio.c +++ b/src/mainboard/google/brya/variants/omnigul/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/orisa/gpio.c b/src/mainboard/google/brya/variants/orisa/gpio.c index beee6fc..ee708bf 100644 --- a/src/mainboard/google/brya/variants/orisa/gpio.c +++ b/src/mainboard/google/brya/variants/orisa/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> #include <types.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/brya/variants/osiris/gpio.c b/src/mainboard/google/brya/variants/osiris/gpio.c index da31791..205b416 100644 --- a/src/mainboard/google/brya/variants/osiris/gpio.c +++ b/src/mainboard/google/brya/variants/osiris/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/pirrha/gpio.c b/src/mainboard/google/brya/variants/pirrha/gpio.c index 431b613..f8f9d3c 100644 --- a/src/mainboard/google/brya/variants/pirrha/gpio.c +++ b/src/mainboard/google/brya/variants/pirrha/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/primus/gpio.c b/src/mainboard/google/brya/variants/primus/gpio.c index 955c804..c35995e 100644 --- a/src/mainboard/google/brya/variants/primus/gpio.c +++ b/src/mainboard/google/brya/variants/primus/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/pujjo/gpio.c b/src/mainboard/google/brya/variants/pujjo/gpio.c index 95bdbd2..4c9a51d 100644 --- a/src/mainboard/google/brya/variants/pujjo/gpio.c +++ b/src/mainboard/google/brya/variants/pujjo/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> #include <fw_config.h> /* Pad configuration in ramstage for Pujjo */ diff --git a/src/mainboard/google/brya/variants/pujjoga/gpio.c b/src/mainboard/google/brya/variants/pujjoga/gpio.c index cf5c9bd..8249189 100644 --- a/src/mainboard/google/brya/variants/pujjoga/gpio.c +++ b/src/mainboard/google/brya/variants/pujjoga/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage for Sundance */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/quandiso/gpio.c b/src/mainboard/google/brya/variants/quandiso/gpio.c index 55b2905..3df66dc 100644 --- a/src/mainboard/google/brya/variants/quandiso/gpio.c +++ b/src/mainboard/google/brya/variants/quandiso/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/redrix/gpio.c b/src/mainboard/google/brya/variants/redrix/gpio.c index c83a683..fe51b015 100644 --- a/src/mainboard/google/brya/variants/redrix/gpio.c +++ b/src/mainboard/google/brya/variants/redrix/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/redrix4es/gpio.c b/src/mainboard/google/brya/variants/redrix4es/gpio.c index 05506ed..c0cb1c5 100644 --- a/src/mainboard/google/brya/variants/redrix4es/gpio.c +++ b/src/mainboard/google/brya/variants/redrix4es/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/skolas/gpio.c b/src/mainboard/google/brya/variants/skolas/gpio.c index 444adc4..3bccaca 100644 --- a/src/mainboard/google/brya/variants/skolas/gpio.c +++ b/src/mainboard/google/brya/variants/skolas/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <boardid.h> -#include <soc/gpio.h> +#include <gpio.h> static const struct pad_config board_id0_1_overrides[] = { /* B2 : VRALERT# ==> NC */ diff --git a/src/mainboard/google/brya/variants/skolas4es/gpio.c b/src/mainboard/google/brya/variants/skolas4es/gpio.c index 7e11c93..8a11129 100644 --- a/src/mainboard/google/brya/variants/skolas4es/gpio.c +++ b/src/mainboard/google/brya/variants/skolas4es/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <boardid.h> -#include <soc/gpio.h> +#include <gpio.h> static const struct pad_config board_id0_1_overrides[] = { /* B2 : VRALERT# ==> NC */ diff --git a/src/mainboard/google/brya/variants/sundance/gpio.c b/src/mainboard/google/brya/variants/sundance/gpio.c index bd36f05..e408001 100644 --- a/src/mainboard/google/brya/variants/sundance/gpio.c +++ b/src/mainboard/google/brya/variants/sundance/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> #include <fw_config.h> /* Pad configuration in ramstage for Sundance */ diff --git a/src/mainboard/google/brya/variants/taeko/gpio.c b/src/mainboard/google/brya/variants/taeko/gpio.c index 76f574c..a5f69b2 100644 --- a/src/mainboard/google/brya/variants/taeko/gpio.c +++ b/src/mainboard/google/brya/variants/taeko/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/taeko4es/gpio.c b/src/mainboard/google/brya/variants/taeko4es/gpio.c index f7cc5e2..73ba0e7 100644 --- a/src/mainboard/google/brya/variants/taeko4es/gpio.c +++ b/src/mainboard/google/brya/variants/taeko4es/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/taniks/gpio.c b/src/mainboard/google/brya/variants/taniks/gpio.c index f242281..d6424e1 100644 --- a/src/mainboard/google/brya/variants/taniks/gpio.c +++ b/src/mainboard/google/brya/variants/taniks/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/trulo/gpio.c b/src/mainboard/google/brya/variants/trulo/gpio.c index 1a6d1b1..1584571 100644 --- a/src/mainboard/google/brya/variants/trulo/gpio.c +++ b/src/mainboard/google/brya/variants/trulo/gpio.c @@ -2,7 +2,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> #include <types.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/brya/variants/uldren/gpio.c b/src/mainboard/google/brya/variants/uldren/gpio.c index 0ea14cd..16a66a8 100644 --- a/src/mainboard/google/brya/variants/uldren/gpio.c +++ b/src/mainboard/google/brya/variants/uldren/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/vell/gpio.c b/src/mainboard/google/brya/variants/vell/gpio.c index 54d7750..0a9f10e 100644 --- a/src/mainboard/google/brya/variants/vell/gpio.c +++ b/src/mainboard/google/brya/variants/vell/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/volmar/gpio.c b/src/mainboard/google/brya/variants/volmar/gpio.c index 7525fbd..34ef2a5 100644 --- a/src/mainboard/google/brya/variants/volmar/gpio.c +++ b/src/mainboard/google/brya/variants/volmar/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/xivu/gpio.c b/src/mainboard/google/brya/variants/xivu/gpio.c index 18894fe..9a7cf3f 100644 --- a/src/mainboard/google/brya/variants/xivu/gpio.c +++ b/src/mainboard/google/brya/variants/xivu/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/xol/gpio.c b/src/mainboard/google/brya/variants/xol/gpio.c index 39478a1..3ec8a89 100644 --- a/src/mainboard/google/brya/variants/xol/gpio.c +++ b/src/mainboard/google/brya/variants/xol/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> static const struct pad_config gpio_overrides[] = { /* A6 : ESPI_ALERT1# ==> NC */ diff --git a/src/mainboard/google/brya/variants/yaviks/gpio.c b/src/mainboard/google/brya/variants/yaviks/gpio.c index 19178d8..940f1f2 100644 --- a/src/mainboard/google/brya/variants/yaviks/gpio.c +++ b/src/mainboard/google/brya/variants/yaviks/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> #include <fw_config.h> /* Pad configuration in ramstage */ diff --git a/src/mainboard/google/brya/variants/yavilla/gpio.c b/src/mainboard/google/brya/variants/yavilla/gpio.c index fb7577f..7208e2c 100644 --- a/src/mainboard/google/brya/variants/yavilla/gpio.c +++ b/src/mainboard/google/brya/variants/yavilla/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/zydron/gpio.c b/src/mainboard/google/brya/variants/zydron/gpio.c index dee853d..cdfaeff 100644 --- a/src/mainboard/google/brya/variants/zydron/gpio.c +++ b/src/mainboard/google/brya/variants/zydron/gpio.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> -#include <soc/gpio.h> +#include <gpio.h> /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/82796?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d4342e88fdbac2e326568df9ad03af18a55ce7a Gerrit-Change-Number: 82796 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp: Remove duplicated Kconfig POSTCAR_STAGE
by Lean Sheng Tan (Code Review) 04 Jun '24

04 Jun '24

Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Shuo Liu, Tim Chu. Lean Sheng Tan has posted comments on this change by Jincheng Li. ( https://review.coreboot.org/c/coreboot/+/82795?usp=email ) Change subject: soc/intel/xeon_sp: Remove duplicated Kconfig POSTCAR_STAGE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3f94e6cc76c8f376119ffa8ec43fa1a43fb40977 Gerrit-Change-Number: 82795 Gerrit-PatchSet: 1 Gerrit-Owner: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 04 Jun 2024 07:38:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp: Remove duplicated Kconfig POSTCAR_STAGE
by Jincheng Li (Code Review) 04 Jun '24

04 Jun '24

Jincheng Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82795?usp=email ) Change subject: soc/intel/xeon_sp: Remove duplicated Kconfig POSTCAR_STAGE ...................................................................... soc/intel/xeon_sp: Remove duplicated Kconfig POSTCAR_STAGE POSTCAR_STAGE is already selected in XEON_SP_COMMON_BASE Change-Id: I3f94e6cc76c8f376119ffa8ec43fa1a43fb40977 Signed-off-by: Jincheng Li <jincheng.li(a)intel.com> --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/82795/1 diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 45c7d9d..22cc366 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -46,7 +46,6 @@ select USE_FSP_NOTIFY_PHASE_POST_PCI_ENUM select USE_FSP_NOTIFY_PHASE_READY_TO_BOOT select USE_FSP_NOTIFY_PHASE_END_OF_FIRMWARE - select POSTCAR_STAGE if XEON_SP_COMMON_BASE -- To view, visit https://review.coreboot.org/c/coreboot/+/82795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3f94e6cc76c8f376119ffa8ec43fa1a43fb40977 Gerrit-Change-Number: 82795 Gerrit-PatchSet: 1 Gerrit-Owner: Jincheng Li <jincheng.li(a)intel.com>

1 0

[XS] Change in coreboot[main]: 3rdparty/intel-microcode: Update submodule to upstream main
by Elyes Haouas (Code Review) 04 Jun '24

04 Jun '24

Attention is currently required from: Felix Singer. Elyes Haouas has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/82789?usp=email ) Change subject: 3rdparty/intel-microcode: Update submodule to upstream main ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia34ba03a9c2f206be760133edbbadcc541ff273b Gerrit-Change-Number: 82789 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Tue, 04 Jun 2024 07:34:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: chromeec: supporting reading long battery strings
by Subrata Banik (Code Review) 04 Jun '24

04 Jun '24

Attention is currently required from: Forest Mittelberg, Peter Marheine. Subrata Banik has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/coreboot/+/82775?usp=email ) Change subject: chromeec: supporting reading long battery strings ...................................................................... Patch Set 1: (1 comment) File src/ec/google/chromeec/acpi/battery.asl: https://review.coreboot.org/c/coreboot/+/82775/comment/ca43a8e2_56a1a0d5?us… : PS1, Line 63: If supported by the EC, may be I'm missing the point here, how do we check if reading the long length Battery string command is supported or not ? -- To view, visit https://review.coreboot.org/c/coreboot/+/82775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia29cacb7d86402490f9ac458f0be50e3f2192b04 Gerrit-Change-Number: 82775 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 04 Jun 2024 07:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/brox: Update verb table to refine speaker amp DC offset
by Paul Menzel (Code Review) 04 Jun '24

04 Jun '24

Attention is currently required from: Terry Cheong, Vamshi Krishna Gopal. Paul Menzel has posted comments on this change by Terry Cheong. ( https://review.coreboot.org/c/coreboot/+/82794?usp=email ) Change subject: mb/google/brox: Update verb table to refine speaker amp DC offset ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82794/comment/46496381_00648b3f?us… : PS2, Line 9: DC offset of class-D amplifier is larger than expectation in Brox. Please add concrete values. https://review.coreboot.org/c/coreboot/+/82794/comment/fe165b78_9d70d6f5?us… : PS2, Line 10: based : on the updated verb table provided by Realtek Is that a comment in the bug report? https://review.coreboot.org/c/coreboot/+/82794/comment/e5eef5eb_b199aafd?us… : PS2, Line 15: TEST=Verify DC offset of speaker amplier is less than 3mV How? And what value did you measure? -- To view, visit https://review.coreboot.org/c/coreboot/+/82794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I776f5c24ce3c829cbd64840957c1431608cf2b85 Gerrit-Change-Number: 82794 Gerrit-PatchSet: 2 Gerrit-Owner: Terry Cheong <htcheong(a)chromium.org> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Attention: Terry Cheong <htcheong(a)chromium.org> Gerrit-Comment-Date: Tue, 04 Jun 2024 07:09:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: spd/lp5: Add SPD for MT62F1G32D2DS-023 WT:C and K3KL8L80DM-MGCU
by Paul Menzel (Code Review) 04 Jun '24

04 Jun '24

Attention is currently required from: Derek Huang, Kun Liu, Shelley Chen. Paul Menzel has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/82604?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: spd/lp5: Add SPD for MT62F1G32D2DS-023 WT:C and K3KL8L80DM-MGCU ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82604/comment/4c419e38_a719d72a?us… : PS2, Line 7: SPD SPDs https://review.coreboot.org/c/coreboot/+/82604/comment/c8596394_ed6878c1?us… : PS2, Line 9: Add MT62F1G32D2DS-023 WT:C and K3KL8L80DM-MGCU Please add the vendors. -- To view, visit https://review.coreboot.org/c/coreboot/+/82604?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5c3ed46829330f83e144cf8d18be6fa808431aa Gerrit-Change-Number: 82604 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 04 Jun 2024 07:06:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024