Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email )
Change subject: gma pipe_setup: Update for TGL & ADL
......................................................................
Patch Set 33:
(9 comments)
File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/67494/comment/e395dfd3_ce089faf :
PS32, Line 222: Has_TGL_Plane_Control : <genbool> := Tigerlake_On;
> Looks like the `PLANE_COLOR_CTL` registers were first introduced with GLK (N.B. […]
Done
File common/hw-gfx-gma-pipe_setup.adb:
https://review.coreboot.org/c/libgfxinit/+/67494/comment/7ca81fae_ea661482 :
PS28, Line 221: Config.Variable)),
> GNATprove stumbles here because it's only true for the new platforms. […]
Done
File common/hw-gfx-gma-pipe_setup.adb:
https://review.coreboot.org/c/libgfxinit/+/67494/comment/2e96bbe8_f6535985 :
PS32, Line 46: PLANE_COLOR_CTL_GAMMA_DISABLE : constant := 1 * 2 ** 13;
> nit: Apparently this bit is *plane* gamma disable. […]
I didn't want to drop the CTL_ (part of the register name), but added the PLANE_.
https://review.coreboot.org/c/libgfxinit/+/67494/comment/e7639896_deab49ec :
PS32, Line 228: function PLANE_CTL_ARB_SLOTS (N : Word32) return Word32
: is (Shift_Left (N, 28));
> nit: format function expressions so that the first line ends with `is` and the second line contains […]
Done
https://review.coreboot.org/c/libgfxinit/+/67494/comment/de720e00_fff707e0 :
PS32, Line 254: then PLANE_CTL_ARB_SLOTS (1)
> Looks like the value used here is dependent on plane state: […]
On TGL we use the hardware defaults, i.e. don't set USE_PROGRAMMED_SLOTS.
I assume the hardcoded 1 is what used to be the default, but not sure
anymore.
https://review.coreboot.org/c/libgfxinit/+/67494/comment/64955cad_20a3f01d :
PS32, Line 266: Value => 0);
Moving this out of the if, because PLANE_AUX_DIST seems to exist since `Has_Plane_Control` and should default to 0.
https://review.coreboot.org/c/libgfxinit/+/67494/comment/2eda732d_915f1be3 :
PS32, Line 326: type BW_Credit is new Natural range 0 .. 3;
: function MBUS_DBOX_BW_CREDIT (C : BW_Credit) return Word32
: is (Shift_Left (Word32 (C), 14));
:
: type B_Credit is new Natural range 0 .. 31;
: function MBUS_DBOX_B_CREDIT (C : B_Credit) return Word32
: is (Shift_Left (Word32 (C), 8));
:
: type A_Credit is new Natural range 0 .. 15;
: function MBUS_DBOX_A_CREDIT (C : A_Credit) return Word32
: is (Word32 (C));
:
: type B2B_Trans_Max is new Natural range 0 .. 31;
: function MBUS_DBOX_B2B_TRANSACTIONS_MAX (B : B2B_Trans_Max) return Word32
: is (Shift_Left (Word32 (B), 20));
:
: type B2B_Trans_Delay is new Natural range 0 .. 7;
: function MBUS_DBOX_B2B_TRANSACTIONS_DELAY (B : B2B_Trans_Delay) return Word32
: is (Shift_Left (Word32 (B), 17));
: MBUS_DBOX_REGULATE_B2B_TRANSACTIONS_EN : constant := 1 * 2 ** 16;
:
> nit: format for function expressions (see previous comment)
Done
https://review.coreboot.org/c/libgfxinit/+/67494/comment/08810fdf_f5fd19ad :
PS32, Line 380: -- ADL_P requires that we disable underrun recovery when
: -- downscaling (or using the scaler for YUV420 pipe output),
: -- using DSC, or using PSR2.
> From i915 sources: […]
Anything to do beside updating the comment?
https://review.coreboot.org/c/libgfxinit/+/67494/comment/f95f9b25_ea6f8603 :
PS32, Line 441: Has_TGL_Plane_Control
> AIUI, this is TGL+ (technically `PIPE_MISC_HDR_MODE_PRECISION` is ICL+ and only when `is_hdr_mode(cr […]
I also stumbled over this. And I actually see no reason to set these bits.
I'll try to do some tests.
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67494?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3
Gerrit-Change-Number: 67494
Gerrit-PatchSet: 33
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 21:33:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Dinesh Gehlot, Elyes Haouas, Paul Menzel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81522?usp=email )
Change subject: gma display_probing: Make new TGL ports available
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/81522/comment/d7a08acf_c49f1f95 :
PS1, Line 8:
> `intel-gfx-prm-osrc-tgl-vol-12-display-engine.pdf` mentions these ports.
I've referenced the commit that added them. Hope that's enough?
File common/hw-gfx-gma-display_probing.ads:
https://review.coreboot.org/c/libgfxinit/+/81522/comment/e4f45a18_c99933dd :
PS4, Line 26: USBC1_HDMI, USBC2_HDMI, USBC3_HDMI, USBC4_HDMI, USBC5_HDMI, USBC6_HDMI,
> I see DP ports get mapped above, should the same be done for these?
You mean the other file? That's inside an
if Config_Helpers.To_Display_Type (Port) = DP
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/81522?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d
Gerrit-Change-Number: 81522
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 23 Apr 2024 21:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Dinesh Gehlot, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#43) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67801?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons
Change subject: gma: Support ADL-P CDClk clock crawl
......................................................................
gma: Support ADL-P CDClk clock crawl
Setting up CDCLK is a little different for ADL-P, i915 calls it
adlp_cdclk_pll_crawl.
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Change-Id: Id01752a41e4e401a5f759453c12f368395eebdf2
---
M common/hw-gfx-gma-config.ads.template
M common/tigerlake/Makefile.inc
M common/tigerlake/hw-gfx-gma-connectors-tc.adb
M common/tigerlake/hw-gfx-gma-port_detect.adb
A common/tigerlake/hw-gfx-gma-power_and_clocks-tgl.adb
A common/tigerlake/hw-gfx-gma-power_and_clocks-tgl.ads
A common/tigerlake/hw-gfx-gma-power_and_clocks-xelpd.adb
A common/tigerlake/hw-gfx-gma-power_and_clocks-xelpd.ads
M common/tigerlake/hw-gfx-gma-power_and_clocks.adb
M common/tigerlake/hw-gfx-gma-power_and_clocks.ads
10 files changed, 1,293 insertions(+), 485 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/01/67801/43
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67801?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Id01752a41e4e401a5f759453c12f368395eebdf2
Gerrit-Change-Number: 67801
Gerrit-PatchSet: 43
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Dinesh Gehlot, Nico Huber.
Hello Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/81524?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+2 by Angel Pons
Change subject: gma connectors: Add `Pipe' parameter to Pre_/Post_Off procedures
......................................................................
gma connectors: Add `Pipe' parameter to Pre_/Post_Off procedures
Change-Id: I01dbf3cae3dfef2130fa10116f70f23238c7a48c
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/g45/hw-gfx-gma-connectors.adb
M common/haswell_shared/hw-gfx-gma-connectors.adb
M common/hw-gfx-gma-connectors.ads
M common/hw-gfx-gma.adb
M common/ironlake/hw-gfx-gma-connectors.adb
M common/tigerlake/hw-gfx-gma-connectors.adb
6 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/24/81524/5
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/81524?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I01dbf3cae3dfef2130fa10116f70f23238c7a48c
Gerrit-Change-Number: 81524
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#34) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67495?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons
Change subject: gma tgl: Fill out power and clocks module
......................................................................
gma tgl: Fill out power and clocks module
This is the modeset sequence for the display engine itself. TGL has
similarities to both SKL and BXT, but also adds new programming, like
MBUS credits, Bandwidth Buddy, and of course new chicken bits.
Tested on google/delbin; can still boot successfully to the kernel and
the kernel can still properly perform its own modeset and not crash :)
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
Change-Id: I8f09696588aa73cebc7a44583ae5e029c705a535
---
M common/tigerlake/hw-gfx-gma-power_and_clocks.adb
M common/tigerlake/hw-gfx-gma-power_and_clocks.ads
2 files changed, 818 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/95/67495/34
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67495?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I8f09696588aa73cebc7a44583ae5e029c705a535
Gerrit-Change-Number: 67495
Gerrit-PatchSet: 34
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#33) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Code-Review+1 by Nico Huber
Change subject: gma pipe_setup: Update for TGL & ADL
......................................................................
gma pipe_setup: Update for TGL & ADL
Tiger Lake requires some differences in plane programming over prior
generations, including new chicken bits, wider watermarks, MBUS DBOX
programming and a few bits moved around. Alder Lake brings some more
chicken bits and requires arb-slot programming.
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3
---
M common/hw-gfx-gma-config.ads.template
M common/hw-gfx-gma-pipe_setup.adb
M common/hw-gfx-gma-pipe_setup.ads
M common/hw-gfx-gma-transcoder.adb
4 files changed, 151 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/94/67494/33
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67494?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3
Gerrit-Change-Number: 67494
Gerrit-PatchSet: 33
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Dinesh Gehlot, Elyes Haouas, Nico Huber, Paul Menzel.
Hello Angel Pons, Elyes Haouas, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/81522?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by Elyes Haouas, Code-Review+1 by Paul Menzel, Code-Review+2 by Angel Pons
Change subject: gma display_probing: Make new TGL ports available
......................................................................
gma display_probing: Make new TGL ports available
Make all the new ports available that were added to `Port_Type` in
commit 605660bb21 (gma: Begin Tiger Lake (TGL) integration).
Change-Id: I9d96673f931be0086536044694ecd127ba2a823d
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-display_probing.adb
M common/hw-gfx-gma-display_probing.ads
2 files changed, 26 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/22/81522/5
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/81522?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d
Gerrit-Change-Number: 81522
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset