Attention is currently required from: Jian Tong.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82056?usp=email )
Change subject: mb/google/brox/var/lotso: Add fw_config field for storage
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb62e3f37e1480979ae529692455beb533434520
Gerrit-Change-Number: 82056
Gerrit-PatchSet: 4
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 24 Apr 2024 03:07:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81781?usp=email )
Change subject: mb/google/nissa/var/glassway: Enable Wi-Fi sar table for Intel module
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81781?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e43081c93ef17291c5d55cf262a0f4d1497447b
Gerrit-Change-Number: 81781
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 24 Apr 2024 02:51:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81781?usp=email
to look at the new patch set (#2).
Change subject: mb/google/nissa/var/glassway: Enable Wi-Fi sar table for Intel module
......................................................................
mb/google/nissa/var/glassway: Enable Wi-Fi sar table for Intel module
1.Enable CHROMEOS_WIFI_SAR flag to load a SAR table for Intel module.
2.Describe the FW_CONFIG probe for the settings on glassway.
- WIFI_SAR_0 for Intel Wi-Fi module AX211
BUG=None
BRANCH=firmware-nissa-15217.B
TEST=emerge-nissa coreboot chromeos-bootimage
Change-Id: I9e43081c93ef17291c5d55cf262a0f4d1497447b
Signed-off-by: Daniel_Peng <Daniel_Peng(a)pegatron.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/glassway/Makefile.mk
M src/mainboard/google/brya/variants/glassway/overridetree.cb
A src/mainboard/google/brya/variants/glassway/variant.c
4 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/81781/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81781?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e43081c93ef17291c5d55cf262a0f4d1497447b
Gerrit-Change-Number: 81781
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Jian Tong.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82056?usp=email )
Change subject: mb/google/brox/var/lotso: Add fw_config field for storage
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/82056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb62e3f37e1480979ae529692455beb533434520
Gerrit-Change-Number: 82056
Gerrit-PatchSet: 4
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 24 Apr 2024 02:18:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kun Liu.
Hello Eric Lai, Kun Liu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82056?usp=email
to look at the new patch set (#4).
Change subject: mb/google/brox/var/lotso: Add fw_config field for storage
......................................................................
mb/google/brox/var/lotso: Add fw_config field for storage
Add STORAGE_UNKNOWN, STORAGE_UFS, STORAGE_NVME for storage fw_config
field to prevent depthcharge build break.
BUG=b:333494257
TEST=emerge-brox coreboot depthcharge sys-boot/chromeos-bootimage
Change-Id: Idb62e3f37e1480979ae529692455beb533434520
Signed-off-by: tongjian <tongjian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/lotso/overridetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/82056/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/82056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb62e3f37e1480979ae529692455beb533434520
Gerrit-Change-Number: 82056
Gerrit-PatchSet: 4
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Kun Liu.
Hello Eric Lai, Kun Liu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82056?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brox/var/lotso: Add fw_config field for storage
......................................................................
mb/google/brox/var/lotso: Add fw_config field for storage
Add STORAGE_UNKNOWN, STORAGE_UFS, STORAGE_NVME for storage fw_config
field to prevent depthcharge build break.
BUG=b:333494257
TEST=emerge-brox coreboot depthcharge sys-boot/chromeos-bootimage
Change-Id: Idb62e3f37e1480979ae529692455beb533434520
Signed-off-by: tongjian <tongjian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/lotso/overridetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/82056/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/82056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb62e3f37e1480979ae529692455beb533434520
Gerrit-Change-Number: 82056
Gerrit-PatchSet: 3
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Jian Tong has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/82056?usp=email )
Change subject: mb/google/brox/var/lotso: Add fw_config field for storage
......................................................................
mb/google/brox/var/lotso: Add fw_config field for storage
Add STORAGE_UNKNOWN, STORAGE_UFS, STORAGE_NVME for storage fw_config
field to prevent depthcharge build break.
BUG=b:333494257
TEST=emerge-brox coreboot depthcharge sys-boot/chromeos-bootimage
Change-Id: Idb62e3f37e1480979ae529692455beb533434520
Signed-off-by: tongjian <tongjian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/lotso/overridetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/82056/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb62e3f37e1480979ae529692455beb533434520
Gerrit-Change-Number: 82056
Gerrit-PatchSet: 2
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset