coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[L] Change in coreboot[main]: drivers/intel/touch: Add driver for Intel Touch Controller and Devices
by Paul Menzel (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Cliff Huang, Eran Mitrani, Eric Lai, Jingyuan Liang, Kyoung Il Kim. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81331?usp=email ) Change subject: drivers/intel/touch: Add driver for Intel Touch Controller and Devices ...................................................................... Patch Set 4: (18 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81331/comment/21b7fd22_d07dd5a5 : PS4, Line 9: controller(THC) Please add space before the (. https://review.coreboot.org/c/coreboot/+/81331/comment/2e07ac77_0a81f556 : PS4, Line 14: Meteorlake Meteor Lake File src/drivers/intel/touch/chip.h: https://review.coreboot.org/c/coreboot/+/81331/comment/6079db90_272f9425 : PS4, Line 11: MAX_TOUCH_PORTS MAX_TOUCH_PORTS_PER_CONTROLLER? https://review.coreboot.org/c/coreboot/+/81331/comment/e2fad248_8d42d2e5 : PS4, Line 23: Meteorlake Meteor Lake https://review.coreboot.org/c/coreboot/+/81331/comment/2829eceb_c5b5cfd3 : PS4, Line 30: /* Touch Host Controller's (THC) 3 protocol modes: : * Switch among IPTS, HID-SPI and HID-I2C. : * 0x0: THC IPTS (not supported at this time) : * 0x1: THC HID SPI : * 0x2: THC HID I2C (for future support) : */ Blank line at the top. /* * […] * / https://review.coreboot.org/c/coreboot/+/81331/comment/01bfc2aa_f6bddc00 : PS4, Line 45: unsigned int enable_delay_ms; Is there a better name? `delay_after_enabling_device_ms`? https://review.coreboot.org/c/coreboot/+/81331/comment/2f5595f1_7ce9040b : PS4, Line 57: rpt I’d use report. https://review.coreboot.org/c/coreboot/+/81331/comment/1e5a691a_d05ef1fb : PS4, Line 63: /* Touch Host Controller Wake On Touch : Based on this setting vGPIO for given THC will be in native mode, and additional : _CRS for wake will be exposed in ACPI : */ Please use the recommended commenting styles. https://review.coreboot.org/c/coreboot/+/81331/comment/d2af3da3_44bb5423 : PS4, Line 70: Spi SPI https://review.coreboot.org/c/coreboot/+/81331/comment/5063f253_fe7876c8 : PS4, Line 71: this This https://review.coreboot.org/c/coreboot/+/81331/comment/c4ddea38_85023cbc : PS4, Line 90: /* Touch Host Controller Hid Over Spi Connection Speed : Hid Over Spi Connection Speed - SPI Frequency : */ Ditto. (Also below.) File src/drivers/intel/touch/elan.h: https://review.coreboot.org/c/coreboot/+/81331/comment/0daab7da_af039e1e : PS4, Line 16: // #define ELAN_CONNECTION_SPEED 17000000 Why commented out? File src/drivers/intel/touch/touch.c: https://review.coreboot.org/c/coreboot/+/81331/comment/d20b2927_17518b75 : PS4, Line 30: in rpt hdr addr Spell it out? https://review.coreboot.org/c/coreboot/+/81331/comment/6fb5515f_8cdc2f2a : PS4, Line 65: "Use TH_SENSOR_GENERIC for parameters from the devicetree!\n"); Indent more? https://review.coreboot.org/c/coreboot/+/81331/comment/57643706_98188594 : PS4, Line 106: printk(BIOS_INFO, "use WACOM Write Opcode\n"); Why only the info message for the first case? What should the user do with this information? https://review.coreboot.org/c/coreboot/+/81331/comment/e3b5ab55_7251018d : PS4, Line 526: static void : touch_generate_acpi_method_on( Why not one line? https://review.coreboot.org/c/coreboot/+/81331/comment/c1c41ed5_9de8e41b : PS4, Line 719: .read_resources = pci_dev_read_resources, : .set_resources = pci_dev_set_resources, : .enable_resources = pci_dev_enable_resources, : .init = pci_dev_init, : .scan_bus = &scan_generic_bus, /* Non-default */ : .ops_pci = &pci_dev_ops_pci, Use tabs for aligning = like below? https://review.coreboot.org/c/coreboot/+/81331/comment/9e9501e0_0800e0a9 : PS4, Line 743: Tab? -- To view, visit https://review.coreboot.org/c/coreboot/+/81331?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e Gerrit-Change-Number: 81331 Gerrit-PatchSet: 4 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Henry Barnor <hbarnor(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 07:05:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/meteorlake: Update Touch Controller UDP params
by Cliff Huang (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Subrata Banik, Tarun. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81332?usp=email ) Change subject: soc/intel/meteorlake: Update Touch Controller UDP params ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81332/comment/6194c7bf_f8bf7689 : PS2, Line 9: The UPD, ThcAssignment, and ThcMode, ThcWakeOnTouch, are > The UPDs ThcAssignment, ThcMode, and ThcWakeOnTouch are … Done https://review.coreboot.org/c/coreboot/+/81332/comment/bf239ea2_3cb96af9 : PS2, Line 11: a weak function drivers_intel_touch_config() is added > Why weak? The _weak function indicates that the boards that build with this support will need to provide the same function with implementation from the board directory. https://review.coreboot.org/c/coreboot/+/81332/comment/d170a0cf_e01e409c : PS2, Line 11: a > A Done File src/soc/intel/meteorlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/81332/comment/cd0a3912_3c793f89 : PS2, Line 639: s_cfg->ThcAssignment[0] = THC_NONE; > use if(!IS_ENABLED(SOC_INTEL_TOUCH)) return? fill_fsps_thc_params function is inserted only when SOC_INTEL_TOUCH is enabled. In fact, #if-#endif is used in several place rather than using conditional statement with build flag, where results in always true or false is placed in the condition. -- To view, visit https://review.coreboot.org/c/coreboot/+/81332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I19edbcad705e889166d7d340b2caa74ab3bf15a1 Gerrit-Change-Number: 81332 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Henry Barnor <hbarnor(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 06:44:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/meteorlake: Update Touch Controller UDP params
by Cliff Huang (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Arthur Heymans, Cliff Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Subrata Banik, Tarun. Hello Arthur Heymans, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81332?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Kyoung Il Kim, Verified+1 by build bot (Jenkins) Change subject: soc/intel/meteorlake: Update Touch Controller UDP params ...................................................................... soc/intel/meteorlake: Update Touch Controller UDP params The UPDs ThcAssignment, ThcMode, and ThcWakeOnTouch are specified via THC driver in the device tree. Therefore, SOC needs to get the driver config. A weak function drivers_intel_touch_config() is added such that the mainboard can implement the function to provide the config from the device tree. The CONFIG_SOC_INTEL_TOUCH is needed to add THC support for Meteorlake SOC. BUG=b:307775082 Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I19edbcad705e889166d7d340b2caa74ab3bf15a1 --- M src/soc/intel/meteorlake/Kconfig M src/soc/intel/meteorlake/chip.c M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/fsp_params.c 4 files changed, 92 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/81332/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I19edbcad705e889166d7d340b2caa74ab3bf15a1 Gerrit-Change-Number: 81332 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Henry Barnor <hbarnor(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: drivers/intel/touch: Add driver for Intel Touch Controller and Devices
by Cliff Huang (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Eran Mitrani, Eric Lai, Jingyuan Liang, Kyoung Il Kim, Paul Menzel. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81331?usp=email ) Change subject: drivers/intel/touch: Add driver for Intel Touch Controller and Devices ...................................................................... Patch Set 4: (16 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81331/comment/a877ebc6_654d9e1f : PS2, Line 9: Support WACOM, ELAN, and generic touch sensor devices. > Please write an introduction what that new device it, and what driver is needed for it. Done https://review.coreboot.org/c/coreboot/+/81331/comment/56df2466_03a7183f : PS2, Line 10: This driver generates the following ACPI objects: > Please add a blank line between paragraphs. Done https://review.coreboot.org/c/coreboot/+/81331/comment/8d58126a_905eabae : PS2, Line 11: _DSM : _CRS : Power resource with _STA, _ON, and _OFF : _RST > Please format this as a list. Done Patchset: PS2: > Separate the ELAN and WACOM support to another patch? This driver is intended to support these two devices to reduce the needs of introducing all necessary parameters in the devicetree. These two headers are included in its touch.c and it makes sense to stay in single patchset:) File src/drivers/intel/touch/chip.h: PS2: > Mention the datasheet name somewhere in the file? Done https://review.coreboot.org/c/coreboot/+/81331/comment/cd518487_5709fc94 : PS2, Line 29: Touch Host Controller Mode > THC's 3 protocol modes. Done https://review.coreboot.org/c/coreboot/+/81331/comment/b2713598_1f5259c6 : PS2, Line 30: Switch between Intel THC protocol and Industry standard HID Over SPI protocol > Switch among IPTS, HID-SPI and HID-I2C. Done https://review.coreboot.org/c/coreboot/+/81331/comment/5e5e61bc_782e9871 : PS2, Line 31: supporded > supported Done https://review.coreboot.org/c/coreboot/+/81331/comment/cabf167d_593265d7 : PS2, Line 31: Thc > THC? Done https://review.coreboot.org/c/coreboot/+/81331/comment/ad46e634_a98e70e3 : PS2, Line 31: : > Please add a space after the colon. Done https://review.coreboot.org/c/coreboot/+/81331/comment/e659abb1_1ce4167a : PS2, Line 33: supporded > supported Done https://review.coreboot.org/c/coreboot/+/81331/comment/9422e825_86834af3 : PS2, Line 33: ; > THC HID I2C is for future support. Done https://review.coreboot.org/c/coreboot/+/81331/comment/0f5f205d_0692affa : PS2, Line 29: /* Touch Host Controller Mode : Switch between Intel THC protocol and Industry standard HID Over SPI protocol. : 0x0:Thc IPTS (not supporded at this time) : 0x1:Thc HID SPI : 0x2 Thc HID I2C; (not supporded at this time) : */ > I’d use […] Done https://review.coreboot.org/c/coreboot/+/81331/comment/f05946f9_0ab1a715 : PS2, Line 41: /* GPIO used to enable device. */ > Redundant as the variable name says the same? These parameters follow the GPIO ones in./src/soc/intel/common/block/pcie/rtd3/chip.h: /* GPIO used to enable device. */ struct acpi_gpio enable_gpio; /* Delay to be inserted after device is enabled. */ unsigned int enable_delay_ms; /* Delay to be inserted after device is disabled. */ unsigned int enable_off_delay_ms; /* GPIO used to take device out of reset or to put it into reset. */ struct acpi_gpio reset_gpio; /* Delay to be inserted after device is taken out of reset. */ unsigned int reset_delay_ms; /* Delay to be inserted after device is put into reset. */ unsigned int reset_off_delay_ms; Other chip.h files also follow the same way. https://review.coreboot.org/c/coreboot/+/81331/comment/8184a608_cf0aa052 : PS2, Line 46: enable_off > Why not disable? same as the above, #41. File src/drivers/intel/touch/elan.h: https://review.coreboot.org/c/coreboot/+/81331/comment/50816769_de325758 : PS2, Line 9: #define ELAN_RST_SEQ_DLY 50 > Is that time? Put the unit into the name? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81331?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e Gerrit-Change-Number: 81331 Gerrit-PatchSet: 4 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Henry Barnor <hbarnor(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 26 Apr 2024 06:03:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: drivers/intel/touch: Add driver for Intel Touch Controller and Devices
by Cliff Huang (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Cliff Huang, Eran Mitrani, Eric Lai, Jingyuan Liang, Kyoung Il Kim, Paul Menzel. Hello Eran Mitrani, Eric Lai, Jingyuan Liang, Kyoung Il Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81331?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: drivers/intel/touch: Add driver for Intel Touch Controller and Devices ...................................................................... drivers/intel/touch: Add driver for Intel Touch Controller and Devices This driver is for Intel Touch Host controller(THC). THC supports a host controller interface to the touch IC for high bandwidth touch data transfer from SPI based touch ICs. This driver supports WACOM, ELAN, and generic touch sensor devices. ref: Meteorlake UH type4 EDS vol1 640228 This driver generates the following ACPI objects: - _DSM - _CRS - Power resource with _STA, _ON, and _OFF - _RST BUG=b:307775082 Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e --- A src/drivers/intel/touch/Kconfig A src/drivers/intel/touch/Makefile.mk A src/drivers/intel/touch/chip.h A src/drivers/intel/touch/elan.h A src/drivers/intel/touch/touch.c A src/drivers/intel/touch/wacom.h 6 files changed, 983 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/81331/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/81331?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e Gerrit-Change-Number: 81331 Gerrit-PatchSet: 4 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Henry Barnor <hbarnor(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: drivers/intel/touch: Add driver for Intel Touch Controller and Devices
by Cliff Huang (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Cliff Huang, Eran Mitrani, Eric Lai, Jingyuan Liang, Kyoung Il Kim, Paul Menzel. Hello Eran Mitrani, Eric Lai, Jingyuan Liang, Kyoung Il Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81331?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Eric Lai, Code-Review+1 by Kyoung Il Kim, Verified+1 by build bot (Jenkins) Change subject: drivers/intel/touch: Add driver for Intel Touch Controller and Devices ...................................................................... drivers/intel/touch: Add driver for Intel Touch Controller and Devices This driver is for Intel Touch Host controller(THC). THC supports a host controller interface to the touch IC for high bandwidth touch data transfer from SPI based touch ICs. This driver supports WACOM, ELAN, and generic touch sensor devices. ref: Meteorlake UH type4 EDS vol1 640228 This driver generates the following ACPI objects: - _DSM - _CRS - Power resource with _STA, _ON, and _OFF - _RST BUG=b:307775082 Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e --- A src/drivers/intel/touch/Kconfig A src/drivers/intel/touch/Makefile.mk A src/drivers/intel/touch/chip.h A src/drivers/intel/touch/elan.h A src/drivers/intel/touch/touch.c A src/drivers/intel/touch/wacom.h 6 files changed, 981 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/81331/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81331?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e Gerrit-Change-Number: 81331 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Henry Barnor <hbarnor(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: acpi: Fix return value in acpi_device_write_dsd_gpio()
by Jianeng Ceng (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Cliff Huang, Lance Zhao, Paul Menzel, Tim Wawrzynczak. Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email ) Change subject: acpi: Fix return value in acpi_device_write_dsd_gpio() ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82088/comment/1c662cdb_e2ba86ce : PS3, Line 7: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementing value > acpi: Fix return value in acpi_device_write_dsd_gpio Done https://review.coreboot.org/c/coreboot/+/82088/comment/d96ff38b_f03c39e9 : PS3, Line 11: The error was introduced in the commit making it public. > commit 01344bce Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839 Gerrit-Change-Number: 82088 Gerrit-PatchSet: 6 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 03:44:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpi: Fix return value in acpi_device_write_dsd_gpio()
by Jianeng Ceng (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Cliff Huang, Jianeng Ceng, Lance Zhao, Paul Menzel, Tim Wawrzynczak. Hello Cliff Huang, Dolan Liu, Eric Lai, Kapil Porwal, Lance Zhao, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82088?usp=email to look at the new patch set (#6). Change subject: acpi: Fix return value in acpi_device_write_dsd_gpio() ...................................................................... acpi: Fix return value in acpi_device_write_dsd_gpio() Fix ++ as suffix and * precedence. After modification, the gpio index can be obtained correctly. The error was introduced in the commit making it public: commit 01344bce BUG=None TEST= Can get the correct index test on nissa. Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839 Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> --- M src/acpi/device.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/82088/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/82088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839 Gerrit-Change-Number: 82088 Gerrit-PatchSet: 6 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementin...
by Eric Lai (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Cliff Huang, Jianeng Ceng, Lance Zhao, Paul Menzel, Tim Wawrzynczak. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementing value ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82088/comment/495be0ac_ad7d9925 : PS3, Line 7: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementing value > Done acpi: Fix return value in acpi_device_write_dsd_gpio https://review.coreboot.org/c/coreboot/+/82088/comment/257717eb_2132d6e8 : PS3, Line 11: The error was introduced in the commit making it public. > Done commit 01344bce -- To view, visit https://review.coreboot.org/c/coreboot/+/82088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839 Gerrit-Change-Number: 82088 Gerrit-PatchSet: 5 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 03:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementin...
by Jianeng Ceng (Code Review) 26 Apr '24

26 Apr '24

Attention is currently required from: Cliff Huang, Lance Zhao, Paul Menzel, Tim Wawrzynczak. Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email ) Change subject: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementing value ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82088/comment/b7321339_6c190c50 : PS3, Line 7: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementing value > too long. Please shorten. Done https://review.coreboot.org/c/coreboot/+/82088/comment/ddef48ab_2c2a21c6 : PS3, Line 11: The error was introduced in the commit making it public. > You should add the original commit hash here, please check the comment rule in coreboot. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839 Gerrit-Change-Number: 82088 Gerrit-PatchSet: 5 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 03:21:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024